From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-fsdevel-owner@vger.kernel.org>
Received: from zeniv.linux.org.uk ([195.92.253.2]:58318 "EHLO
	ZenIV.linux.org.uk" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1753043AbcGECZ6 (ORCPT
	<rfc822;linux-fsdevel@vger.kernel.org>);
	Mon, 4 Jul 2016 22:25:58 -0400
Date: Tue, 5 Jul 2016 03:25:56 +0100
From: Al Viro <viro@ZenIV.linux.org.uk>
To: Oleg Drokin <green@linuxhacker.ru>
Cc: Mailing List <linux-kernel@vger.kernel.org>,
	"<linux-fsdevel@vger.kernel.org>" <linux-fsdevel@vger.kernel.org>
Subject: Re: More parallel atomic_open/d_splice_alias fun with NFS and
 possibly more FSes.
Message-ID: <20160705022556.GK14480@ZenIV.linux.org.uk>
References: <F861E78B-00C3-4F17-A10D-C9FCB81D43B9@linuxhacker.ru>
 <20160617042914.GD14480@ZenIV.linux.org.uk>
 <FCD75A55-A1BE-48FD-8E90-E9DFFD4DFD99@linuxhacker.ru>
 <20160703062917.GG14480@ZenIV.linux.org.uk>
 <20160704000802.GH14480@ZenIV.linux.org.uk>
 <0145470E-667E-4A8D-AB79-F897322DA441@linuxhacker.ru>
 <20160704030812.GI14480@ZenIV.linux.org.uk>
 <1CFAE5F0-5E46-4B1D-A9EC-2D6286753A35@linuxhacker.ru>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <1CFAE5F0-5E46-4B1D-A9EC-2D6286753A35@linuxhacker.ru>
Sender: linux-fsdevel-owner@vger.kernel.org
List-ID: <linux-fsdevel.vger.kernel.org>

On Sun, Jul 03, 2016 at 11:55:09PM -0400, Oleg Drokin wrote:
> Quite a bit, actually. If you connect to an rogue Lustre server,
> currently there are many ways it can crash the client.
> I suspect this is true not just of Lustre, if e.g. NFS server starts to
> send directory inodes with duplicated inode numbers or some such,
> VFS would not be super happy about such "hardlinked" directories either.
> This is before we even consider that it can feed you garbage data
> to crash your apps (or substitute binaries to do something else).

NFS client is at least supposed to try to be resistant to that.  As in,
"if an 0wn3d NFS server can be escalated to buggered client, it's a bug in
client and we are expected to try and fix it".

[snip]
> Thanks, I'll give this a try.

BTW, could you take a look at
git://git.kernel.org/pub/scm/linux/kernel/git/viro/vfs.git#sendmsg.lustre?
It's a bunch of simplifications that became possible once sendmsg()/recvmsg()
switched to iov_iter, stopped mangling the iovecs and went for predictable
behaviour re advancing the iterator.