From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:55980) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKIQV-0001Nn-KB for qemu-devel@nongnu.org; Tue, 05 Jul 2016 00:57:40 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKIQR-00085w-HB for qemu-devel@nongnu.org; Tue, 05 Jul 2016 00:57:38 -0400 Date: Tue, 5 Jul 2016 14:58:08 +1000 From: David Gibson Message-ID: <20160705045808.GG2251@voom.fritz.box> References: <1467693772-7391-1-git-send-email-bharata@linux.vnet.ibm.com> <1467693772-7391-4-git-send-email-bharata@linux.vnet.ibm.com> MIME-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="w2JjAQZceEVGylhD" Content-Disposition: inline In-Reply-To: <1467693772-7391-4-git-send-email-bharata@linux.vnet.ibm.com> Subject: Re: [Qemu-devel] [RFC PATCH v0 3/5] spapr: Implement CPUClass.get_arch_id() for PowerPC CPUs List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Bharata B Rao Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org, imammedo@redhat.com, groug@kaod.org, nikunj@linux.vnet.ibm.com, pbonzini@redhat.com --w2JjAQZceEVGylhD Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable On Tue, Jul 05, 2016 at 10:12:50AM +0530, Bharata B Rao wrote: > Signed-off-by: Bharata B Rao Reviewed-by: David Gibson Longer term we should probably change the field name to arch_id. In theory we could have something like this on a platform that didn't do device trees. > --- > target-ppc/translate_init.c | 8 ++++++++ > 1 file changed, 8 insertions(+) >=20 > diff --git a/target-ppc/translate_init.c b/target-ppc/translate_init.c > index 8f257fb..b810624 100644 > --- a/target-ppc/translate_init.c > +++ b/target-ppc/translate_init.c > @@ -10357,6 +10357,13 @@ static gchar *ppc_gdb_arch_name(CPUState *cs) > #endif > } > =20 > +static int64_t ppc_cpu_get_arch_id(CPUState *cs) > +{ > + PowerPCCPU *cpu =3D POWERPC_CPU(cs); > + > + return cpu->cpu_dt_id; > +} > + > static void ppc_cpu_class_init(ObjectClass *oc, void *data) > { > PowerPCCPUClass *pcc =3D POWERPC_CPU_CLASS(oc); > @@ -10409,6 +10416,7 @@ static void ppc_cpu_class_init(ObjectClass *oc, v= oid *data) > #ifndef CONFIG_USER_ONLY > cc->virtio_is_big_endian =3D ppc_cpu_is_big_endian; > #endif > + cc->get_arch_id =3D ppc_cpu_get_arch_id; > =20 > dc->fw_name =3D "PowerPC,UNKNOWN"; > } --=20 David Gibson | I'll have my music baroque, and my code david AT gibson.dropbear.id.au | minimalist, thank you. NOT _the_ _other_ | _way_ _around_! http://www.ozlabs.org/~dgibson --w2JjAQZceEVGylhD Content-Type: application/pgp-signature; name="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQIcBAEBAgAGBQJXez5gAAoJEGw4ysog2bOS/BcP/AtcYgJSoEWFs8Jj6kGyAMfs FODIDttmf8hJYEuNF46uSXzibAUxV6tvsODWe8hVtpvTp+hk8RMHJ13jQ4yB7Oyu ZZWGMOg8BHXNX+yi5sKS8rhJDMz1Xplwd5VbrrTVxq66MtR5HMg9uzj95Zk7BYqT 8cIac6jNK/KTZCR8Xy6t9Rr2IPXA62KHsVdL04jhuDBd75zBweUBFuv+7a8oIlUp G9sIq+cMNf8AxA3+Q59MVq2uXi8Gh0RYWwYGZjf2ep2ixP7ZGPTE38+C4lo1mMKm iA967jaTZ9400u7Y5mbq/hkJ3vjFpMlfwhgBc966bI7nDQRLTpYHoajoDHU2W2O2 NLjdy/yvmRWwI1VnWC+n9bOLJMiGouONlWpLyWWvugVGUqv8b7MSdYw5xAqdXb4Z rRuvgXKhtKV5U7HvdQ6V6KpwfDac2Ta2jPdbZnUor4HO8F7EgcoCHK9VvB9Pv8n1 zE4jCXk+GwiFcXLPJZ3Sf02350GOo/ssEd7JlVVHbb6IQl+uzx3sgFMv/Pnas+1W AgaV/RkfQ1aNpzhpjvY+OTCpA3LB9Vt17rt58kQjbzXHhR1VvqJ9Tftt5AWpIChz l31Fezsxy7eGFlb5kkasFP4GCB5vR9i55Z/groEsIwFwXk2ukjZuN9IJiQA96HPa Li1oyeX33YRyJVZoNoyC =+J6s -----END PGP SIGNATURE----- --w2JjAQZceEVGylhD--