From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:46696) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKK1T-0003OM-SC for qemu-devel@nongnu.org; Tue, 05 Jul 2016 02:39:56 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1bKK1N-00009l-Qu for qemu-devel@nongnu.org; Tue, 05 Jul 2016 02:39:54 -0400 Received: from mx1.redhat.com ([209.132.183.28]:57299) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1bKK1N-00009f-LT for qemu-devel@nongnu.org; Tue, 05 Jul 2016 02:39:49 -0400 Date: Tue, 5 Jul 2016 14:39:41 +0800 From: Peter Xu Message-ID: <20160705063941.GA1153@pxdev.xzpeter.org> References: <1466495274-5011-1-git-send-email-peterx@redhat.com> <1466495274-5011-6-git-send-email-peterx@redhat.com> <20160704181330-mutt-send-email-mst@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Disposition: inline In-Reply-To: <20160704181330-mutt-send-email-mst@redhat.com> Subject: Re: [Qemu-devel] [PATCH v10 05/26] acpi: enable INTR for DMAR report structure List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: "Michael S. Tsirkin" Cc: qemu-devel@nongnu.org, imammedo@redhat.com, rth@twiddle.net, ehabkost@redhat.com, jasowang@redhat.com, marcel@redhat.com, pbonzini@redhat.com, jan.kiszka@web.de, rkrcmar@redhat.com, alex.williamson@redhat.com, wexu@redhat.com, davidkiarie4@gmail.com On Mon, Jul 04, 2016 at 06:14:41PM +0300, Michael S. Tsirkin wrote: > On Tue, Jun 21, 2016 at 03:47:33PM +0800, Peter Xu wrote: > > In ACPI DMA remapping report structure, enable INTR flag when specified. > > > > Signed-off-by: Peter Xu > > --- > > hw/i386/acpi-build.c | 11 ++++++++++- > > include/hw/i386/intel_iommu.h | 2 ++ > > 2 files changed, 12 insertions(+), 1 deletion(-) > > > > diff --git a/hw/i386/acpi-build.c b/hw/i386/acpi-build.c > > index 161f089..961ccd6a 100644 > > --- a/hw/i386/acpi-build.c > > +++ b/hw/i386/acpi-build.c > > @@ -57,6 +57,7 @@ > > > > #include "qapi/qmp/qint.h" > > #include "qom/qom-qobject.h" > > +#include "hw/i386/x86-iommu.h" > > > > /* These are used to size the ACPI tables for -M pc-i440fx-1.7 and > > * -M pc-i440fx-2.0. Even if the actual amount of AML generated grows > > @@ -2422,10 +2423,18 @@ build_dmar_q35(GArray *table_data, BIOSLinker *linker) > > > > AcpiTableDmar *dmar; > > AcpiDmarHardwareUnit *drhd; > > + uint8_t dmar_flags = 0; > > + X86IOMMUState *iommu = x86_iommu_get_default(); > > + > > + assert(iommu); > > + if (iommu->intr_supported) { > > + /* enable INTR for the IOMMU device */ > > + dmar_flags |= DMAR_REPORT_F_INTR; > > Please rewrite it: drop DMAR_REPORT_F_INTR macro, > and replace with literal + comment documenting > earliest spec version has it and the exact text > to look for in the spec. For "literal", do you mean this? dmar_flags |= 0x1; Could I ask why we need to drop the macro? There are two possible flags here, bit 0 is for IR, bit 1 (not used in QEMU yet) for X2APIC_OPT_OUT. Macros seem to be more clear. Did I miss anything? Regarding to the comment, maybe: "enable INTR for the IOMMU device. See VT-d spec 8.1 (any version newer than Oct. 2014)" Thanks, -- peterx