From: "Daniel P. Berrange" <berrange@redhat.com>
To: "Dr. David Alan Gilbert (git)" <dgilbert@redhat.com>
Cc: qemu-devel@nongnu.org, pbonzini@redhat.com, ehabkost@redhat.com,
marcel@redhat.com, mst@redhat.com, kraxel@redhat.com
Subject: Re: [Qemu-devel] [PATCH v2 0/6] x86: Physical address limit patches
Date: Tue, 5 Jul 2016 10:46:59 +0100 [thread overview]
Message-ID: <20160705094659.GH6553@redhat.com> (raw)
In-Reply-To: <1467659769-15900-1-git-send-email-dgilbert@redhat.com>
On Mon, Jul 04, 2016 at 08:16:03PM +0100, Dr. David Alan Gilbert (git) wrote:
> From: "Dr. David Alan Gilbert" <dgilbert@redhat.com>
>
> QEMU sets the guests physical address bits to 40; this is wrong
> on most hardware, and can be detected by the guest.
> It also stops you using really huge multi-TB VMs.
>
> Red Hat has had a patch, that Andrea wrote, downstream for a couple
> of years that reads the hosts value and uses that in the guest. That's
> correct as far as the guest sees it, and lets you create huge VMs.
>
> The downside, is that if you've got a mix of hosts, say an i7 and a Xeon,
> life gets complicated in migration; prior to 2.6 it all apparently
> worked (although a guest that looked might spot the change).
> In 2.6 Paolo started checking MSR writes and they failed when the
> incoming MTRR mask didn't fit.
>
> This series:
> a) Fixes up mtrr masks so that if you're migrating between hosts
> of different physical address size it tries to do something sensible.
>
> b) Lets you specify the guest physical address size via a CPU property, i.e.
> -cpu SandyBridge,phys-bits=36
>
> The default on old machine types is to use the existing 40 bits value.
>
> c) Lets you tell qemu to use the same setting as the host, i.e.
> -cpu SandyBridge,phys-bits=0
>
> This is the default on new machine types.
As a general rule we've tried to say that if you pick an explicit CPU
model, we're migration safe. By having the phys-bits default value
always reflect the host CPU value, it feels like we've made the explicit
CPU model choice less safe, just like -cpu host is.
IOW, if choosing a named CPU model, it feels like we should have a
corresponding fixed phys-bit value for that CPU model, even if it
has to be quiet conservative (eg default to bits=36). A phys-bits=0
value should only be used with -cpu host.
Regards,
Daniel
--
|: http://berrange.com -o- http://www.flickr.com/photos/dberrange/ :|
|: http://libvirt.org -o- http://virt-manager.org :|
|: http://autobuild.org -o- http://search.cpan.org/~danberr/ :|
|: http://entangle-photo.org -o- http://live.gnome.org/gtk-vnc :|
next prev parent reply other threads:[~2016-07-05 9:47 UTC|newest]
Thread overview: 39+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-04 19:16 [Qemu-devel] [PATCH v2 0/6] x86: Physical address limit patches Dr. David Alan Gilbert (git)
2016-07-04 19:16 ` [Qemu-devel] [PATCH v2 1/6] x86: Allow physical address bits to be set Dr. David Alan Gilbert (git)
2016-07-04 19:33 ` Eduardo Habkost
2016-07-05 13:43 ` Dr. David Alan Gilbert
2016-07-04 19:16 ` [Qemu-devel] [PATCH v2 2/6] x86: Mask mtrr mask based on CPU physical address limits Dr. David Alan Gilbert (git)
2016-07-04 20:02 ` Michael S. Tsirkin
2016-07-04 20:05 ` Eduardo Habkost
2016-07-04 22:37 ` Michael S. Tsirkin
2016-07-04 20:03 ` Eduardo Habkost
2016-07-04 19:16 ` [Qemu-devel] [PATCH v2 3/6] x86: fill high bits of mtrr mask Dr. David Alan Gilbert (git)
2016-07-04 20:03 ` Michael S. Tsirkin
2016-07-04 20:14 ` Eduardo Habkost
2016-07-04 20:21 ` Eduardo Habkost
2016-07-05 8:39 ` Dr. David Alan Gilbert
2016-07-04 19:16 ` [Qemu-devel] [PATCH v2 4/6] x86: Set physical address bits based on host Dr. David Alan Gilbert (git)
2016-07-04 20:27 ` Eduardo Habkost
2016-07-05 8:44 ` Dr. David Alan Gilbert
2016-07-04 19:16 ` [Qemu-devel] [PATCH v2 5/6] x86: fix up 32 bit phys_bits case Dr. David Alan Gilbert (git)
2016-07-05 9:42 ` Daniel P. Berrange
2016-07-05 11:29 ` Dr. David Alan Gilbert
2016-07-05 11:55 ` Daniel P. Berrange
2016-07-05 19:05 ` Dr. David Alan Gilbert
2016-07-04 19:16 ` [Qemu-devel] [PATCH v2 6/6] x86: Add sanity checks on phys_bits Dr. David Alan Gilbert (git)
2016-07-04 20:46 ` Eduardo Habkost
2016-07-05 10:40 ` Dr. David Alan Gilbert
2016-07-04 20:23 ` [Qemu-devel] [PATCH v2 0/6] x86: Physical address limit patches Michael S. Tsirkin
2016-07-05 9:33 ` Dr. David Alan Gilbert
2016-07-05 10:06 ` Michael S. Tsirkin
2016-07-05 10:13 ` Dr. David Alan Gilbert
2016-07-05 10:41 ` Michael S. Tsirkin
2016-07-05 10:59 ` Paolo Bonzini
2016-07-05 11:09 ` Michael S. Tsirkin
2016-07-05 11:46 ` Paolo Bonzini
2016-07-05 12:39 ` Michael S. Tsirkin
2016-07-05 12:41 ` Dr. David Alan Gilbert
2016-07-05 13:38 ` Michael S. Tsirkin
2016-07-05 9:46 ` Daniel P. Berrange [this message]
2016-07-05 9:49 ` Dr. David Alan Gilbert
2016-07-05 12:38 ` Eduardo Habkost
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705094659.GH6553@redhat.com \
--to=berrange@redhat.com \
--cc=dgilbert@redhat.com \
--cc=ehabkost@redhat.com \
--cc=kraxel@redhat.com \
--cc=marcel@redhat.com \
--cc=mst@redhat.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.