All of lore.kernel.org
 help / color / mirror / Atom feed
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
To: "Tan, Jianfeng" <jianfeng.tan@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
	"Xie, Huawei" <huawei.xie@intel.com>,
	"Mcnamara, John" <john.mcnamara@intel.com>,
	"Jastrzebski, MichalX K" <michalx.k.jastrzebski@intel.com>
Subject: Re: [PATCH 1/4] net/virtio-user: fix return value not checked
Date: Tue, 5 Jul 2016 19:31:19 +0800	[thread overview]
Message-ID: <20160705113119.GH26521@yliu-dev.sh.intel.com> (raw)
In-Reply-To: <ED26CBA2FAD1BF48A8719AEF02201E3610614EA1@SHSMSX103.ccr.corp.intel.com>

On Tue, Jul 05, 2016 at 10:14:28AM +0000, Tan, Jianfeng wrote:
> > On Wed, Jun 29, 2016 at 09:05:33AM +0000, Jianfeng Tan wrote:
> > > -	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1)
> > > -		rte_kvargs_process(kvlist, VIRTIO_USER_ARG_CQ_NUM,
> > > -				   &get_integer_arg, &cq);
> > > +	if (rte_kvargs_count(kvlist, VIRTIO_USER_ARG_CQ_NUM) == 1) {
> > > +		ret = rte_kvargs_process(kvlist,
> > VIRTIO_USER_ARG_CQ_NUM,
> > > +					 &get_integer_arg, &cq);
> > > +		if (ret < 0) {
> > > +			PMD_INIT_LOG(ERR, "error to parse %s",
> > > +				     VIRTIO_USER_ARG_CQ_NUM);
> > > +			goto end;
> > > +		}
> > > +	}
> > >  	else if (queues > 1)
> > 
> > Above 2 lines should be in one line. Fixed, and series applied to
> > dpdk-next-virtio.
> 
> Thanks.
> 
> But there's another problem in the commit log: the Coverity defect ID should be "127477, 127478"  instead of "127344, 127478". Can you please help make it right?

Done.

	--yliu

  reply	other threads:[~2016-07-05 11:29 UTC|newest]

Thread overview: 8+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-06-29  9:05 [PATCH 0/4] net/virtio-user: fix coverity issues Jianfeng Tan
2016-06-29  9:05 ` [PATCH 1/4] net/virtio-user: fix return value not checked Jianfeng Tan
2016-07-01  2:15   ` Yuanhan Liu
2016-07-05 10:14     ` Tan, Jianfeng
2016-07-05 11:31       ` Yuanhan Liu [this message]
2016-06-29  9:05 ` [PATCH 2/4] net/virtio-user: fix string overflow Jianfeng Tan
2016-06-29  9:05 ` [PATCH 3/4] net/virtio-user: fix resource leaks Jianfeng Tan
2016-06-29  9:05 ` [PATCH 4/4] net/virtio-user: fix string unterminated Jianfeng Tan

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705113119.GH26521@yliu-dev.sh.intel.com \
    --to=yuanhan.liu@linux.intel.com \
    --cc=dev@dpdk.org \
    --cc=huawei.xie@intel.com \
    --cc=jianfeng.tan@intel.com \
    --cc=john.mcnamara@intel.com \
    --cc=michalx.k.jastrzebski@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.