From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from smtp.codeaurora.org ([198.145.29.96]:55561 "EHLO smtp.codeaurora.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751105AbcGEN2U (ORCPT ); Tue, 5 Jul 2016 09:28:20 -0400 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Subject: Re: mwifiex: fix unconditional error return in .add_virtual_intf callback From: Kalle Valo In-Reply-To: <1467401982-18943-1-git-send-email-javier@osg.samsung.com> To: Javier Martinez Canillas Cc: linux-kernel@vger.kernel.org, Javier Martinez Canillas , Amitkumar Karwar , netdev@vger.kernel.org, linux-wireless@vger.kernel.org, Nishant Sarmukadam Message-Id: <20160705132819.6B3C9611CF@smtp.codeaurora.org> (sfid-20160705_152842_153802_9E2C316B) Date: Tue, 5 Jul 2016 13:28:19 +0000 (UTC) Sender: linux-wireless-owner@vger.kernel.org List-ID: Javier Martinez Canillas wrote: > The commit 7311ea850079 ("mwifiex: fix AP start problem for newly added > interface") attempted to fix an issue when a new AP interface is added. > > But the patch didn't check the return value of the functions doing the > firmware calls and returned an error even if the functions didn't fail. > > This prevents the network device to be registered properly, so fix it. > > Fixes: 7311ea850079 ("mwifiex: fix AP start problem for newly added interface") > Signed-off-by: Javier Martinez Canillas > Reviewed-by: Julian Calaby Thanks, 1 patch applied to wireless-drivers-next.git: f152bdad6208 mwifiex: fix unconditional error return in .add_virtual_intf callback -- Sent by pwcli https://patchwork.kernel.org/patch/9210355/