From: Kalle Valo <kvalo@codeaurora.org>
To: Larry Finger <Larry.Finger@lwfinger.net>
Cc: devel@driverdev.osuosl.org, linux-wireless@vger.kernel.org,
Larry Finger <Larry.Finger@lwfinger.net>,
Pavel Andrianov <andrianov@ispras.ru>
Subject: Re: [1/6] rtlwifi: Remove unused parameter from rtl_ps_set_rf_state()
Date: Tue, 5 Jul 2016 14:32:10 +0000 (UTC) [thread overview]
Message-ID: <20160705143210.081C0611CF@smtp.codeaurora.org> (raw)
In-Reply-To: <1466879867-2499-2-git-send-email-Larry.Finger@lwfinger.net>
Larry Finger <Larry.Finger@lwfinger.net> wrote:
> Commit 4b9d8d67b44a ("rtlwifi: rtl8192cu: Remove unused parameter") reworked
> this routine. Those changes were later reverted by commit d3feae41a347
> ("rtlwifi: Update power-save routines for 062814 driver").
>
> There were two changes in commit 4b9d8d67b44a. The first of these removed
> a parameter from rtl_ps_set_rf_state() that was always false. This is the
> change that is restored in the current patch. A second change that reworked
> the locking is still being analyzed.
>
> In addition to removing the unused parameter, there is no need for
> rtl_ps_set_rf_state() to be exported.
>
> Reported-by: Pavel Andrianov <andrianov@ispras.ru>
> Signed-off-by: Larry Finger <Larry.Finger@lwfinger.net>
> Cc: Pavel Andrianov <andrianov@ispras.ru>
Thanks, 6 patches applied to wireless-drivers-next.git:
30462b514fb3 rtlwifi: Remove unused parameter from rtl_ps_set_rf_state()
204e2ab22e1e rtlwifi: rtl8188ee: Fix potential race condition
c3ae8ec4a264 rtlwifi: rtl8192ee: Fix potential race condition
31c2e76c77fb rtlwifi: rtl8723be: Fix potential race condition
4f29b348bdc0 rtlwifi: rtl8723ae: Fix potential race condition
300c32ca84f5 rtlwifi: rtl8821ae: Fix potential race condition
--
Sent by pwcli
https://patchwork.kernel.org/patch/9198637/
next prev parent reply other threads:[~2016-07-05 14:32 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-25 18:37 [PATCH 0/6] rtlwifi: Miscellaneous fixes and cleanups Larry Finger
2016-06-25 18:37 ` [PATCH 1/6] rtlwifi: Remove unused parameter from rtl_ps_set_rf_state() Larry Finger
2016-07-05 14:32 ` Kalle Valo [this message]
2016-06-25 18:37 ` [PATCH 2/6] rtlwifi: rtl8188ee: Fix potential race condition Larry Finger
2016-06-25 18:37 ` [PATCH 3/6] rtlwifi: rtl8192ee: " Larry Finger
2016-06-25 18:37 ` [PATCH 4/6] rtlwifi: rtl8723be: " Larry Finger
2016-06-25 18:37 ` [PATCH 5/6] rtlwifi: rtl8723ae: " Larry Finger
2016-06-25 18:37 ` [PATCH 6/6] rtlwifi: rtl8821ae: " Larry Finger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160705143210.081C0611CF@smtp.codeaurora.org \
--to=kvalo@codeaurora.org \
--cc=Larry.Finger@lwfinger.net \
--cc=andrianov@ispras.ru \
--cc=devel@driverdev.osuosl.org \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.