All of lore.kernel.org
 help / color / mirror / Atom feed
From: Tom Rini <trini@konsulko.com>
To: u-boot@lists.denx.de
Subject: [U-Boot] Wandboard: u-boot.img is getting too large
Date: Tue, 5 Jul 2016 11:17:09 -0400	[thread overview]
Message-ID: <20160705151709.GH25693@bill-the-cat> (raw)
In-Reply-To: <CAOMZO5AJSaTR-vxegf_uNTSWmm3CTKz-5vw7-3X44_As0vHGFg@mail.gmail.com>

On Tue, Jul 05, 2016 at 08:49:00AM -0300, Fabio Estevam wrote:
> Hi Alexey,
> 
> On Tue, Jul 5, 2016 at 1:54 AM, Alexey Brodkin
> <Alexey.Brodkin@synopsys.com> wrote:
> 
> > IMHO there's an obvious solution for all that - just move U-Boot's env for say
> > another 300-400k above like that:
> > ------------------------------>8---------------------------
> > diff --git a/include/configs/wandboard.h b/include/configs/wandboard.h
> > index 99f5c0c..e39583c 100644
> > --- a/include/configs/wandboard.h
> > +++ b/include/configs/wandboard.h
> > @@ -181,7 +181,7 @@
> >  #define CONFIG_ENV_SIZE                        (8 * 1024)
> >
> >  #define CONFIG_ENV_IS_IN_MMC
> > -#define CONFIG_ENV_OFFSET              (6 * 64 * 1024)
> > +#define CONFIG_ENV_OFFSET              (2 * 6 * 64 * 1024)
> >  #define CONFIG_SYS_MMC_ENV_DEV         0
> >
> >  #endif
> > ------------------------------>8---------------------------
> 
> Yes, please send this as a formal patch.
> 
> I fixed the same issue recently on mx6sabresd.
> 
> See commit 8fb9eea5653796 ("mx6sabre_common: Fix U-Boot corruption
> after 'saveenv'")

I think this shows that we need to think about fixing this in one of the
more common mx6/7 header files as a "board can override" default.  And
maybe start thinking about moving the questions to Kconfig as well,
since tbot can make sure that the conversion is correct. :)

-- 
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: signature.asc
Type: application/pgp-signature
Size: 819 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20160705/ef065dcb/attachment.sig>

      reply	other threads:[~2016-07-05 15:17 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-05  4:54 [U-Boot] Wandboard: u-boot.img is getting too large Alexey Brodkin
2016-07-05  6:11 ` Wolfgang Denk
2016-07-05  6:19   ` Alexey Brodkin
2016-07-05 11:49 ` Fabio Estevam
2016-07-05 15:17   ` Tom Rini [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160705151709.GH25693@bill-the-cat \
    --to=trini@konsulko.com \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.