From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755353AbcGEPfq (ORCPT ); Tue, 5 Jul 2016 11:35:46 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:16579 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752524AbcGEPfo (ORCPT ); Tue, 5 Jul 2016 11:35:44 -0400 Date: Tue, 5 Jul 2016 11:34:12 -0400 From: Konrad Rzeszutek Wilk To: Jan Beulich , Joao Martins Cc: Andrew Cooper , Vitaly Kuznetsov , Juergen Gross , Stefano Stabellini , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , David Vrabel , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Boris Ostrovsky , Thomas Gleixner Subject: Re: [Xen-devel] [PATCH linux 2/8] xen: introduce xen_vcpu_id mapping Message-ID: <20160705153412.GD6428@char.us.oracle.com> References: <1467132449-1030-1-git-send-email-vkuznets@redhat.com> <1467132449-1030-3-git-send-email-vkuznets@redhat.com> <87shvwur5p.fsf@vitty.brq.redhat.com> <689743e6-0b0e-9935-58e1-2dfa257c7bf8@citrix.com> <87oa6kupko.fsf@vitty.brq.redhat.com> <87k2h8ufw0.fsf@vitty.brq.redhat.com> <5040c916-279f-c350-383a-583ec1700686@citrix.com> <5774FE1302000078000F9FED@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <5774FE1302000078000F9FED@prv-mh.provo.novell.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jun 30, 2016 at 03:10:11AM -0600, Jan Beulich wrote: > >>> On 29.06.16 at 18:27, wrote: > > On 29/06/16 17:19, Vitaly Kuznetsov wrote: > >> To explain better what I'm trying to suggest here please take a look at > >> the attached patch. If we can guarantee long term that ACPI id always > >> equals to Xen's idea of vCPU id this is probably the easiest way. > >> > >> -- Vitaly > > > > The code in hvmloader which sets up the MADT does: > > > > for ( i = 0; i < hvm_info->nr_vcpus; i++ ) > > { > > memset(lapic, 0, sizeof(*lapic)); > > lapic->type = ACPI_PROCESSOR_LOCAL_APIC; > > lapic->length = sizeof(*lapic); > > /* Processor ID must match processor-object IDs in the DSDT. */ > > lapic->acpi_processor_id = i; > > lapic->apic_id = LAPIC_ID(i); > > lapic->flags = (test_bit(i, hvm_info->vcpu_online) > > ? ACPI_LOCAL_APIC_ENABLED : 0); > > lapic++; > > } > > > > So relying on the acpi_processor_id does look to be reliable. That code > > hasn't changed since 2007, and that was only a bugfix. I would go so > > far as to say it is reasonable for us to guarantee this in the guest ABI. > > In fact - is there any other way a guest could learn the vCPU IDs > of its CPUs in a reliable way? I don't think so, and hence this de > facto already is part of the ABI; we should of course spell it out > somewhere. CCing Joao. Joao worked (and I think he posted an RFC patchset?) where this is changed so that the true hardware topology (core, thread, etc) is exposed. This is obviously for cases where you want pinning. I would hesistate to spell this out as an ABI.. P.S. Which reminds me, Joao, you OK posting the patchset? > > Jan > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > http://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH linux 2/8] xen: introduce xen_vcpu_id mapping Date: Tue, 5 Jul 2016 11:34:12 -0400 Message-ID: <20160705153412.GD6428@char.us.oracle.com> References: <1467132449-1030-1-git-send-email-vkuznets@redhat.com> <1467132449-1030-3-git-send-email-vkuznets@redhat.com> <87shvwur5p.fsf@vitty.brq.redhat.com> <689743e6-0b0e-9935-58e1-2dfa257c7bf8@citrix.com> <87oa6kupko.fsf@vitty.brq.redhat.com> <87k2h8ufw0.fsf@vitty.brq.redhat.com> <5040c916-279f-c350-383a-583ec1700686@citrix.com> <5774FE1302000078000F9FED@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta5.messagelabs.com ([195.245.231.135]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bKSMz-0004Fe-3Y for xen-devel@lists.xenproject.org; Tue, 05 Jul 2016 15:34:41 +0000 Content-Disposition: inline In-Reply-To: <5774FE1302000078000F9FED@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich , Joao Martins Cc: Juergen Gross , Stefano Stabellini , Andrew Cooper , x86@kernel.org, linux-kernel@vger.kernel.org, Ingo Molnar , Thomas Gleixner , David Vrabel , "H. Peter Anvin" , xen-devel@lists.xenproject.org, Vitaly Kuznetsov , Boris Ostrovsky List-Id: xen-devel@lists.xenproject.org T24gVGh1LCBKdW4gMzAsIDIwMTYgYXQgMDM6MTA6MTFBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gPj4+IE9uIDI5LjA2LjE2IGF0IDE4OjI3LCA8YW5kcmV3LmNvb3BlcjNAY2l0cml4LmNv bT4gd3JvdGU6Cj4gPiBPbiAyOS8wNi8xNiAxNzoxOSwgVml0YWx5IEt1em5ldHNvdiB3cm90ZToK PiA+PiBUbyBleHBsYWluIGJldHRlciB3aGF0IEknbSB0cnlpbmcgdG8gc3VnZ2VzdCBoZXJlIHBs ZWFzZSB0YWtlIGEgbG9vayBhdAo+ID4+IHRoZSBhdHRhY2hlZCBwYXRjaC4gSWYgd2UgY2FuIGd1 YXJhbnRlZSBsb25nIHRlcm0gdGhhdCBBQ1BJIGlkIGFsd2F5cwo+ID4+IGVxdWFscyB0byBYZW4n cyBpZGVhIG9mIHZDUFUgaWQgdGhpcyBpcyBwcm9iYWJseSB0aGUgZWFzaWVzdCB3YXkuCj4gPj4K PiA+PiAtLSBWaXRhbHkKPiA+IAo+ID4gVGhlIGNvZGUgaW4gaHZtbG9hZGVyIHdoaWNoIHNldHMg dXAgdGhlIE1BRFQgZG9lczoKPiA+IAo+ID4gICAgIGZvciAoIGkgPSAwOyBpIDwgaHZtX2luZm8t Pm5yX3ZjcHVzOyBpKysgKQo+ID4gICAgIHsKPiA+ICAgICAgICAgbWVtc2V0KGxhcGljLCAwLCBz aXplb2YoKmxhcGljKSk7Cj4gPiAgICAgICAgIGxhcGljLT50eXBlICAgID0gQUNQSV9QUk9DRVNT T1JfTE9DQUxfQVBJQzsKPiA+ICAgICAgICAgbGFwaWMtPmxlbmd0aCAgPSBzaXplb2YoKmxhcGlj KTsKPiA+ICAgICAgICAgLyogUHJvY2Vzc29yIElEIG11c3QgbWF0Y2ggcHJvY2Vzc29yLW9iamVj dCBJRHMgaW4gdGhlIERTRFQuICovCj4gPiAgICAgICAgIGxhcGljLT5hY3BpX3Byb2Nlc3Nvcl9p ZCA9IGk7Cj4gPiAgICAgICAgIGxhcGljLT5hcGljX2lkID0gTEFQSUNfSUQoaSk7Cj4gPiAgICAg ICAgIGxhcGljLT5mbGFncyA9ICh0ZXN0X2JpdChpLCBodm1faW5mby0+dmNwdV9vbmxpbmUpCj4g PiAgICAgICAgICAgICAgICAgICAgICAgICA/IEFDUElfTE9DQUxfQVBJQ19FTkFCTEVEIDogMCk7 Cj4gPiAgICAgICAgIGxhcGljKys7Cj4gPiAgICAgfQo+ID4gCj4gPiBTbyByZWx5aW5nIG9uIHRo ZSBhY3BpX3Byb2Nlc3Nvcl9pZCBkb2VzIGxvb2sgdG8gYmUgcmVsaWFibGUuICBUaGF0IGNvZGUK PiA+IGhhc24ndCBjaGFuZ2VkIHNpbmNlIDIwMDcsIGFuZCB0aGF0IHdhcyBvbmx5IGEgYnVnZml4 LiAgSSB3b3VsZCBnbyBzbwo+ID4gZmFyIGFzIHRvIHNheSBpdCBpcyByZWFzb25hYmxlIGZvciB1 cyB0byBndWFyYW50ZWUgdGhpcyBpbiB0aGUgZ3Vlc3QgQUJJLgo+IAo+IEluIGZhY3QgLSBpcyB0 aGVyZSBhbnkgb3RoZXIgd2F5IGEgZ3Vlc3QgY291bGQgbGVhcm4gdGhlIHZDUFUgSURzCj4gb2Yg aXRzIENQVXMgaW4gYSByZWxpYWJsZSB3YXk/IEkgZG9uJ3QgdGhpbmsgc28sIGFuZCBoZW5jZSB0 aGlzIGRlCj4gZmFjdG8gYWxyZWFkeSBpcyBwYXJ0IG9mIHRoZSBBQkk7IHdlIHNob3VsZCBvZiBj b3Vyc2Ugc3BlbGwgaXQgb3V0Cj4gc29tZXdoZXJlLgoKQ0NpbmcgSm9hby4KCkpvYW8gd29ya2Vk IChhbmQgSSB0aGluayBoZSBwb3N0ZWQgYW4gUkZDIHBhdGNoc2V0Pykgd2hlcmUgdGhpcyBpcyBj aGFuZ2VkIHNvCnRoYXQgdGhlIHRydWUgaGFyZHdhcmUgdG9wb2xvZ3kgKGNvcmUsIHRocmVhZCwg ZXRjKSBpcyBleHBvc2VkLiBUaGlzIGlzIG9idmlvdXNseQpmb3IgY2FzZXMgd2hlcmUgeW91IHdh bnQgcGlubmluZy4KCkkgd291bGQgaGVzaXN0YXRlIHRvIHNwZWxsIHRoaXMgb3V0IGFzIGFuIEFC SS4uCgpQLlMuCldoaWNoIHJlbWluZHMgbWUsIEpvYW8sIHlvdSBPSyBwb3N0aW5nIHRoZSBwYXRj aHNldD8KPiAKPiBKYW4KPiAKPiAKPiBfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fXwo+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QKPiBYZW4tZGV2ZWxAbGlzdHMu eGVuLm9yZwo+IGh0dHA6Ly9saXN0cy54ZW4ub3JnL3hlbi1kZXZlbAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApY ZW4tZGV2ZWxAbGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==