From mboxrd@z Thu Jan  1 00:00:00 1970
From: =?iso-8859-1?Q?N=E9lio?= Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH 3/3] scripts: check headline of drivers
	commits
Date: Wed, 6 Jul 2016 13:59:27 +0200
Message-ID: <20160706115927.GE14792@autoinstall.dev.6wind.com>
References: <1467801530-20800-1-git-send-email-thomas.monjalon@6wind.com>
 <1467801530-20800-4-git-send-email-thomas.monjalon@6wind.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=iso-8859-1
Content-Transfer-Encoding: quoted-printable
Cc: dev@dpdk.org
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f49.google.com (mail-wm0-f49.google.com [74.125.82.49])
 by dpdk.org (Postfix) with ESMTP id ED8D26CC5
 for <dev@dpdk.org>; Wed,  6 Jul 2016 13:59:29 +0200 (CEST)
Received: by mail-wm0-f49.google.com with SMTP id a66so189605336wme.0
 for <dev@dpdk.org>; Wed, 06 Jul 2016 04:59:29 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <1467801530-20800-4-git-send-email-thomas.monjalon@6wind.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Thomas,

On Wed, Jul 06, 2016 at 12:38:50PM +0200, Thomas Monjalon wrote:
> From: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
>=20
> A driver patch under net should start with "net/<driver name>" or if
> a patch touch multiple drivers, it should only start with "net:".
> The same apply for crypto.
> A patch touching all drivers (net + crypto) should start with "drivers:=
".
>=20
> Longer prefixes like "net/mlx:" (for mlx4/mlx5) or "net/e1000/base:" ar=
e
> handled by not checking the colon.
>=20
> Signed-off-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
> ---
>  scripts/check-git-log.sh | 17 +++++++++++++++++
>  1 file changed, 17 insertions(+)
>=20
> diff --git a/scripts/check-git-log.sh b/scripts/check-git-log.sh
> index 833aa39..3f3cf19 100755
> --- a/scripts/check-git-log.sh
> +++ b/scripts/check-git-log.sh
> @@ -70,6 +70,23 @@ bad=3D$(echo "$headlines" | grep --color=3Dalways \
>  	| sed 's,^,\t,')
>  [ -z "$bad" ] || printf "Wrong headline format:\n$bad\n"
> =20
> +# check headline prefix when touching only drivers/, e.g. net/<driver =
name>
> +bad=3D$(for commit in $commits ; do
> +	headline=3D$(git log --format=3D'%s' -1 $commit)
> +	files=3D$(git diff-tree --no-commit-id --name-only -r $commit)
> +	[ -z "$(echo "$files" | grep -v '^drivers/')" ] || continue
> +	driversgrp=3D$(echo "$files" | cut -d "/" -f 2 | sort -u)
> +	drivers=3D$(echo "$files" | cut -d "/" -f 2,3 | sort -u)
> +	if [ $(echo "$driversgrp" | wc -l) -gt 1 ] ; then
> +		bad=3D$(echo "$headline" | grep -v '^drivers:')

I think you forgot the '$' for drivers in the line just above.

> +	elif [ $(echo "$drivers" | wc -l) -gt 1 ] ; then
> +		bad=3D$(echo "$headline" | grep -v "^$driversgrp")
> +	else
> +		bad=3D$(echo "$headline" | grep -v "^$drivers")
> +	fi
> +done | sed 's,^,\t,')
> +[ -z "$bad" ] || printf "Wrong headline prefix:\n$bad\n"
> +
>  # check headline label for common typos
>  bad=3D$(echo "$headlines" | grep --color=3Dalways \
>  	-e '^example[:/]' \
> --=20
> 2.7.0

Otherwise it seems good.

Regards,

--=20
N=E9lio Laranjeiro
6WIND