From: "J. Bruce Fields" <bfields@fieldses.org>
To: Benjamin Coddington <bcodding@redhat.com>
Cc: Christoph Hellwig <hch@lst.de>, xfs@oss.sgi.com
Subject: Re: [PATCH] nfsd: allow SCSI layout support without Block layout
Date: Wed, 6 Jul 2016 08:43:26 -0400 [thread overview]
Message-ID: <20160706124326.GA18856@fieldses.org> (raw)
In-Reply-To: <73B22D64-6A0B-4B8B-8A4D-6AA7AC26F30D@redhat.com>
On Wed, Jul 06, 2016 at 05:58:09AM -0400, Benjamin Coddington wrote:
> On 6 Jul 2016, at 5:19, Dave Chinner wrote:
>
> >On Tue, Jul 05, 2016 at 09:48:47PM -0400, Benjamin Coddington wrote:
> >>We shouldn't have to configure both NFSD_BLOCKLAYOUT and
> >>NFSD_SCSILAYOUT if
> >>all we want are SCSI layouts on the server, so define the xfs export
> >>operations for either configuration.
> >>
> >>Signed-off-by: Benjamin Coddington <bcodding@redhat.com>
> >
> >I don't really like exploding config option dependencies into
> >subsystems that aren't actually related to the config options.
> >It's confusing enough laready that we've got XFS code dependent on
> >PNFSD config options without adding more to it. Instead, I'd
> >suggest this should be resolved in the kconfig files. i.e. make
> >CONFIG_NFSD_SCSILAYOUT=y select CONFIG_NFSD_BLOCKLAYOUT to resolve
> >the config dependency at config time.
>
> But the point is to leave CONFIG_NFSD_BLOCKLAYOUT undefined
> otherwise knfsd
> will advertise block layouts to clients -- which we don't want.
>
> Would a third define specific for xfs_export_operations that gets
> set in kconfig files work for you? Something like XFS_PNFS_EXPORT_OPS.
That makes sense to me....
--b.
_______________________________________________
xfs mailing list
xfs@oss.sgi.com
http://oss.sgi.com/mailman/listinfo/xfs
next prev parent reply other threads:[~2016-07-06 12:43 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 10:14 [PATCH] nfsd: allow SCSI layout support without Block layout Benjamin Coddington
2016-07-06 1:48 ` Benjamin Coddington
2016-07-06 2:20 ` Christoph Hellwig
2016-07-06 9:19 ` Dave Chinner
2016-07-06 9:58 ` Benjamin Coddington
2016-07-06 12:43 ` J. Bruce Fields [this message]
2016-07-06 22:16 ` Dave Chinner
2016-07-06 22:41 ` J. Bruce Fields
2016-07-07 9:29 ` Benjamin Coddington
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706124326.GA18856@fieldses.org \
--to=bfields@fieldses.org \
--cc=bcodding@redhat.com \
--cc=hch@lst.de \
--cc=xfs@oss.sgi.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.