From: Paul Gortmaker <paul.gortmaker@windriver.com>
To: Linus Walleij <linus.walleij@linaro.org>
Cc: Fabio Estevam <festevam@gmail.com>, Arnd Bergmann <arnd@arndb.de>,
"linux-gpio@vger.kernel.org" <linux-gpio@vger.kernel.org>
Subject: Re: [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro
Date: Wed, 6 Jul 2016 10:38:18 -0400 [thread overview]
Message-ID: <20160706143818.GG26134@windriver.com> (raw)
In-Reply-To: <CACRpkdapf3uLXU9gWfVc_DpHVPVbiDozEvbpaRxOu8G9tLGiQg@mail.gmail.com>
[Re: [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro] On 06/07/2016 (Wed 15:42) Linus Walleij wrote:
> On Wed, Jul 6, 2016 at 3:25 PM, Fabio Estevam <festevam@gmail.com> wrote:
>
> > Commit e2756baa4217 ("pinctrl: imx21: make it explicitly non-modular")
> > missed the removal of the MODULE_DEVICE_TABLE() macro causing the
> > following build error:
> >
> > drivers/pinctrl/freescale/pinctrl-imx21.c:328:1: error: data definition has no type or storage class [-Werror]
> > MODULE_DEVICE_TABLE(of, imx21_pinctrl_of_match);
> >
> > ,so remove the macro to fix this problem.
> >
> > Reported-by: Arnd Bergmann <arnd@arndb.de>
> > Signed-off-by: Fabio Estevam <festevam@gmail.com>
>
> Patch applied with Arnd's ACK.
Thanks and sorry this one snuck through. I'm going to add walking all
the various defconfigs to my build coverage akin to what linux-next does
overnight. It seems the allmodconfig builds didn't hit this file...
Paul.
--
>
> Yours,
> Linus Walleij
next prev parent reply other threads:[~2016-07-06 14:38 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 13:25 [PATCH] pinctrl: imx21: Remove the MODULE_DEVICE_TABLE() macro Fabio Estevam
2016-07-06 13:42 ` Linus Walleij
2016-07-06 14:38 ` Paul Gortmaker [this message]
2016-07-06 14:52 ` Linus Walleij
2016-07-06 13:43 ` Arnd Bergmann
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706143818.GG26134@windriver.com \
--to=paul.gortmaker@windriver.com \
--cc=arnd@arndb.de \
--cc=festevam@gmail.com \
--cc=linus.walleij@linaro.org \
--cc=linux-gpio@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.