From: Bharata B Rao <bharata@linux.vnet.ibm.com>
To: Greg Kurz <groug@kaod.org>
Cc: qemu-devel@nongnu.org, qemu-ppc@nongnu.org,
david@gibson.dropbear.id.au, imammedo@redhat.com,
nikunj@linux.vnet.ibm.com, pbonzini@redhat.com
Subject: Re: [Qemu-devel] [RFC PATCH v1 3/5] spapr: Implement CPUClass::get_migration_id() for PowerPC CPUs
Date: Wed, 6 Jul 2016 22:23:34 +0530 [thread overview]
Message-ID: <20160706165333.GJ25522@in.ibm.com> (raw)
In-Reply-To: <20160706163528.25382183@bahia.lan>
On Wed, Jul 06, 2016 at 04:35:28PM +0200, Greg Kurz wrote:
> On Wed, 6 Jul 2016 14:29:19 +0530
> Bharata B Rao <bharata@linux.vnet.ibm.com> wrote:
> > cpu_index is used as migration_id by default. For machine type versions
> > that set use-migration-id property, cpu_dt_it is returned.
> >
>
> It looks wrong to hijack cpu_dt_id to fix migration.
>
> For pseries-2.7, you need to pass the sum of the index of the core in
> spapr->cores and the index of the thread in sc->threads.
>
> All other machines just need to pass the index of the cpu in their
> respective arrays, which happens to be equal to cs->cpu_index.
Yes, that is indeed good and simplifies things. Thanks for noting this.
Regards,
Bharata.
next prev parent reply other threads:[~2016-07-06 16:53 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 8:59 [Qemu-devel] [RFC PATCH v1 0/5] sPAPR: Fix migration when CPUs are removed in random order Bharata B Rao
2016-07-06 8:59 ` [Qemu-devel] [RFC PATCH v1 1/5] cpu, target-ppc: Move cpu_vmstate_[un]register calls to cpu_common_[un]realize Bharata B Rao
2016-07-06 10:57 ` Igor Mammedov
2016-07-06 14:16 ` Bharata B Rao
2016-07-06 14:44 ` Igor Mammedov
2016-07-06 16:52 ` Bharata B Rao
2016-07-07 0:47 ` David Gibson
2016-07-06 8:59 ` [Qemu-devel] [RFC PATCH v1 2/5] cpu: Introduce CPUState::migration_id Bharata B Rao
2016-07-06 11:34 ` Igor Mammedov
2016-07-06 14:18 ` Bharata B Rao
2016-07-06 14:47 ` Igor Mammedov
2016-07-07 0:53 ` David Gibson
2016-07-06 8:59 ` [Qemu-devel] [RFC PATCH v1 3/5] spapr: Implement CPUClass::get_migration_id() for PowerPC CPUs Bharata B Rao
2016-07-06 12:01 ` Igor Mammedov
2016-07-06 14:21 ` Bharata B Rao
2016-07-06 14:37 ` Greg Kurz
2016-07-07 0:57 ` David Gibson
2016-07-07 12:32 ` Greg Kurz
2016-07-07 0:55 ` David Gibson
2016-07-06 14:35 ` Greg Kurz
2016-07-06 16:53 ` Bharata B Rao [this message]
2016-07-07 1:00 ` David Gibson
2016-07-07 13:43 ` [Qemu-devel] [Qemu-ppc] " Mark Cave-Ayland
2016-07-06 8:59 ` [Qemu-devel] [RFC PATCH v1 4/5] xics: Use migration_id instead of cpu_index in XICS code Bharata B Rao
2016-07-06 9:08 ` Nikunj A Dadhania
2016-07-06 8:59 ` [Qemu-devel] [RFC PATCH v1 5/5] cpu, spapr: Use migration_id from pseries-2.7 onwards Bharata B Rao
2016-07-06 11:44 ` Igor Mammedov
2016-07-06 11:45 ` Igor Mammedov
2016-07-06 14:24 ` Bharata B Rao
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706165333.GJ25522@in.ibm.com \
--to=bharata@linux.vnet.ibm.com \
--cc=david@gibson.dropbear.id.au \
--cc=groug@kaod.org \
--cc=imammedo@redhat.com \
--cc=nikunj@linux.vnet.ibm.com \
--cc=pbonzini@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=qemu-ppc@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.