From: Stephen Hemminger <stephen@networkplumber.org>
To: Juerg Haefliger <juerg.haefliger@hpe.com>
Cc: netdev@vger.kernel.org, jeffrey.t.kirsher@intel.com,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH] net/ixgbe: Allow resetting VF admin mac to zero
Date: Wed, 6 Jul 2016 20:57:21 -0700 [thread overview]
Message-ID: <20160706205721.15eae36c@xeon-e3> (raw)
In-Reply-To: <1467364778-27198-1-git-send-email-juerg.haefliger@hpe.com>
On Fri, 1 Jul 2016 11:19:38 +0200
Juerg Haefliger <juerg.haefliger@hpe.com> wrote:
> The VF administrative mac addresses (stored in the PF driver) are
> initialized to zero when the PF driver starts up.
>
> These addresses may be modified in the PF driver through ndo calls
> initiated by iproute2 or libvirt.
>
> While we allow the PF/host to change the VF admin mac address from zero
> to a valid unicast mac, we do not allow restoring the VF admin mac to
> zero. We currently only allow changing this mac to a different unicast mac.
>
> This leads to problems when libvirt scripts are used to deal with
> VF mac addresses, and libvirt attempts to revoke the mac so this
> host will not use it anymore.
>
> Fix this by allowing resetting a VF administrative MAC back to zero.
>
> Implementation and commit message shamelessly stolen from:
> commit 6e5224224faa ("net/mlx4_core: Allow resetting VF admin mac to zero")
>
> Signed-off-by: Juerg Haefliger <juerg.haefliger@hpe.com>
Since set mac is allowed any time even when device is up, you must
prevent a a device that is in UP state from having all zero MAC address.
next prev parent reply other threads:[~2016-07-07 3:57 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 9:19 [PATCH] net/ixgbe: Allow resetting VF admin mac to zero Juerg Haefliger
2016-07-07 3:57 ` Stephen Hemminger [this message]
2016-07-07 15:38 ` Alexander Duyck
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160706205721.15eae36c@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=jeffrey.t.kirsher@intel.com \
--cc=juerg.haefliger@hpe.com \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.