From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755986AbcGGBCj (ORCPT ); Wed, 6 Jul 2016 21:02:39 -0400 Received: from mail.linuxfoundation.org ([140.211.169.12]:49574 "EHLO mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752110AbcGGBCi (ORCPT ); Wed, 6 Jul 2016 21:02:38 -0400 Date: Wed, 6 Jul 2016 18:02:48 -0700 From: Greg KH To: Joseph Salisbury Cc: hdegoede@redhat.com, adrienverge@gmail.com, yaowen@google.com, vpalatin@chromium.org, stern@rowland.harvard.edu, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org, stable@vger.kernel.org Subject: Re: [PATCH 1/1][V2] usb: quirks: Add no-lpm quirk for Elan Message-ID: <20160707010248.GA20126@kroah.com> References: <55d9aba2e03fe625810ab01eb9d883ed81a3f13c.1467851482.git.joseph.salisbury@canonical.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <55d9aba2e03fe625810ab01eb9d883ed81a3f13c.1467851482.git.joseph.salisbury@canonical.com> User-Agent: Mutt/1.6.1 (2016-04-27) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Jul 06, 2016 at 08:58:14PM -0400, Joseph Salisbury wrote: > BugLink: http://bugs.launchpad.net/bugs/1498667 > > As reported in BugLink, this device has an issue with Linux Power > Management so adding a quirk. This quirk was reccomended by Alan Stern: > > http://lkml.iu.edu/hypermail/linux/kernel/1606.2/05590.html > > Signed-off-by: Joseph Salisbury > Cc: stable > --- > drivers/usb/core/quirks.c | 5 ++++- > 1 file changed, 4 insertions(+), 1 deletion(-) > > diff --git a/drivers/usb/core/quirks.c b/drivers/usb/core/quirks.c > index 944a6dc..f028cc5 100644 > --- a/drivers/usb/core/quirks.c > +++ b/drivers/usb/core/quirks.c > @@ -127,10 +127,13 @@ static const struct usb_device_id usb_quirk_list[] = { > > { USB_DEVICE(0x04f3, 0x016f), .driver_info = > USB_QUIRK_DEVICE_QUALIFIER }, > + > + { USB_DEVICE(0x04f3, 0x0381), .driver_info = > + USB_QUIRK_NO_LPM }, > > { USB_DEVICE(0x04f3, 0x21b8), .driver_info = > USB_QUIRK_DEVICE_QUALIFIER }, > - > + This is odd, why remove and add a blank line for no reason?