From: Mika Westerberg <mika.westerberg@linux.intel.com>
To: Octavian Purdila <octavian.purdila@intel.com>
Cc: "Rafael J . Wysocki" <rjw@rjwysocki.net>,
Len Brown <lenb@kernel.org>,
Matt Fleming <matt@codeblueprint.co.uk>,
Mark Brown <broonie@kernel.org>, Wolfram Sang <wsa@the-dreams.de>,
Joel Becker <jlbec@evilplan.org>,
linux-acpi@vger.kernel.org, linux-efi@vger.kernel.org,
linux-i2c@vger.kernel.org, linux-spi@vger.kernel.org,
linux-kernel@vger.kernel.org, irina.tirdea@intel.com,
leonard.crestez@intel.com
Subject: Re: [PATCH v5 7/8] acpi: add support for configfs
Date: Thu, 7 Jul 2016 12:39:35 +0300 [thread overview]
Message-ID: <20160707093935.GP23527@lahna.fi.intel.com> (raw)
In-Reply-To: <1467404352-27101-8-git-send-email-octavian.purdila@intel.com>
On Fri, Jul 01, 2016 at 11:19:11PM +0300, Octavian Purdila wrote:
> Register the ACPI subsystem with configfs.
>
> Signed-off-by: Octavian Purdila <octavian.purdila@intel.com>
Couple of nitpicks below but regardless of those,
Reviewed-by: Mika Westerberg <mika.westerberg@linux.intel.com>
> ---
> Documentation/ABI/testing/configfs-acpi | 7 +++++
> MAINTAINERS | 1 +
> drivers/acpi/Kconfig | 9 ++++++
> drivers/acpi/Makefile | 1 +
> drivers/acpi/configfs.c | 53 +++++++++++++++++++++++++++++++++
> 5 files changed, 71 insertions(+)
> create mode 100644 Documentation/ABI/testing/configfs-acpi
> create mode 100644 drivers/acpi/configfs.c
>
> diff --git a/Documentation/ABI/testing/configfs-acpi b/Documentation/ABI/testing/configfs-acpi
> new file mode 100644
> index 0000000..17b19dc
> --- /dev/null
> +++ b/Documentation/ABI/testing/configfs-acpi
> @@ -0,0 +1,7 @@
> +What: /config/acpi
> +Date: July 2016
> +KernelVersion: 4.8
> +Contact: linux-acpi@vger.kernel.org
> +Description:
> + This represents the ACPI subsystem entry point directory. It
> + contains sub-groups corresponding to ACPI configurable options.
> diff --git a/MAINTAINERS b/MAINTAINERS
> index 16700e4..9c5365f 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -288,6 +288,7 @@ F: include/linux/acpi.h
> F: include/acpi/
> F: Documentation/acpi/
> F: Documentation/ABI/testing/sysfs-bus-acpi
> +F: Documentation/ABI/testing/configfs-acpi
> F: drivers/pci/*acpi*
> F: drivers/pci/*/*acpi*
> F: drivers/pci/*/*/*acpi*
> diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
> index b7e2e77..a039433 100644
> --- a/drivers/acpi/Kconfig
> +++ b/drivers/acpi/Kconfig
> @@ -521,4 +521,13 @@ config XPOWER_PMIC_OPREGION
>
> endif
>
> +config ACPI_CONFIGFS
> + tristate "ACPI configfs support"
> + select CONFIGFS_FS
> + default n
We default to n so this is not needed.
> + help
> + Select this option to enable support for ACPI configuration from
> + userspace. The configurable ACPI groups will be visible under
> + /config/acpi, assuming configfs is mounted under /config.
> +
> endif # ACPI
> diff --git a/drivers/acpi/Makefile b/drivers/acpi/Makefile
> index 251ce85..1dc2173 100644
> --- a/drivers/acpi/Makefile
> +++ b/drivers/acpi/Makefile
> @@ -99,5 +99,6 @@ obj-$(CONFIG_ACPI_EXTLOG) += acpi_extlog.o
> obj-$(CONFIG_PMIC_OPREGION) += pmic/intel_pmic.o
> obj-$(CONFIG_CRC_PMIC_OPREGION) += pmic/intel_pmic_crc.o
> obj-$(CONFIG_XPOWER_PMIC_OPREGION) += pmic/intel_pmic_xpower.o
> +obj-$(CONFIG_ACPI_CONFIGFS) += configfs.o
>
> video-objs += acpi_video.o video_detect.o
> diff --git a/drivers/acpi/configfs.c b/drivers/acpi/configfs.c
> new file mode 100644
> index 0000000..44a72ff
> --- /dev/null
> +++ b/drivers/acpi/configfs.c
> @@ -0,0 +1,53 @@
> +/*
> + * ACPI configfs support
> + *
> + * Copyright (c) 2015 Intel Corporation
It is 2016 now.
next prev parent reply other threads:[~2016-07-07 9:39 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-01 20:19 [PATCH v5 0/8] ACPI overlays Octavian Purdila
2016-07-01 20:19 ` Octavian Purdila
2016-07-01 20:19 ` [PATCH v5 2/8] acpi: fix enumeration (visited) flags for bus rescans Octavian Purdila
2016-07-06 15:03 ` Mika Westerberg
2016-07-06 15:37 ` Octavian Purdila
2016-07-06 21:09 ` Rafael J. Wysocki
[not found] ` <31239967.dEXrvihxAE-sKB8Sp2ER+y1GS7QM15AGw@public.gmane.org>
2016-07-07 9:00 ` Mika Westerberg
2016-07-07 9:00 ` Mika Westerberg
2016-07-07 9:28 ` Mika Westerberg
2016-07-01 20:19 ` [PATCH v5 3/8] acpi: add support for ACPI reconfiguration notifiers Octavian Purdila
2016-07-07 9:34 ` Mika Westerberg
2016-07-01 20:19 ` [PATCH v5 4/8] i2c: add support for ACPI reconfigure notifications Octavian Purdila
2016-07-04 0:34 ` Wolfram Sang
2016-07-01 20:19 ` [PATCH v5 7/8] acpi: add support for configfs Octavian Purdila
2016-07-07 9:39 ` Mika Westerberg [this message]
2016-07-01 20:19 ` [PATCH v5 8/8] acpi: add support for loading SSDTs via configfs Octavian Purdila
2016-07-07 9:42 ` Mika Westerberg
[not found] ` <1467404352-27101-1-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-01 20:19 ` [PATCH v5 1/8] Documentation: acpi: add SSDT overlays documentation Octavian Purdila
2016-07-01 20:19 ` Octavian Purdila
[not found] ` <1467404352-27101-2-git-send-email-octavian.purdila-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
2016-07-07 9:25 ` Mika Westerberg
2016-07-07 9:25 ` Mika Westerberg
2016-07-01 20:19 ` [PATCH v5 5/8] spi: add support for ACPI reconfigure notifications Octavian Purdila
2016-07-01 20:19 ` Octavian Purdila
2016-07-03 12:10 ` Mark Brown
2016-07-01 20:19 ` [PATCH v5 6/8] efi: load SSTDs from EFI variables Octavian Purdila
2016-07-01 20:19 ` Octavian Purdila
2016-07-02 8:18 ` Geert Uytterhoeven
2016-07-04 12:00 ` Matt Fleming
2016-07-06 0:34 ` [PATCH v5 0/8] ACPI overlays Rafael J. Wysocki
2016-07-06 0:34 ` Rafael J. Wysocki
2016-07-06 6:29 ` Octavian Purdila
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160707093935.GP23527@lahna.fi.intel.com \
--to=mika.westerberg@linux.intel.com \
--cc=broonie@kernel.org \
--cc=irina.tirdea@intel.com \
--cc=jlbec@evilplan.org \
--cc=lenb@kernel.org \
--cc=leonard.crestez@intel.com \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-efi@vger.kernel.org \
--cc=linux-i2c@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-spi@vger.kernel.org \
--cc=matt@codeblueprint.co.uk \
--cc=octavian.purdila@intel.com \
--cc=rjw@rjwysocki.net \
--cc=wsa@the-dreams.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.