From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Thu, 7 Jul 2016 19:14:25 +0300 Message-ID: <20160707161425.GO4329@intel.com> References: <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <20160621154434.GY4329@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: James Bottomley Cc: intel-gfx , "Syrjala, Ville" , linux-kernel , dri-devel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gVHVlLCBKdW4gMjEsIDIwMTYgYXQgMDY6NDQ6MzRQTSArMDMwMCwgVmlsbGUgU3lyasOkbMOk IHdyb3RlOgo+IE9uIFR1ZSwgSnVuIDIxLCAyMDE2IGF0IDA5OjUzOjE1QU0gLTA0MDAsIEphbWVz IEJvdHRvbWxleSB3cm90ZToKPiA+IE9uIE1vbiwgMjAxNi0wNi0yMCBhdCAxMTowMyArMDMwMCwg SmFuaSBOaWt1bGEgd3JvdGU6Cj4gPiA+IENjOiBWaWxsZQo+ID4gPiAKPiA+ID4gT24gTW9uLCAy MCBKdW4gMjAxNiwgSmFtZXMgQm90dG9tbGV5IDwKPiA+ID4gSmFtZXMuQm90dG9tbGV5QEhhbnNl blBhcnRuZXJzaGlwLmNvbT4gd3JvdGU6Cj4gPiA+ID4gT0ssIG15IGNhbmRpZGF0ZSBiYWQgY29t bWl0IGlzIHRoaXMgb25lOgo+ID4gPiA+IAo+ID4gPiA+IGNvbW1pdCBhMDU2MjgxOTVhMGQ5ZjMx NzNkZDlhYTc2ZjQ4MmFlZjY5MmU0NmVlCj4gPiA+ID4gQXV0aG9yOiBWaWxsZSBTeXJqw6Rsw6Qg PHZpbGxlLnN5cmphbGFAbGludXguaW50ZWwuY29tPgo+ID4gPiA+IERhdGU6ICAgTW9uIEFwciAx MSAxMDoyMzo1MSAyMDE2ICswMzAwCj4gPiA+ID4gCj4gPiA+ID4gICAgIGRybS9pOTE1OiBHZXQg cGFuZWxfdHlwZSBmcm9tIE9wUmVnaW9uIHBhbmVsIGRldGFpbHMKPiA+ID4gPiAKPiA+ID4gPiBB ZnRlciBiZWluZyBtb3JlIGNhcmVmdWwgYWJvdXQgd2FpdGluZyB0byBpZGVudGlmeSBmbGlja2Vy LCB0aGlzIAo+ID4gPiA+IG9uZSBzZWVtcyB0byBiZSB0aGUgb25lIHRoZSBiaXNlY3QgZmluZHMu ICBJJ20gbm93IHJ1bm5pbmcgdjQuNy1yYzMKPiA+ID4gPiB3aXRoIHRoaXMgb25lIHJldmVydGVk IGFuZCBhbSBjdXJyZW50bHkgc2VlaW5nIG5vIGZsaWNrZXIgcHJvYmxlbXMuCj4gPiA+ID4gICBJ dCBpcywgaG93ZXZlciwgZWFybHkgZGF5cyBiZWNhdXNlIHRoZSBmbGlja2VyIGNhbiBoaWRlIGZv ciBsb25nIAo+ID4gPiA+IHBlcmlvZHMsIHNvIEkgJ2xsIHdhaXQgdW50aWwgTW9uZGF5IGV2ZW5p bmcgYW5kIGEgZmV3IHJlYm9vdHMgCj4gPiA+ID4gYmVmb3JlIGRlY2xhcmluZyB2aWN0b3J5Lgo+ ID4gPiAKPiA+ID4gSWYgdGhhdCB0dXJucyBvdXQgdG8gYmUgdGhlIGJhZCBjb21taXQsIGl0IGRv ZXNuJ3QgcmVhbGx5IHN1cnByaXNlIAo+ID4gPiBtZSwgYW5kIHRoYXQgaW4gaXRzZWxmIGlzIGRl cHJlc3NpbmcuCj4gPiAKPiA+IEFzIGZhciBhcyBJIGNhbiB0ZWxsLCBhZnRlciBydW5uaW5nIGZv ciBhIGRheSB3aXRoIHRoaXMgcmV2ZXJ0ZWQsIHRoaXMKPiA+IGlzIHRoZSBwcm9ibGVtLiAgVGhl IGZsaWNrZXIgaGFzbid0IGFwcGVhcmVkIHdpdGggaXQgcmV2ZXJ0ZWQuICBJdCdzCj4gPiBwcmV0 dHkgbm90aWNlYWJsZSB3aXRoIHRoaXMgY29tbWl0IGluY2x1ZGVkLgo+IAo+IEhtbS4gVGhlIG9u bHkgZGlmZmVyZW5jZSBJIGNhbiBzZWUgaXMgbG93IHZzLiBub3JtYWwgdnN3aW5nLiBQYW5lbCAw IGhhcwo+IGxvdywgcGFuZWwgMiBoYXMgbm9ybWFsLiBTbyBlaXRoZXIgdGhlIFZCVCBvciBvcHJl Z2lvbiBpcyB0ZWxsaW5nIHV0dGVyCj4gbGllcywgb3IgdGhlcmUncyBzb21lIG90aGVyIGJ1ZyBp biBvdXIgbG93IHZzd2luZyBzdXBwb3J0LgoKSSBkaWQgYSBxdWljayBvbmNlIG92ZXIgb2Ygb3V0 IERESSB2c3dpbmcgc3R1ZmYgYW5kIGRpZG4ndCBmaW5kIGFueXRoaW5nCnRvbyBzZXJpb3VzLiBU aGVyZSB3ZXJlIHNvbWUgYnVnbGV0cyBpbiB0aGUgaWJvb3N0IGhhbmRsaW5nLCBidXQgSSdtIG5v dAp2ZXJ5IGhvcGVmdWwgdGhhdCBmaXhpbmcgdGhvc2Ugd291bGQgaGVscCB3aXRoIHlvdXIgbWFj aGluZS4KCkhlcmUncyBhIGJyYW5jaCBhbnl3YXkgaW4gY2FzZSB5b3Ugd2FudCB0byBnaXZlIGl0 IGEgZ286CmdpdDovL2dpdGh1Yi5jb20vdnN5cmphbGEvbGludXguZ2l0IGRkaV9pYm9vc3RfZml4 ZXMKCkFjdHVhbGx5LCBJIHRoaW5rIHRoZSBvbmx5IHBhdGNoIGluIHRoZXJlIHRoYXQgbWlnaHQg bWFrZSBhIGRpZmZlcmVuY2UgaXMKMTVkODg3ODU1MTgwICgiZHJtL2k5MTU6IEZpeCBpYm9vc3Qg c2V0dGluZyBmb3IgRERJIHdpdGggNCBsYW5lcyBvbiBTS0wiKQoKLS0gClZpbGxlIFN5cmrDpGzD pApJbnRlbCBPVEMKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3Jn Cmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVs Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753196AbcGGQOj (ORCPT ); Thu, 7 Jul 2016 12:14:39 -0400 Received: from mga02.intel.com ([134.134.136.20]:25723 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751896AbcGGQOb (ORCPT ); Thu, 7 Jul 2016 12:14:31 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,324,1464678000"; d="scan'208";a="1012601712" Date: Thu, 7 Jul 2016 19:14:25 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: James Bottomley Cc: "Syrjala, Ville" , intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Message-ID: <20160707161425.GO4329@intel.com> References: <1466112547.2311.3.camel@HansenPartnership.com> <1466116932.2257.4.camel@HansenPartnership.com> <20160617072826.GI23520@phenom.ffwll.local> <87vb18uef2.fsf@intel.com> <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline Content-Transfer-Encoding: 8bit In-Reply-To: <20160621154434.GY4329@intel.com> User-Agent: Mutt/1.5.24 (2015-08-30) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 06:44:34PM +0300, Ville Syrjälä wrote: > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley wrote: > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > Cc: Ville > > > > > > On Mon, 20 Jun 2016, James Bottomley < > > > James.Bottomley@HansenPartnership.com> wrote: > > > > OK, my candidate bad commit is this one: > > > > > > > > commit a05628195a0d9f3173dd9aa76f482aef692e46ee > > > > Author: Ville Syrjälä > > > > Date: Mon Apr 11 10:23:51 2016 +0300 > > > > > > > > drm/i915: Get panel_type from OpRegion panel details > > > > > > > > After being more careful about waiting to identify flicker, this > > > > one seems to be the one the bisect finds. I'm now running v4.7-rc3 > > > > with this one reverted and am currently seeing no flicker problems. > > > > It is, however, early days because the flicker can hide for long > > > > periods, so I 'll wait until Monday evening and a few reboots > > > > before declaring victory. > > > > > > If that turns out to be the bad commit, it doesn't really surprise > > > me, and that in itself is depressing. > > > > As far as I can tell, after running for a day with this reverted, this > > is the problem. The flicker hasn't appeared with it reverted. It's > > pretty noticeable with this commit included. > > Hmm. The only difference I can see is low vs. normal vswing. Panel 0 has > low, panel 2 has normal. So either the VBT or opregion is telling utter > lies, or there's some other bug in our low vswing support. I did a quick once over of out DDI vswing stuff and didn't find anything too serious. There were some buglets in the iboost handling, but I'm not very hopeful that fixing those would help with your machine. Here's a branch anyway in case you want to give it a go: git://github.com/vsyrjala/linux.git ddi_iboost_fixes Actually, I think the only patch in there that might make a difference is 15d887855180 ("drm/i915: Fix iboost setting for DDI with 4 lanes on SKL") -- Ville Syrjälä Intel OTC