From: "Theodore Ts'o" <tytso@mit.edu>
To: Dave Chinner <david@fromorbit.com>
Cc: Eric Sandeen <sandeen@sandeen.net>,
Wang Shilong <wangshilong1991@gmail.com>,
fstests@vger.kernel.org, linux-ext4@vger.kernel.org,
sihara@ddn.com, lixi@ddn.com, Wang Shilong <wshilong@ddn.com>
Subject: Re: [PATCH v2] xfstests, generic: add project quota attribute tests
Date: Thu, 7 Jul 2016 22:46:54 -0400 [thread overview]
Message-ID: <20160708024654.GE19871@thunk.org> (raw)
In-Reply-To: <20160708005127.GK12670@dastard>
On Fri, Jul 08, 2016 at 10:51:27AM +1000, Dave Chinner wrote:
> On Wed, Jul 06, 2016 at 09:47:28PM -0500, Eric Sandeen wrote:
> > On 7/6/16 6:35 PM, Dave Chinner wrote:
> >
> > ...
> >
> > >> +_require_scratch
> > >> +_require_chattr
> > >> +_require_test_lsattr
> > >> +_require_quota
> > >
> > > needs _require_prjquota, and that function needs to be modified to
> > > detect for both XFS and ext4 support.
> >
> > I think that if there is desire to test both xfs and non-xfs userspace
> > with project quota, then we need to differentiate between "e2fsprogs
> > and linux-quota and the kernel all support it" and "xfsprogs and
> > the kernel both support it" don't we?
>
> Well, it should be just "linux-quota and kernel". ext4 needs to
> have the same mount option behaviour for project quota as it does
> for all other types of quota, not be dependent on mkfs....
Project quota for ext4 is an optional thing, and if nothing else, we
need to have a separate feature flag for legacy file systems that were
created before we started supporting project quota. So if you want to
support project quota you *will* need to have a version of e2fsck that
understands project quota, and a version of mke2fs that knows how to
request that project quota be enabled, etc., etc.
So while it might be *nice* if ext4 could support project quota
without being dependent on having a specific version of mke2fs and
e2fsck installed, it's just simply not possible....
> > IOWs if the test uses setquota/repquota, chattr, mkfs, and fsck to
> > work with project quota, then that's a different set of requirements
> > from a test using xfs_io, xfs_quota, etc.
>
> _require_linux_prjquota
> _require_xfs_prjquota
>
> But that said, both ext4 and xfs need to work for both
> configurations, and they should all be using the common xfstests
> quota infrastructure....
Agreed, but we want xfstests to be able to support systems where
linux-quota (aka quotatools) and/or e2fsprogs and/or the kernel
haven't been upgraded to support project quota, don't we? If for no
other reason than to be kind to the poor souls who have to support
RHEL 6. :-)
- Ted
next prev parent reply other threads:[~2016-07-08 2:46 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-06 6:22 [PATCH v2] xfstests, generic: add project quota attribute tests Wang Shilong
2016-07-06 16:10 ` Eric Sandeen
2016-07-06 23:35 ` Dave Chinner
2016-07-07 2:47 ` Eric Sandeen
2016-07-08 0:51 ` Dave Chinner
2016-07-08 2:46 ` Theodore Ts'o [this message]
2016-07-08 3:19 ` Eric Sandeen
2016-07-08 4:57 ` Dave Chinner
2016-07-08 5:02 ` Theodore Ts'o
2016-07-11 16:15 ` Jan Kara
2016-07-11 17:12 ` Theodore Ts'o
2016-07-12 10:59 ` Jan Kara
2016-07-12 14:32 ` Jan Kara
2016-07-12 16:15 ` Theodore Ts'o
2016-07-14 13:13 ` Jan Kara
2016-07-15 1:15 ` Wang Shilong
2016-07-18 10:20 ` Jan Kara
2016-07-18 12:45 ` Wang Shilong
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708024654.GE19871@thunk.org \
--to=tytso@mit.edu \
--cc=david@fromorbit.com \
--cc=fstests@vger.kernel.org \
--cc=linux-ext4@vger.kernel.org \
--cc=lixi@ddn.com \
--cc=sandeen@sandeen.net \
--cc=sihara@ddn.com \
--cc=wangshilong1991@gmail.com \
--cc=wshilong@ddn.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.