From mboxrd@z Thu Jan 1 00:00:00 1970 From: Adrien Mazarguil Subject: Re: [PATCH] net/mlx5: fix packet type and offload flags in Rx Date: Fri, 8 Jul 2016 09:09:32 +0200 Message-ID: <20160708070932.GY7621@6wind.com> References: <1467909285-896-1-git-send-email-maxime.leroy@6wind.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: dev@dpdk.org To: Maxime Leroy Return-path: Received: from mail-wm0-f42.google.com (mail-wm0-f42.google.com [74.125.82.42]) by dpdk.org (Postfix) with ESMTP id 077E95680 for ; Fri, 8 Jul 2016 09:09:38 +0200 (CEST) Received: by mail-wm0-f42.google.com with SMTP id z126so6836207wme.0 for ; Fri, 08 Jul 2016 00:09:38 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1467909285-896-1-git-send-email-maxime.leroy@6wind.com> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Thu, Jul 07, 2016 at 06:34:45PM +0200, Maxime Leroy wrote: > In mlx5 rx function, the packet_type and ol_flags mbuf fields are not > properly initialized when no rx offload feature is enabled (checksum, l2 > tun checksum, vlan_strip, crc). Thus, these fields can have a value > different of 0 depending on their value when the mbuf was freed. > > This can result in an incorrect application behavior if invalid > ol_flags/ptype are set, or memory corruptions if IND_ATTACHED_MBUF is > set in ol_flags. > > Fixes: 081f7eae242e ("mlx5: process offload flags only when requested") > > Signed-off-by: Maxime Leroy > --- > drivers/net/mlx5/mlx5_rxtx.c | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/drivers/net/mlx5/mlx5_rxtx.c b/drivers/net/mlx5/mlx5_rxtx.c > index 0c352f3f..4132fd74 100644 > --- a/drivers/net/mlx5/mlx5_rxtx.c > +++ b/drivers/net/mlx5/mlx5_rxtx.c > @@ -1599,6 +1599,8 @@ mlx5_rx_burst(void *dpdk_rxq, struct rte_mbuf **pkts, uint16_t pkts_n) > pkt = seg; > assert(len >= (rxq->crc_present << 2)); > /* Update packet information. */ > + pkt->packet_type = 0; > + pkt->ol_flags = 0; > if (rxq->csum | rxq->csum_l2tun | rxq->vlan_strip | > rxq->crc_present) { > if (rxq->csum) { > -- > 2.1.4 > Acked-by: Adrien Mazarguil -- Adrien Mazarguil 6WIND