From: Borislav Petkov <bp@alien8.de>
To: Ingo Molnar <mingo@kernel.org>
Cc: LKML <linux-kernel@vger.kernel.org>,
Yazen Ghannam <Yazen.Ghannam@amd.com>
Subject: Re: [PATCH 3/6] x86/mce: Add support for new MCA_SYND register
Date: Fri, 8 Jul 2016 11:37:31 +0200 [thread overview]
Message-ID: <20160708093731.GC3808@pd.tnic> (raw)
In-Reply-To: <20160708092659.GB13849@gmail.com>
On Fri, Jul 08, 2016 at 11:26:59AM +0200, Ingo Molnar wrote:
> So why does neither the changelog nor the code comment actually _explain_ this and
> give aa bit of a background about what 'syndrome information' is and why we want
> to have kernel support for it?
>
> This is why I hate kernel tooling that is not part of the kernel tree - the mcelog
> patch (hopefully ...) would tell us more about all this - but it's separate and
> this patch does not tell us anything ...
Ah, this is one of those omissions where we forgot to explain, sorry.
How about this:
"The syndrome value is used to uniquely identify which bits of a
reported ECC error are corrupted."
Do you want it as a comment in the code or in the commit message or both?
Thanks.
--
Regards/Gruss,
Boris.
ECO tip #101: Trim your mails when you reply.
next prev parent reply other threads:[~2016-07-08 9:37 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-08 9:09 [PATCH 0/6] x86/RAS queue Borislav Petkov
2016-07-08 9:09 ` [PATCH 1/6] x86/mce/AMD: Increase size of bank_map type Borislav Petkov
2016-07-08 9:21 ` Ingo Molnar
2016-07-08 9:32 ` Borislav Petkov
2016-07-08 12:05 ` [tip:ras/core] x86/mce/AMD: Increase size of the " tip-bot for Aravind Gopalakrishnan
2016-07-08 9:09 ` [PATCH 2/6] x86/RAS/AMD: Reduce number of IPIs when prepping error injection Borislav Petkov
2016-07-08 12:06 ` [tip:ras/core] x86/RAS/AMD: Reduce the " tip-bot for Yazen Ghannam
2016-07-08 9:09 ` [PATCH 3/6] x86/mce: Add support for new MCA_SYND register Borislav Petkov
2016-07-08 9:26 ` Ingo Molnar
2016-07-08 9:37 ` Borislav Petkov [this message]
2016-07-08 9:46 ` Ingo Molnar
2016-07-08 10:14 ` Borislav Petkov
2016-07-08 10:26 ` Ingo Molnar
2016-07-08 10:48 ` Borislav Petkov
2016-07-08 9:09 ` [PATCH 4/6] x86/mce: Fix mce_rdmsrl() warning message Borislav Petkov
2016-07-08 12:06 ` [tip:ras/core] " tip-bot for Borislav Petkov
2016-07-08 9:09 ` [PATCH 5/6] EDAC, mce_amd: Print syndrome register value on SMCA systems Borislav Petkov
2016-07-08 9:09 ` [PATCH 6/6] x86/RAS: Add syndrome support to mce_amd_inj Borislav Petkov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160708093731.GC3808@pd.tnic \
--to=bp@alien8.de \
--cc=Yazen.Ghannam@amd.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.