From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1754944AbcGHOS4 (ORCPT ); Fri, 8 Jul 2016 10:18:56 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:25849 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754868AbcGHOSs (ORCPT ); Fri, 8 Jul 2016 10:18:48 -0400 Date: Fri, 8 Jul 2016 10:17:37 -0400 From: Konrad Rzeszutek Wilk To: Jan Beulich Cc: david.vrabel@citrix.com, boris.ostrovsky@oracle.com, Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Message-ID: <20160708141737.GG22329@char.us.oracle.com> References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: userv0021.oracle.com [156.151.31.71] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote: > For single items being collected this should be preferred as being more > typesafe (as the compiler can check format string and to-be-written-to > variable match) and more efficient (requiring one less parameter to be > passed). > > 1: xenbus: prefer xenbus_scanf() over xenbus_gather() > 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather() > 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather() > 4: xen-netback: prefer xenbus_scanf() over xenbus_gather() > > Signed-off-by: Jan Beulich > --- > v2: Avoid commit messages to continue from subjects. Group into a series. To confuse this, Roger and I are the block sub-maintainers, which when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen. Anyhow, I've already committed and tested for regressions these: 79ef83a xen-blkback: constify instance of "struct attribute_group" 5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather() e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather() 5b3b1db xen-blkback: really don't leak mode property And plan to send them to Jens. They will shortly be at my git tree under 'stable/for-jens-4.8'. > > > > _______________________________________________ > Xen-devel mailing list > Xen-devel@lists.xen.org > https://lists.xen.org/xen-devel From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Date: Fri, 8 Jul 2016 10:17:37 -0400 Message-ID: <20160708141737.GG22329@char.us.oracle.com> References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta3.messagelabs.com ([195.245.230.39]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLWbC-0006lT-MQ for xen-devel@lists.xenproject.org; Fri, 08 Jul 2016 14:17:46 +0000 Content-Disposition: inline In-Reply-To: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: Jan Beulich Cc: Juergen Gross , xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, david.vrabel@citrix.com, linux-kernel@vger.kernel.org List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBKdWwgMDgsIDIwMTYgYXQgMDY6MjE6NTJBTSAtMDYwMCwgSmFuIEJldWxpY2ggd3Jv dGU6Cj4gRm9yIHNpbmdsZSBpdGVtcyBiZWluZyBjb2xsZWN0ZWQgdGhpcyBzaG91bGQgYmUgcHJl ZmVycmVkIGFzIGJlaW5nIG1vcmUKPiB0eXBlc2FmZSAoYXMgdGhlIGNvbXBpbGVyIGNhbiBjaGVj ayBmb3JtYXQgc3RyaW5nIGFuZCB0by1iZS13cml0dGVuLXRvCj4gdmFyaWFibGUgbWF0Y2gpIGFu ZCBtb3JlIGVmZmljaWVudCAocmVxdWlyaW5nIG9uZSBsZXNzIHBhcmFtZXRlciB0byBiZQo+IHBh c3NlZCkuCj4gCj4gMTogeGVuYnVzOiBwcmVmZXIgeGVuYnVzX3NjYW5mKCkgb3ZlciB4ZW5idXNf Z2F0aGVyKCkKPiAyOiB4ZW4tYmxrYmFjazogcHJlZmVyIHhlbmJ1c19zY2FuZigpIG92ZXIgeGVu YnVzX2dhdGhlcigpCj4gMzogeGVuLWJsa2Zyb250OiBwcmVmZXIgeGVuYnVzX3NjYW5mKCkgb3Zl ciB4ZW5idXNfZ2F0aGVyKCkKPiA0OiB4ZW4tbmV0YmFjazogcHJlZmVyIHhlbmJ1c19zY2FuZigp IG92ZXIgeGVuYnVzX2dhdGhlcigpCj4gCj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpi ZXVsaWNoQHN1c2UuY29tPgo+IC0tLQo+IHYyOiBBdm9pZCBjb21taXQgbWVzc2FnZXMgdG8gY29u dGludWUgZnJvbSBzdWJqZWN0cy4gR3JvdXAgaW50byBhIHNlcmllcy4KClRvIGNvbmZ1c2UgdGhp cywgUm9nZXIgYW5kIEkgYXJlIHRoZSBibG9jayBzdWItbWFpbnRhaW5lcnMsIHdoaWNoCndoZW4g d2UgYXJlIGhhcHB5LCBJIHNlbmQgdG8gSmVucywgd2hpbGUgdGhlIHJlc3QgZ28gdGhyb3VnaCBC b3JpcyxEYXZpZCwgYW5kIEp1ZXJnZW4uCgpBbnlob3csIEkndmUgYWxyZWFkeSBjb21taXR0ZWQg YW5kIHRlc3RlZCBmb3IgcmVncmVzc2lvbnMgdGhlc2U6Cjc5ZWY4M2EgeGVuLWJsa2JhY2s6IGNv bnN0aWZ5IGluc3RhbmNlIG9mICJzdHJ1Y3QgYXR0cmlidXRlX2dyb3VwIgo1ZTRkNjU5IHhlbi1i bGtmcm9udDogcHJlZmVyIHhlbmJ1c19zY2FuZigpIG92ZXIgeGVuYnVzX2dhdGhlcigpCmU5ZDFl YmUgeGVuLWJsa2JhY2s6IHByZWZlciB4ZW5idXNfc2NhbmYoKSBvdmVyIHhlbmJ1c19nYXRoZXIo KQo1YjNiMWRiIHhlbi1ibGtiYWNrOiByZWFsbHkgZG9uJ3QgbGVhayBtb2RlIHByb3BlcnR5CgpB bmQgcGxhbiB0byBzZW5kIHRoZW0gdG8gSmVucy4gVGhleSB3aWxsIHNob3J0bHkgYmUgYXQgbXkg Z2l0IHRyZWUKdW5kZXIgJ3N0YWJsZS9mb3ItamVucy00LjgnLgoKCj4gCj4gCj4gCj4gX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KPiBYZW4tZGV2ZWwgbWFp bGluZyBsaXN0Cj4gWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcKPiBodHRwczovL2xpc3RzLnhlbi5v cmcveGVuLWRldmVsCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpYZW4tZGV2ZWwgbWFpbGluZyBsaXN0Clhlbi1kZXZlbEBsaXN0cy54ZW4ub3JnCmh0dHBz Oi8vbGlzdHMueGVuLm9yZy94ZW4tZGV2ZWwK