Re: [PATCH] IB core sysfs: Add port_xmit_wait_counter V2

[Leon Romanovsky <leon-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>]

[-- Attachment #1: Type: text/plain, Size: 1235 bytes --]

On Thu, Jul 07, 2016 at 12:36:00PM -0500, Christoph Lameter wrote:
> 
> V1->V2
> - Tested. Found that we missed modifying one table.
> 
> 
> Add the missing port_xmit_wait counter. This counter is displayed through
> some tools like perfquery but is not available via sysfs.
> 
> For the PORT_PMA_ATTR macro the _counter field is set to zero
> allowing us to specify the offset directly like with PORT_PMA_ATTR_EXT
> 
> See also the earlier work in 2008 by Vladimir Skolovsky
> 
> https://www.mail-archive.com/general-ZwoEplunGu1OwGhvXhtEPSCwEArCW2h5@public.gmane.org/msg20313.html
> 
> Tested-by: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>
> Signed-off-by: Christoph Lameter <cl-vYTEC60ixJUAvxtiuMwx3w@public.gmane.org>

Hi Christoph,
Do you mind to improve the commit message a little bit?
1. Put versioning in [PATCH] section - {PATCH v3]. It will give clean
subject line in git history.
2. Put changelog after "---" line at the end of commit message.
3. Add Vlad's SOB (Signed-off-by: Vlad Sokolovsky <vlad-VPRAkNaXOzVWk0Htik3J/w@public.gmane.org>).
4. Remove your Tested-by line, it goes without saying.
5. Change title to format used in this subsystem - IB/core: Add ....

Thanks

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]