From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755754AbcGHP4F (ORCPT ); Fri, 8 Jul 2016 11:56:05 -0400 Received: from aserp1040.oracle.com ([141.146.126.69]:50189 "EHLO aserp1040.oracle.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755087AbcGHPz5 (ORCPT ); Fri, 8 Jul 2016 11:55:57 -0400 Date: Fri, 8 Jul 2016 11:54:46 -0400 From: Konrad Rzeszutek Wilk To: David Vrabel Cc: Jan Beulich , boris.ostrovsky@oracle.com, Juergen Gross , xen-devel@lists.xenproject.org, linux-kernel@vger.kernel.org Subject: Re: [Xen-devel] [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Message-ID: <20160708155446.GA29604@char.us.oracle.com> References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> <20160708141737.GG22329@char.us.oracle.com> <577FC9A0.9080407@citrix.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <577FC9A0.9080407@citrix.com> User-Agent: Mutt/1.5.24 (2015-08-30) X-Source-IP: aserv0021.oracle.com [141.146.126.233] Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 04:41:20PM +0100, David Vrabel wrote: > On 08/07/16 15:17, Konrad Rzeszutek Wilk wrote: > > On Fri, Jul 08, 2016 at 06:21:52AM -0600, Jan Beulich wrote: > >> For single items being collected this should be preferred as being more > >> typesafe (as the compiler can check format string and to-be-written-to > >> variable match) and more efficient (requiring one less parameter to be > >> passed). > >> > >> 1: xenbus: prefer xenbus_scanf() over xenbus_gather() > >> 2: xen-blkback: prefer xenbus_scanf() over xenbus_gather() > >> 3: xen-blkfront: prefer xenbus_scanf() over xenbus_gather() > >> 4: xen-netback: prefer xenbus_scanf() over xenbus_gather() > >> > >> Signed-off-by: Jan Beulich > >> --- > >> v2: Avoid commit messages to continue from subjects. Group into a series. > > > > To confuse this, Roger and I are the block sub-maintainers, which > > when we are happy, I send to Jens, while the rest go through Boris,David, and Juergen. > > > > Anyhow, I've already committed and tested for regressions these: > > 79ef83a xen-blkback: constify instance of "struct attribute_group" > > 5e4d659 xen-blkfront: prefer xenbus_scanf() over xenbus_gather() > > e9d1ebe xen-blkback: prefer xenbus_scanf() over xenbus_gather() > > 5b3b1db xen-blkback: really don't leak mode property > > If they're tree wide largely mechanical changes to Xen-related APIs I > prefer that they go via the Xen tree all together. > > This saves the submitter chasing the individual subsystem maintainers. Sure, but from a stricly SubmittingPatches point of view it would fall on your to get the Acks from the other maintainers. Either way, I am OK with those blkback and blkfront going through your tree, albeit one will conflict with Jens 'for-4.8/drivers'. > > David From mboxrd@z Thu Jan 1 00:00:00 1970 From: Konrad Rzeszutek Wilk Subject: Re: [PATCH v2 0/4] xen: prefer xenbus_scanf() over xenbus_gather() Date: Fri, 8 Jul 2016 11:54:46 -0400 Message-ID: <20160708155446.GA29604@char.us.oracle.com> References: <577FB70002000078000FC9FA@prv-mh.provo.novell.com> <20160708141737.GG22329@char.us.oracle.com> <577FC9A0.9080407@citrix.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail6.bemta6.messagelabs.com ([85.158.143.247]) by lists.xenproject.org with esmtp (Exim 4.84_2) (envelope-from ) id 1bLY7C-0006B8-Mc for xen-devel@lists.xenproject.org; Fri, 08 Jul 2016 15:54:54 +0000 Content-Disposition: inline In-Reply-To: <577FC9A0.9080407@citrix.com> List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Errors-To: xen-devel-bounces@lists.xen.org Sender: "Xen-devel" To: David Vrabel Cc: Juergen Gross , xen-devel@lists.xenproject.org, boris.ostrovsky@oracle.com, linux-kernel@vger.kernel.org, Jan Beulich List-Id: xen-devel@lists.xenproject.org T24gRnJpLCBKdWwgMDgsIDIwMTYgYXQgMDQ6NDE6MjBQTSArMDEwMCwgRGF2aWQgVnJhYmVsIHdy b3RlOgo+IE9uIDA4LzA3LzE2IDE1OjE3LCBLb25yYWQgUnplc3p1dGVrIFdpbGsgd3JvdGU6Cj4g PiBPbiBGcmksIEp1bCAwOCwgMjAxNiBhdCAwNjoyMTo1MkFNIC0wNjAwLCBKYW4gQmV1bGljaCB3 cm90ZToKPiA+PiBGb3Igc2luZ2xlIGl0ZW1zIGJlaW5nIGNvbGxlY3RlZCB0aGlzIHNob3VsZCBi ZSBwcmVmZXJyZWQgYXMgYmVpbmcgbW9yZQo+ID4+IHR5cGVzYWZlIChhcyB0aGUgY29tcGlsZXIg Y2FuIGNoZWNrIGZvcm1hdCBzdHJpbmcgYW5kIHRvLWJlLXdyaXR0ZW4tdG8KPiA+PiB2YXJpYWJs ZSBtYXRjaCkgYW5kIG1vcmUgZWZmaWNpZW50IChyZXF1aXJpbmcgb25lIGxlc3MgcGFyYW1ldGVy IHRvIGJlCj4gPj4gcGFzc2VkKS4KPiA+Pgo+ID4+IDE6IHhlbmJ1czogcHJlZmVyIHhlbmJ1c19z Y2FuZigpIG92ZXIgeGVuYnVzX2dhdGhlcigpCj4gPj4gMjogeGVuLWJsa2JhY2s6IHByZWZlciB4 ZW5idXNfc2NhbmYoKSBvdmVyIHhlbmJ1c19nYXRoZXIoKQo+ID4+IDM6IHhlbi1ibGtmcm9udDog cHJlZmVyIHhlbmJ1c19zY2FuZigpIG92ZXIgeGVuYnVzX2dhdGhlcigpCj4gPj4gNDogeGVuLW5l dGJhY2s6IHByZWZlciB4ZW5idXNfc2NhbmYoKSBvdmVyIHhlbmJ1c19nYXRoZXIoKQo+ID4+Cj4g Pj4gU2lnbmVkLW9mZi1ieTogSmFuIEJldWxpY2ggPGpiZXVsaWNoQHN1c2UuY29tPgo+ID4+IC0t LQo+ID4+IHYyOiBBdm9pZCBjb21taXQgbWVzc2FnZXMgdG8gY29udGludWUgZnJvbSBzdWJqZWN0 cy4gR3JvdXAgaW50byBhIHNlcmllcy4KPiA+IAo+ID4gVG8gY29uZnVzZSB0aGlzLCBSb2dlciBh bmQgSSBhcmUgdGhlIGJsb2NrIHN1Yi1tYWludGFpbmVycywgd2hpY2gKPiA+IHdoZW4gd2UgYXJl IGhhcHB5LCBJIHNlbmQgdG8gSmVucywgd2hpbGUgdGhlIHJlc3QgZ28gdGhyb3VnaCBCb3JpcyxE YXZpZCwgYW5kIEp1ZXJnZW4uCj4gPiAKPiA+IEFueWhvdywgSSd2ZSBhbHJlYWR5IGNvbW1pdHRl ZCBhbmQgdGVzdGVkIGZvciByZWdyZXNzaW9ucyB0aGVzZToKPiA+IDc5ZWY4M2EgeGVuLWJsa2Jh Y2s6IGNvbnN0aWZ5IGluc3RhbmNlIG9mICJzdHJ1Y3QgYXR0cmlidXRlX2dyb3VwIgo+ID4gNWU0 ZDY1OSB4ZW4tYmxrZnJvbnQ6IHByZWZlciB4ZW5idXNfc2NhbmYoKSBvdmVyIHhlbmJ1c19nYXRo ZXIoKQo+ID4gZTlkMWViZSB4ZW4tYmxrYmFjazogcHJlZmVyIHhlbmJ1c19zY2FuZigpIG92ZXIg eGVuYnVzX2dhdGhlcigpCj4gPiA1YjNiMWRiIHhlbi1ibGtiYWNrOiByZWFsbHkgZG9uJ3QgbGVh ayBtb2RlIHByb3BlcnR5Cj4gCj4gSWYgdGhleSdyZSB0cmVlIHdpZGUgbGFyZ2VseSBtZWNoYW5p Y2FsIGNoYW5nZXMgdG8gWGVuLXJlbGF0ZWQgQVBJcyBJCj4gcHJlZmVyIHRoYXQgdGhleSBnbyB2 aWEgdGhlIFhlbiB0cmVlIGFsbCB0b2dldGhlci4KPiAKPiBUaGlzIHNhdmVzIHRoZSBzdWJtaXR0 ZXIgY2hhc2luZyB0aGUgaW5kaXZpZHVhbCBzdWJzeXN0ZW0gbWFpbnRhaW5lcnMuCgpTdXJlLCBi dXQgZnJvbSBhIHN0cmljbHkgU3VibWl0dGluZ1BhdGNoZXMgcG9pbnQgb2YgdmlldyBpdCB3b3Vs ZApmYWxsIG9uIHlvdXIgdG8gZ2V0IHRoZSBBY2tzIGZyb20gdGhlIG90aGVyIG1haW50YWluZXJz LgoKRWl0aGVyIHdheSwgSSBhbSBPSyB3aXRoIHRob3NlIGJsa2JhY2sgYW5kIGJsa2Zyb250IGdv aW5nIHRocm91Z2gKeW91ciB0cmVlLCBhbGJlaXQgb25lIHdpbGwgY29uZmxpY3Qgd2l0aCBKZW5z ICdmb3ItNC44L2RyaXZlcnMnLgoKPiAKPiBEYXZpZAoKX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX18KWGVuLWRldmVsIG1haWxpbmcgbGlzdApYZW4tZGV2ZWxA bGlzdHMueGVuLm9yZwpodHRwczovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVsCg==