From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: Bad flicker on skylake HQD due to code in the 4.7 merge window Date: Fri, 8 Jul 2016 19:56:00 +0300 Message-ID: <20160708165600.GU4329@intel.com> References: <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> <1467910504.2322.9.camel@HansenPartnership.com> <1467919176.2322.38.camel@HansenPartnership.com> <20160708101934.GQ4329@intel.com> <1467989309.2245.2.camel@HansenPartnership.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Content-Disposition: inline In-Reply-To: <1467989309.2245.2.camel@HansenPartnership.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: James Bottomley Cc: dri-devel , intel-gfx , linux-kernel , Rodrigo Vivi List-Id: dri-devel@lists.freedesktop.org T24gRnJpLCBKdWwgMDgsIDIwMTYgYXQgMDc6NDg6MjlBTSAtMDcwMCwgSmFtZXMgQm90dG9tbGV5 IHdyb3RlOgo+IE9uIEZyaSwgMjAxNi0wNy0wOCBhdCAxMzoxOSArMDMwMCwgVmlsbGUgU3lyasOk bMOkIHdyb3RlOgo+ID4gT24gVGh1LCBKdWwgMDcsIDIwMTYgYXQgMTI6MTk6MzZQTSAtMDcwMCwg SmFtZXMgQm90dG9tbGV5IHdyb3RlOgo+ID4gPiBPbiBUaHUsIDIwMTYtMDctMDcgYXQgMDk6NTUg LTA3MDAsIEphbWVzIEJvdHRvbWxleSB3cm90ZToKPiA+ID4gPiBPbiBUaHUsIDIwMTYtMDctMDcg YXQgMTk6MTQgKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToKPiA+ID4gPiA+IE9uIFR1ZSwg SnVuIDIxLCAyMDE2IGF0IDA2OjQ0OjM0UE0gKzAzMDAsIFZpbGxlIFN5cmrDpGzDpCB3cm90ZToK PiA+ID4gPiA+ID4gT24gVHVlLCBKdW4gMjEsIDIwMTYgYXQgMDk6NTM6MTVBTSAtMDQwMCwgSmFt ZXMgQm90dG9tbGV5Cj4gPiA+ID4gPiA+IHdyb3RlOgo+ID4gPiA+ID4gPiA+IE9uIE1vbiwgMjAx Ni0wNi0yMCBhdCAxMTowMyArMDMwMCwgSmFuaSBOaWt1bGEgd3JvdGU6Cj4gPiA+ID4gPiA+ID4g PiBDYzogVmlsbGUKPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4gT24gTW9uLCAyMCBK dW4gMjAxNiwgSmFtZXMgQm90dG9tbGV5IDwKPiA+ID4gPiA+ID4gPiA+IEphbWVzLkJvdHRvbWxl eUBIYW5zZW5QYXJ0bmVyc2hpcC5jb20+IHdyb3RlOgo+ID4gPiA+ID4gPiA+ID4gPiBPSywgbXkg Y2FuZGlkYXRlIGJhZCBjb21taXQgaXMgdGhpcyBvbmU6Cj4gPiA+ID4gPiA+ID4gPiA+IAo+ID4g PiA+ID4gPiA+ID4gPiBjb21taXQgYTA1NjI4MTk1YTBkOWYzMTczZGQ5YWE3NmY0ODJhZWY2OTJl NDZlZQo+ID4gPiA+ID4gPiA+ID4gPiBBdXRob3I6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gPiA+ID4gPiA+IERhdGU6ICAgTW9uIEFwciAx MSAxMDoyMzo1MSAyMDE2ICswMzAwCj4gPiA+ID4gPiA+ID4gPiA+IAo+ID4gPiA+ID4gPiA+ID4g PiAgICAgZHJtL2k5MTU6IEdldCBwYW5lbF90eXBlIGZyb20gT3BSZWdpb24gcGFuZWwKPiA+ID4g PiA+ID4gPiA+ID4gZGV0YWlscwo+ID4gPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiA+ID4g QWZ0ZXIgYmVpbmcgbW9yZSBjYXJlZnVsIGFib3V0IHdhaXRpbmcgdG8gaWRlbnRpZnkKPiA+ID4g PiA+ID4gPiA+ID4gZmxpY2tlciwKPiA+ID4gPiA+ID4gPiA+ID4gdGhpcyBvbmUgc2VlbXMgdG8g YmUgdGhlIG9uZSB0aGUgYmlzZWN0IGZpbmRzLiAgSSdtIG5vdwo+ID4gPiA+ID4gPiA+ID4gPiBy dW5uaW5nIHY0LjctcmMzIHdpdGggdGhpcyBvbmUgcmV2ZXJ0ZWQgYW5kIGFtCj4gPiA+ID4gPiA+ ID4gPiA+IGN1cnJlbnRseSAKPiA+ID4gPiA+ID4gPiA+ID4gc2VlaW5nIG5vIGZsaWNrZXIgcHJv YmxlbXMuICAgSXQgaXMsIGhvd2V2ZXIsIGVhcmx5Cj4gPiA+ID4gPiA+ID4gPiA+IGRheXMgCj4g PiA+ID4gPiA+ID4gPiA+IGJlY2F1c2UgdGhlIGZsaWNrZXIgY2FuIGhpZGUgZm9yIGxvbmcgcGVy aW9kcywgc28gSSAnbGwKPiA+ID4gPiA+ID4gPiA+ID4gd2FpdCAKPiA+ID4gPiA+ID4gPiA+ID4g dW50aWwgTW9uZGF5IGV2ZW5pbmcgYW5kIGEgZmV3IHJlYm9vdHMgYmVmb3JlIGRlY2xhcmluZwo+ ID4gPiA+ID4gPiA+ID4gPiB2aWN0b3J5Lgo+ID4gPiA+ID4gPiA+ID4gCj4gPiA+ID4gPiA+ID4g PiBJZiB0aGF0IHR1cm5zIG91dCB0byBiZSB0aGUgYmFkIGNvbW1pdCwgaXQgZG9lc24ndCByZWFs bHkKPiA+ID4gPiA+ID4gPiA+IHN1cnByaXNlIG1lLCBhbmQgdGhhdCBpbiBpdHNlbGYgaXMgZGVw cmVzc2luZy4KPiA+ID4gPiA+ID4gPiAKPiA+ID4gPiA+ID4gPiBBcyBmYXIgYXMgSSBjYW4gdGVs bCwgYWZ0ZXIgcnVubmluZyBmb3IgYSBkYXkgd2l0aCB0aGlzCj4gPiA+ID4gPiA+ID4gcmV2ZXJ0 ZWQsIAo+ID4gPiA+ID4gPiA+IHRoaXMgaXMgdGhlIHByb2JsZW0uICBUaGUgZmxpY2tlciBoYXNu J3QgYXBwZWFyZWQgd2l0aCBpdCAKPiA+ID4gPiA+ID4gPiByZXZlcnRlZC4gIEl0J3MgcHJldHR5 IG5vdGljZWFibGUgd2l0aCB0aGlzIGNvbW1pdAo+ID4gPiA+ID4gPiA+IGluY2x1ZGVkLgo+ID4g PiA+ID4gPiAKPiA+ID4gPiA+ID4gSG1tLiBUaGUgb25seSBkaWZmZXJlbmNlIEkgY2FuIHNlZSBp cyBsb3cgdnMuIG5vcm1hbCB2c3dpbmcuCj4gPiA+ID4gPiA+IFBhbmVsIAo+ID4gPiA+ID4gPiAw IGhhcyBsb3csIHBhbmVsIDIgaGFzIG5vcm1hbC4gU28gZWl0aGVyIHRoZSBWQlQgb3Igb3ByZWdp b24KPiA+ID4gPiA+ID4gaXMgCj4gPiA+ID4gPiA+IHRlbGxpbmcgdXR0ZXIgbGllcywgb3IgdGhl cmUncyBzb21lIG90aGVyIGJ1ZyBpbiBvdXIgbG93Cj4gPiA+ID4gPiA+IHZzd2luZwo+ID4gPiA+ ID4gPiBzdXBwb3J0Lgo+ID4gPiA+ID4gCj4gPiA+ID4gPiBJIGRpZCBhIHF1aWNrIG9uY2Ugb3Zl ciBvZiBvdXQgRERJIHZzd2luZyBzdHVmZiBhbmQgZGlkbid0IGZpbmQKPiA+ID4gPiA+IGFueXRo aW5nIHRvbyBzZXJpb3VzLiBUaGVyZSB3ZXJlIHNvbWUgYnVnbGV0cyBpbiB0aGUgaWJvb3N0Cj4g PiA+ID4gPiBoYW5kbGluZywgCj4gPiA+ID4gPiBidXQgSSdtIG5vdCB2ZXJ5IGhvcGVmdWwgdGhh dCBmaXhpbmcgdGhvc2Ugd291bGQgaGVscCB3aXRoIHlvdXIKPiA+ID4gPiA+IG1hY2hpbmUuIAo+ ID4gPiA+ID4gCj4gPiA+ID4gPiBIZXJlJ3MgYSBicmFuY2ggYW55d2F5IGluIGNhc2UgeW91IHdh bnQgdG8gZ2l2ZSBpdCBhIGdvOgo+ID4gPiA+ID4gZ2l0Oi8vZ2l0aHViLmNvbS92c3lyamFsYS9s aW51eC5naXQgZGRpX2lib29zdF9maXhlcwo+ID4gPiA+ID4gCj4gPiA+ID4gPiBBY3R1YWxseSwg SSB0aGluayB0aGUgb25seSBwYXRjaCBpbiB0aGVyZSB0aGF0IG1pZ2h0IG1ha2UgYSAKPiA+ID4g PiA+IGRpZmZlcmVuY2UgaXMgMTVkODg3ODU1MTgwICgiZHJtL2k5MTU6IEZpeCBpYm9vc3Qgc2V0 dGluZyBmb3IKPiA+ID4gPiA+IERESSAKPiA+ID4gPiA+IHdpdGggNCBsYW5lcyBvbiBTS0wiKQo+ ID4gPiA+IAo+ID4gPiA+IFJ1bm5pbmcgd2l0aCBpdCBub3cgKHRoZSBlbnRpcmUgYnJhbmNoKS4g IFNvIGZhciBpdCBsb29rcyBPSywgYnV0Cj4gPiA+ID4gSSdsbCBnaXZlIGl0IGEgY291cGxlIG9m IGRheXMgdG8gc2VlIGlmIGFueXRoaW5nIG1hbmlmZXN0cyBiZWZvcmUKPiA+ID4gPiBkZWNsYXJp bmcgdmljdG9yeS4KPiA+ID4gCj4gPiA+IEJhZCBuZXdzLCBJJ20gYWZyYWlkOiBhZnRlciBhIGNv dXBsZSBvZiBob3VycyBvZiBydW4gdGltZSwgdGhlcmUgaXMKPiA+ID4gbm93Cj4gPiA+IG5vdGlj ZWFibGUgZmxpY2tlciBvbiB0aGUgZGlzcGxheSwgc28gYWx0aG91Z2ggdGhlIGlib29zdCBmaXhl cyBtYXkKPiA+ID4gaGF2ZSBsZXNzZW5lZCBpdCwgaXQncyBzdGlsbCBwcmVzZW50Lgo+ID4gCj4g PiBPaCB3ZWxsLCBJIHN1c3BlY3RlZCBhcyBtdWNoLiBXaGljaCBCSU9TIHZlcnNpb24gZGlkIHlv dSBoYXZlIAo+ID4gZXhhY3RseT8KPiAKPiBBcyBtZW50aW9uZWQgdXB0aHJlYWQsIG5vdyAxLjQu MyBzaW5jZSBza3lsYWtlIG1pY3JvY29kZSB3YXMKPiBwb3RlbnRpYWxseSBpbXBsaWNhdGVkIGlu IHRoZSBwcm9ibGVtOgo+IAo+IGh0dHA6Ly9taWQuZ21hbmUub3JnLzE0NjYxNzk3MjkuMjI3MS4z My5jYW1lbEBIYW5zZW5QYXJ0bmVyc2hpcC5jb20KPiAKPiA+IElmIEknbSByZWFkaW5nIHRoZSBE ZWxsIHdlYnNpdGUgY29ycmVjdGx5IHRoZXJlJ3MgYSBuZXcgb25lICgxLjQuNCkKPiA+IHJlbGVh c2VkIG9uIEp1biAzMCwgd2hpY2ggaXMgYWZ0ZXIgeW91IHJlcG9ydGVkIHRoZSBpc3N1ZS4gTWln aHQgYmUKPiA+IEknbSByZWFkaW5nIHRoZSB3cm9uZyB0aGluZyB0aG91Z2guIENhbiB5b3UgZG91 YmxlIGNoZWNrIHRoaXM/Cj4gCj4gTmV3IGJpb3MgZG9lc24ndCBjaGFuZ2UgdGhlIG1pY3JvY29k ZToKPiAKPiBbICAgIDIuMzkwMTcyXSBtaWNyb2NvZGU6IENQVTAgc2lnPTB4NDA2ZTMsIHBmPTB4 ODAsIHJldmlzaW9uPTB4OGEKCkkgd2FzIGhvcGluZyBpdCB3b3VsZCBoYXZlIGZpeGVkIHRoZSBW QlQsIGJ1dCBzZWVtcyB0aGF0IHdhcyBub3QgdGhlIGNhc2UKaWYgdGhlIHN5bXB0b21zIGRpZG4n dCBjaGFuZ2UgOigKCi0tIApWaWxsZSBTeXJqw6Rsw6QKSW50ZWwgT1RDCi0tLS0tLS0tLS0tLS0t LS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQpJ bnRlbCBGaW5sYW5kIE95ClJlZ2lzdGVyZWQgQWRkcmVzczogUEwgMjgxLCAwMDE4MSBIZWxzaW5r aSAKQnVzaW5lc3MgSWRlbnRpdHkgQ29kZTogMDM1NzYwNiAtIDQgCkRvbWljaWxlZCBpbiBIZWxz aW5raSAKClRoaXMgZS1tYWlsIGFuZCBhbnkgYXR0YWNobWVudHMgbWF5IGNvbnRhaW4gY29uZmlk ZW50aWFsIG1hdGVyaWFsIGZvcgp0aGUgc29sZSB1c2Ugb2YgdGhlIGludGVuZGVkIHJlY2lwaWVu dChzKS4gQW55IHJldmlldyBvciBkaXN0cmlidXRpb24KYnkgb3RoZXJzIGlzIHN0cmljdGx5IHBy b2hpYml0ZWQuIElmIHlvdSBhcmUgbm90IHRoZSBpbnRlbmRlZApyZWNpcGllbnQsIHBsZWFzZSBj b250YWN0IHRoZSBzZW5kZXIgYW5kIGRlbGV0ZSBhbGwgY29waWVzLgoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJ bnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1755889AbcGHQ4S (ORCPT ); Fri, 8 Jul 2016 12:56:18 -0400 Received: from mga11.intel.com ([192.55.52.93]:62531 "EHLO mga11.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1755163AbcGHQ4F convert rfc822-to-8bit (ORCPT ); Fri, 8 Jul 2016 12:56:05 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.28,330,1464678000"; d="scan'208";a="1003314308" Date: Fri, 8 Jul 2016 19:56:00 +0300 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= To: James Bottomley Cc: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= , intel-gfx , linux-kernel , dri-devel , Rodrigo Vivi Subject: Re: [Intel-gfx] Bad flicker on skylake HQD due to code in the 4.7 merge window Message-ID: <20160708165600.GU4329@intel.com> References: <1466204815.2199.2.camel@HansenPartnership.com> <1466373202.2280.3.camel@HansenPartnership.com> <8737o89ti7.fsf@intel.com> <1466517195.2291.2.camel@HansenPartnership.com> <20160621154434.GY4329@intel.com> <20160707161425.GO4329@intel.com> <1467910504.2322.9.camel@HansenPartnership.com> <1467919176.2322.38.camel@HansenPartnership.com> <20160708101934.GQ4329@intel.com> <1467989309.2245.2.camel@HansenPartnership.com> MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: <1467989309.2245.2.camel@HansenPartnership.com> User-Agent: Mutt/1.5.24 (2015-08-30) Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Jul 08, 2016 at 07:48:29AM -0700, James Bottomley wrote: > On Fri, 2016-07-08 at 13:19 +0300, Ville Syrjälä wrote: > > On Thu, Jul 07, 2016 at 12:19:36PM -0700, James Bottomley wrote: > > > On Thu, 2016-07-07 at 09:55 -0700, James Bottomley wrote: > > > > On Thu, 2016-07-07 at 19:14 +0300, Ville Syrjälä wrote: > > > > > On Tue, Jun 21, 2016 at 06:44:34PM +0300, Ville Syrjälä wrote: > > > > > > On Tue, Jun 21, 2016 at 09:53:15AM -0400, James Bottomley > > > > > > wrote: > > > > > > > On Mon, 2016-06-20 at 11:03 +0300, Jani Nikula wrote: > > > > > > > > Cc: Ville > > > > > > > > > > > > > > > > On Mon, 20 Jun 2016, James Bottomley < > > > > > > > > James.Bottomley@HansenPartnership.com> wrote: > > > > > > > > > OK, my candidate bad commit is this one: > > > > > > > > > > > > > > > > > > commit a05628195a0d9f3173dd9aa76f482aef692e46ee > > > > > > > > > Author: Ville Syrjälä > > > > > > > > > Date: Mon Apr 11 10:23:51 2016 +0300 > > > > > > > > > > > > > > > > > > drm/i915: Get panel_type from OpRegion panel > > > > > > > > > details > > > > > > > > > > > > > > > > > > After being more careful about waiting to identify > > > > > > > > > flicker, > > > > > > > > > this one seems to be the one the bisect finds. I'm now > > > > > > > > > running v4.7-rc3 with this one reverted and am > > > > > > > > > currently > > > > > > > > > seeing no flicker problems. It is, however, early > > > > > > > > > days > > > > > > > > > because the flicker can hide for long periods, so I 'll > > > > > > > > > wait > > > > > > > > > until Monday evening and a few reboots before declaring > > > > > > > > > victory. > > > > > > > > > > > > > > > > If that turns out to be the bad commit, it doesn't really > > > > > > > > surprise me, and that in itself is depressing. > > > > > > > > > > > > > > As far as I can tell, after running for a day with this > > > > > > > reverted, > > > > > > > this is the problem. The flicker hasn't appeared with it > > > > > > > reverted. It's pretty noticeable with this commit > > > > > > > included. > > > > > > > > > > > > Hmm. The only difference I can see is low vs. normal vswing. > > > > > > Panel > > > > > > 0 has low, panel 2 has normal. So either the VBT or opregion > > > > > > is > > > > > > telling utter lies, or there's some other bug in our low > > > > > > vswing > > > > > > support. > > > > > > > > > > I did a quick once over of out DDI vswing stuff and didn't find > > > > > anything too serious. There were some buglets in the iboost > > > > > handling, > > > > > but I'm not very hopeful that fixing those would help with your > > > > > machine. > > > > > > > > > > Here's a branch anyway in case you want to give it a go: > > > > > git://github.com/vsyrjala/linux.git ddi_iboost_fixes > > > > > > > > > > Actually, I think the only patch in there that might make a > > > > > difference is 15d887855180 ("drm/i915: Fix iboost setting for > > > > > DDI > > > > > with 4 lanes on SKL") > > > > > > > > Running with it now (the entire branch). So far it looks OK, but > > > > I'll give it a couple of days to see if anything manifests before > > > > declaring victory. > > > > > > Bad news, I'm afraid: after a couple of hours of run time, there is > > > now > > > noticeable flicker on the display, so although the iboost fixes may > > > have lessened it, it's still present. > > > > Oh well, I suspected as much. Which BIOS version did you have > > exactly? > > As mentioned upthread, now 1.4.3 since skylake microcode was > potentially implicated in the problem: > > http://mid.gmane.org/1466179729.2271.33.camel@HansenPartnership.com > > > If I'm reading the Dell website correctly there's a new one (1.4.4) > > released on Jun 30, which is after you reported the issue. Might be > > I'm reading the wrong thing though. Can you double check this? > > New bios doesn't change the microcode: > > [ 2.390172] microcode: CPU0 sig=0x406e3, pf=0x80, revision=0x8a I was hoping it would have fixed the VBT, but seems that was not the case if the symptoms didn't change :( -- Ville Syrjälä Intel OTC --------------------------------------------------------------------- Intel Finland Oy Registered Address: PL 281, 00181 Helsinki Business Identity Code: 0357606 - 4 Domiciled in Helsinki This e-mail and any attachments may contain confidential material for the sole use of the intended recipient(s). Any review or distribution by others is strictly prohibited. If you are not the intended recipient, please contact the sender and delete all copies.