From: Ingo Molnar <mingo@kernel.org>
To: Kees Cook <keescook@chromium.org>
Cc: Michal Marek <mmarek@suse.com>,
Andrew Morton <akpm@linux-foundation.org>,
x86@kernel.org, linux-kernel@vger.kernel.org,
linux-kbuild@vger.kernel.org
Subject: Re: [PATCH] kbuild: Abort build on bad stack protector flag
Date: Sat, 9 Jul 2016 14:03:02 +0200 [thread overview]
Message-ID: <20160709120302.GB26253@gmail.com> (raw)
In-Reply-To: <20160618180800.GA1006@www.outflux.net>
* Kees Cook <keescook@chromium.org> wrote:
> Before, the stack protector flag was sanity checked before .config had
> been reprocessed. This meant the build couldn't be aborted early, and
> only a warning could be emitted followed later by the compiler blowing
> up with an unknown flag. This has caused a lot of confusion over time,
> so this splits the flag selection from sanity checking and performs the
> sanity checking after the make has been restarted from a reprocessed
> .config, so builds can be aborted as early as possible now.
>
> Additionally moves the x86-specific sanity check to the same location,
> since it suffered from the same warn-then-wait-for-compiler-failure
> problem.
>
> Signed-off-by: Kees Cook <keescook@chromium.org>
> ---
> Makefile | 69 +++++++++++++++++++++++++++++++++----------------------
> arch/x86/Makefile | 8 -------
> 2 files changed, 42 insertions(+), 35 deletions(-)
What's the status of this patch? I can merge it if Michal acks the main Makefile
bits.
Thanks,
Ingo
next prev parent reply other threads:[~2016-07-09 12:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-18 18:08 [PATCH] kbuild: Abort build on bad stack protector flag Kees Cook
2016-07-09 12:03 ` Ingo Molnar [this message]
2016-07-09 16:59 ` Kees Cook
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160709120302.GB26253@gmail.com \
--to=mingo@kernel.org \
--cc=akpm@linux-foundation.org \
--cc=keescook@chromium.org \
--cc=linux-kbuild@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mmarek@suse.com \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.