All of lore.kernel.org
 help / color / mirror / Atom feed
From: Ingo Molnar <mingo@kernel.org>
To: Baoquan He <bhe@redhat.com>
Cc: peterz@infradead.org, hpa@zytor.com, keescook@chromium.org,
	xiaolong.ye@intel.com, linux-kernel@vger.kernel.org,
	tglx@linutronix.de, torvalds@linux-foundation.org,
	linux-tip-commits@vger.kernel.org
Subject: Re: [tip:x86/boot] x86/KASLR: Fix boot crash with certain memory configurations
Date: Sun, 10 Jul 2016 13:24:27 +0200	[thread overview]
Message-ID: <20160710112427.GA16729@gmail.com> (raw)
In-Reply-To: <20160710090953.GA2512@x1.redhat.com>


* Baoquan He <bhe@redhat.com> wrote:

> Hi Ingo,
> 
> I am sorry the previous post didn't contain formal patch log. I made a new one 
> as below. The boot crash could not only happen with certain memory. Because of 
> this code bug the regions which need be avoided like the zipped kernel with its 
> unzipping running code, initrd, kernel command line could be corrupted if 
> mem_avoid_overlap() can't find the overlap region with the lowest address. But 
> it's very lucky that Xiaolong's system which has only 300M memory can always 
> reproduce it. I checked the boog log and found on his system no any other slot 
> can be chosen except for the original one. If we have a system with large memory 
> it may not be easy to hit it, at least with low probability since there are many 
> candidate slots.

So if it's just a better changelog that what I wrote I wouldn't rebase the commit: 
there's other commits on top of the fix meanwhile. Should a rebase become 
necessary at a later point I'll update it with your extended changelog.

Thanks,

	Ingo

  reply	other threads:[~2016-07-10 11:24 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <tip-6daa2ec0b3e3808c55329d12de3c157cf38b17b0@git.kernel.org>
2016-07-10  9:09 ` [tip:x86/boot] x86/KASLR: Fix boot crash with certain memory configurations Baoquan He
2016-07-10 11:24   ` Ingo Molnar [this message]
2016-07-10 15:16     ` Baoquan He

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160710112427.GA16729@gmail.com \
    --to=mingo@kernel.org \
    --cc=bhe@redhat.com \
    --cc=hpa@zytor.com \
    --cc=keescook@chromium.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-tip-commits@vger.kernel.org \
    --cc=peterz@infradead.org \
    --cc=tglx@linutronix.de \
    --cc=torvalds@linux-foundation.org \
    --cc=xiaolong.ye@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.