From: Steffen Klassert <steffen.klassert@secunet.com>
To: Herbert Xu <herbert@gondor.apana.org.au>
Cc: David Miller <davem@davemloft.net>, <vegard.nossum@oracle.com>,
<nicolas.dichtel@6wind.com>, <netdev@vger.kernel.org>
Subject: Re: [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler
Date: Sun, 10 Jul 2016 14:21:13 +0200 [thread overview]
Message-ID: <20160710122113.GA24022@gauss.secunet.com> (raw)
In-Reply-To: <20160706022729.GA12971@gondor.apana.org.au>
On Wed, Jul 06, 2016 at 10:27:29AM +0800, Herbert Xu wrote:
> On Tue, Jul 05, 2016 at 12:13:03PM -0700, David Miller wrote:
> > From: Vegard Nossum <vegard.nossum@oracle.com>
> > Date: Tue, 5 Jul 2016 10:18:08 +0200
> >
> > > If we hit any of the error conditions inside xfrm_dump_sa(), then
> > > xfrm_state_walk_init() never gets called. However, we still call
> > > xfrm_state_walk_done() from xfrm_dump_sa_done(), which will crash
> > > because the state walk was never initialized properly.
> > >
> > > We can fix this by setting cb->args[0] only after we've processed the
> > > first element and checking this before calling xfrm_state_walk_done().
> > >
> > > Fixes: d3623099d3 ("ipsec: add support of limited SA dump")
> > > Cc: Nicolas Dichtel <nicolas.dichtel@6wind.com>
> > > Cc: Steffen Klassert <steffen.klassert@secunet.com>
> > > Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
> >
> > I assume Steffen will pick this up.
>
> I think Steffen said that he is going to be on vacation for two
> weeks starting this week.
Right, I'll take care of it as soon as I'm back.
next prev parent reply other threads:[~2016-07-10 12:21 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-05 8:18 [PATCH] xfrm: fix crash in XFRM_MSG_GETSA netlink handler Vegard Nossum
2016-07-05 10:14 ` Nicolas Dichtel
2016-07-05 19:13 ` David Miller
2016-07-06 2:27 ` Herbert Xu
2016-07-10 12:21 ` Steffen Klassert [this message]
2016-07-19 7:35 ` Steffen Klassert
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160710122113.GA24022@gauss.secunet.com \
--to=steffen.klassert@secunet.com \
--cc=davem@davemloft.net \
--cc=herbert@gondor.apana.org.au \
--cc=netdev@vger.kernel.org \
--cc=nicolas.dichtel@6wind.com \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.