From mboxrd@z Thu Jan  1 00:00:00 1970
From: Yuanhan Liu <yuanhan.liu@linux.intel.com>
Subject: Re: [PATCH] examples/vhost: fix failure without hints
Date: Mon, 11 Jul 2016 10:07:57 +0800
Message-ID: <20160711020757.GU26521@yliu-dev.sh.intel.com>
References: <1467363031-106737-1-git-send-email-jianfeng.tan@intel.com>
 <20160704030013.GU2831@yliu-dev.sh.intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Cc: dev@dpdk.org, huawei.xie@intel.com
To: Jianfeng Tan <jianfeng.tan@intel.com>
Return-path: <dev-bounces@dpdk.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id 42B12214A
 for <dev@dpdk.org>; Mon, 11 Jul 2016 04:05:36 +0200 (CEST)
Content-Disposition: inline
In-Reply-To: <20160704030013.GU2831@yliu-dev.sh.intel.com>
List-Id: patches and discussions about DPDK <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On Mon, Jul 04, 2016 at 11:00:13AM +0800, Yuanhan Liu wrote:
> On Fri, Jul 01, 2016 at 08:50:31AM +0000, Jianfeng Tan wrote:
> > When the specified cores and memory lie on different numa socket with
> > physical NIC, vhost fails to set up rx queue, and exits without any
> > hints. This could leads to confusion of users.
> > 
> > This patch fixes it by adding some error messages when calling ether
> > APIs returns errors.
> > 
> > Fixes: 4796ad63ba1f ("examples/vhost: import userspace vhost application")
> 
> I will not call it a "fix", instead, it's an "enhancement" to me.
> 
> > Reported-by: Yulong Pei <yulong.pei@intel.com>
> 
> And since it's not a bug, it might be "Suggested-by: ...".

Applied to dpdk-next-virtio, with some commit log rewords.

Thanks.

	--yliu