All of lore.kernel.org
 help / color / mirror / Atom feed
From: Theodore Ts'o <tytso@mit.edu>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: "Darrick J. Wong" <darrick.wong@oracle.com>,
	Ext4 Developers List <linux-ext4@vger.kernel.org>,
	linux-fsdevel@vger.kernel.org
Subject: Re: [RFC PATCH] ext4: validate number of meta clusters in group
Date: Sun, 10 Jul 2016 22:51:53 -0400	[thread overview]
Message-ID: <20160711025153.GO26097@thunk.org> (raw)
In-Reply-To: <577EB740.10502@oracle.com>

On Thu, Jul 07, 2016 at 10:10:40PM +0200, Vegard Nossum wrote:
> 
> I ran into a second problem (this time it was num_clusters_in_group()
> returning a bogus value) with the same symptoms (random memory
> corruptions), the new attached patch fixes both problems by checking the
> values at mount time.

Can you give me a dumpe2fs -h of a file system that is causing
num_clusters_in_group() to be bogus?

I want to make sure I'm checking that correct base values, insteda of
doing a brute force loop over all of the block groups and calling
ext4_num_clusters_in_group() and ext4_num_base_meta_clusters() for all
block groups.

Thanks!!

					- Ted

  reply	other threads:[~2016-07-11  2:52 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-01 13:06 [RFC PATCH] ext4: validate number of meta clusters in group Vegard Nossum
2016-07-02  7:49 ` Darrick J. Wong
2016-07-06  0:03   ` [PATCH] ext4: validate s_reserved_gdt_blocks on mount Theodore Ts'o
2016-07-07 20:10   ` [RFC PATCH] ext4: validate number of meta clusters in group Vegard Nossum
2016-07-11  2:51     ` Theodore Ts'o [this message]
2016-07-11 18:50       ` Vegard Nossum
2016-07-11 20:30         ` Vegard Nossum

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160711025153.GO26097@thunk.org \
    --to=tytso@mit.edu \
    --cc=darrick.wong@oracle.com \
    --cc=linux-ext4@vger.kernel.org \
    --cc=linux-fsdevel@vger.kernel.org \
    --cc=vegard.nossum@oracle.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.