From: Mark Rutland <mark.rutland@arm.com>
To: Jiri Olsa <jolsa@redhat.com>
Cc: linux-kernel@vger.kernel.org, acme@kernel.org,
adrian.hunter@intel.com, alexander.shishkin@linux.intel.com,
hekuang@huawei.com, jolsa@kernel.org, kan.liang@intel.com,
mingo@redhat.com, peterz@infradead.org, wangnan0@huawei.com
Subject: Re: [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel permits
Date: Mon, 11 Jul 2016 11:50:23 +0100 [thread overview]
Message-ID: <20160711105022.GE31221@leverpostej> (raw)
In-Reply-To: <20160708075514.GA26532@krava>
On Fri, Jul 08, 2016 at 09:55:14AM +0200, Jiri Olsa wrote:
> On Thu, Jul 07, 2016 at 05:04:34PM +0100, Mark Rutland wrote:
> > + if (!cpu_map__has(evsel->cpus, evlist_cpu))
> > + continue;
> > +
> > + cpu = cpu_map__idx(evsel->cpus, evlist_cpu);
>
> you basicaly call cpu_map__idx twice in here,
> I think it might be better call it just once
> and check the cpu for -1
Sure, I can change the patch to do that.
Mark.
prev parent reply other threads:[~2016-07-11 10:50 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-07 16:04 [RFC PATCH 0/3] perf tools: play nicely with CPU PMU cpumasks Mark Rutland
2016-07-07 16:04 ` [RFC PATCH 1/3] perf stat: balance opening and reading events Mark Rutland
2016-07-07 16:04 ` [RFC PATCH 2/3] perf: util: Add more cpu_map helpers Mark Rutland
2016-07-07 16:04 ` [RFC PATCH 3/3] perf: util: only open events on CPUs an evsel permits Mark Rutland
2016-07-08 7:55 ` Jiri Olsa
2016-07-11 10:50 ` Mark Rutland [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711105022.GE31221@leverpostej \
--to=mark.rutland@arm.com \
--cc=acme@kernel.org \
--cc=adrian.hunter@intel.com \
--cc=alexander.shishkin@linux.intel.com \
--cc=hekuang@huawei.com \
--cc=jolsa@kernel.org \
--cc=jolsa@redhat.com \
--cc=kan.liang@intel.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=peterz@infradead.org \
--cc=wangnan0@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.