From: Anna-Maria Gleixner <anna-maria@linutronix.de>
To: LKML <linux-kernel@vger.kernel.org>
Cc: Peter Zijlstra <peterz@infradead.org>,
Ingo Molnar <mingo@kernel.org>,
Anna-Maria Gleixner <anna-maria@linutronix.de>
Subject: [patch 30/66] KVM: x86: Remove superfluous SMP function call
Date: Mon, 11 Jul 2016 12:28:44 -0000 [thread overview]
Message-ID: <20160711122533.149447338@linutronix.de> (raw)
In-Reply-To: 20160711122450.923603742@linutronix.de
[-- Attachment #1: KVM--x86--Remove-superfluous-SMP-function-call.patch --]
[-- Type: text/plain, Size: 1156 bytes --]
From: Anna-Maria Gleixner <anna-maria@linutronix.de>
Since commit 1cf4f629d9d2 ("cpu/hotplug: Move online calls to hotplugged cpu")
the CPU_ONLINE and CPU_DOWN_PREPARE notifiers are always run on the hot
plugged CPU, and as of commit 3b9d6da67e11 ("cpu/hotplug: Fix rollback during
error-out in __cpu_disable()") the CPU_DOWN_FAILED notifier also runs on the
hot plugged CPU. This patch converts the SMP functional calls into direct
calls.
smp_function_call_single() executes the function with interrupts
disabled. This calling convention is not preserved because there is no reason
to do so.
Signed-off-by: Anna-Maria Gleixner <anna-maria@linutronix.de>
---
arch/x86/kvm/x86.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
--- a/arch/x86/kvm/x86.c
+++ b/arch/x86/kvm/x86.c
@@ -5667,10 +5667,10 @@ static int kvmclock_cpu_notifier(struct
switch (action) {
case CPU_ONLINE:
case CPU_DOWN_FAILED:
- smp_call_function_single(cpu, tsc_khz_changed, NULL, 1);
+ tsc_khz_changed(NULL);
break;
case CPU_DOWN_PREPARE:
- smp_call_function_single(cpu, tsc_bad, NULL, 1);
+ tsc_bad(NULL);
break;
}
return NOTIFY_OK;
next prev parent reply other threads:[~2016-07-11 12:42 UTC|newest]
Thread overview: 126+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-11 12:28 [patch 00/66] cpuhotplug: Convert all priority notifiers to the state machine Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 01/66] x86/vdso: Convert to hotplug " Anna-Maria Gleixner
2016-07-11 18:50 ` Andy Lutomirski
2016-07-11 12:28 ` [patch 03/66] irqchip/gicv3: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 02/66] irqchip/gic: " Anna-Maria Gleixner
2016-07-11 14:34 ` Ingo Molnar
2016-07-11 14:46 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 04/66] irqchip/hip04: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 06/66] irqchip/bcm2836: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 05/66] irqchip/armada-370-xp: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 07/66] ARM: mvebu: " Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 08/66] perf: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 09/66] perf/x86: Convert the core to the " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 10/66] perf/x86/intel/uncore: Convert to " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 12/66] perf/x86/amd/ibs: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 11/66] perf/x86/amd/uncore: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 13/66] perf/x86/intel/rapl: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 14/66] perf/x86/intel/cqm: Convert Intel CQM " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 15/66] perf/x86/intel/cstate: Convert Intel CSTATE " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 16/66] blackfin: perf: Convert hotplug notifier to " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 17/66] powerpc: perf: Convert book3s notifier to state machine callbacks Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 18/66] s390: perf: Convert the hotplug notifier to state machine callbacks (Counter) Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 19/66] s390: perf: Convert the hotplug notifier to state machine callbacks (Sampling) Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 20/66] sh: perf: Convert the hotplug notifiers to state machine callbacks Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 21/66] bus: arm-cci: convert to hotplug statemachine Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 23/66] xtensa: perf: Convert the hotplug notifier to state machine callbacks Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 22/66] bus: arm-ccn: convert to hotplug statemachine Anna-Maria Gleixner
2016-07-12 10:05 ` Pawel Moll
2016-07-12 11:16 ` Pawel Moll
2016-07-12 11:21 ` Sebastian Andrzej Siewior
2016-07-11 12:28 ` [patch 24/66] perf/x86/amd/power: Change hotplug notifier to a symmetric structure Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 25/66] perf/x86/amd/power: Convert the hotplug notifier to state machine Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 27/66] workqueue: Convert to state machine callbacks Anna-Maria Gleixner
2016-07-11 14:38 ` Ingo Molnar
2016-07-11 14:52 ` Anna-Maria Gleixner
2016-07-12 14:39 ` Tejun Heo
2016-07-11 12:28 ` [patch 26/66] perf: Remove perf cpu notifier code Anna-Maria Gleixner
2016-07-11 14:36 ` Ingo Molnar
2016-07-11 14:50 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 28/66] x86/hpet: Convert to hotplug state machine Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 29/66] powerpc: numa: " Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner [this message]
2016-07-11 12:28 ` [patch 31/66] x86/kvm/kvmclock: " Anna-Maria Gleixner
2016-07-11 14:11 ` Anna-Maria Gleixner
2016-07-11 14:41 ` Paolo Bonzini
2016-07-11 12:28 ` [patch 33/66] arm: Convert VFP hotplug notifiers to " Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 32/66] x86/apb_timer: Convert to hotplug " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 34/66] arm: perf: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 35/66] virt: Convert kvm hotplug to " Anna-Maria Gleixner
2016-07-11 14:41 ` Paolo Bonzini
2016-07-11 12:28 ` [patch 36/66] ACPI/processor: avoid STARTING/DYING actions in a more logical way Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 37/66] clocksource/arm_arch_timer: Convert to hotplug state machine Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 38/66] clocksource/arm_global_timer: " Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 39/66] clocksource/dummy_timer: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 40/66] clocksource/exynos_mct: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 41/66] clocksource/metag: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 42/66] clocksource/qcom-timer: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 43/66] clocksource/armada-370-xp: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 44/66] clocksource/atlas7: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 45/66] clocksource/mips-gic: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 47/66] arm: kvm: vgic: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 46/66] leds: trigger: cpu: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 48/66] arm: kvm: arch_timer: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 49/66] metag: perf: " Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 51/66] arm: twd: " Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 50/66] arm: l2c: " Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:28 ` [patch 52/66] arm: xen: " Anna-Maria Gleixner
2016-07-11 12:28 ` Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 53/66] MIPS: Loongson-3: Convert oprofile " Anna-Maria Gleixner
2016-07-11 15:57 ` Ralf Baechle
2016-07-11 12:29 ` [patch 55/66] hwtracing: coresight-etm4x: Convert " Anna-Maria Gleixner
2016-07-11 12:29 ` Anna-Maria Gleixner
2016-07-12 15:21 ` Mathieu Poirier
2016-07-12 15:21 ` Mathieu Poirier
2016-07-11 12:29 ` [patch 54/66] hwtracing: coresight-etm3x: " Anna-Maria Gleixner
2016-07-11 12:29 ` Anna-Maria Gleixner
2016-07-12 15:19 ` Mathieu Poirier
2016-07-12 15:19 ` Mathieu Poirier
2016-07-11 12:29 ` [patch 56/66] arm64: armv8 deprecated: " Anna-Maria Gleixner
2016-07-11 12:29 ` Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 58/66] x86/tboot: " Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 57/66] ARC/time: " Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 59/66] rcu: Convert rcutree " Anna-Maria Gleixner
2016-07-11 18:38 ` Paul E. McKenney
2016-07-12 10:57 ` Anna-Maria Gleixner
2016-07-12 14:23 ` Paul E. McKenney
2016-08-18 17:35 ` Sebastian Andrzej Siewior
2016-08-18 18:30 ` Paul E. McKenney
2016-08-19 20:12 ` Sebastian Andrzej Siewior
2016-08-19 21:14 ` Paul E. McKenney
2016-07-11 12:29 ` [patch 61/66] timers: Convert " Anna-Maria Gleixner
[not found] ` <20160711122535.775201614-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2016-07-25 14:56 ` Jon Hunter
2016-07-25 14:56 ` Jon Hunter
[not found] ` <7d37714e-b072-ee90-f14f-364f4fd01f0d-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-07-25 15:35 ` rcochran-hfZtesqFncYOwBW4kG4KsQ
2016-07-25 15:35 ` rcochran
[not found] ` <20160725153543.GB10939-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2016-07-25 20:46 ` rcochran-hfZtesqFncYOwBW4kG4KsQ
2016-07-25 20:46 ` rcochran
[not found] ` <20160725204648.GA22830-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2016-07-26 9:23 ` Jon Hunter
2016-07-26 9:23 ` Jon Hunter
2016-07-26 9:20 ` Jon Hunter
2016-07-26 9:20 ` Jon Hunter
2016-07-26 14:15 ` Thomas Gleixner
2016-07-26 18:20 ` Jon Hunter
2016-07-26 18:20 ` Jon Hunter
[not found] ` <0b5a7bb5-6670-606b-e33d-63cd8b0fcedd-DDmLM1+adcrQT0dZR+AlfA@public.gmane.org>
2016-07-26 14:40 ` rcochran-hfZtesqFncYOwBW4kG4KsQ
2016-07-26 14:40 ` rcochran
2016-07-26 18:22 ` Jon Hunter
2016-07-26 18:22 ` Jon Hunter
2016-07-26 15:42 ` rcochran-hfZtesqFncYOwBW4kG4KsQ
2016-07-26 15:42 ` rcochran
[not found] ` <20160726154227.GC23707-hfZtesqFncYOwBW4kG4KsQ@public.gmane.org>
2016-07-26 18:16 ` Jon Hunter
2016-07-26 18:16 ` Jon Hunter
2016-07-11 12:29 ` [patch 60/66] hrtimer: " Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 62/66] profile: " Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 63/66] x86/x2apic: Convert to CPU " Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 64/66] smp: Convert core to " Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 65/66] KVM: arm/arm64: vgic-new: Convert " Anna-Maria Gleixner
2016-07-11 12:29 ` [patch 66/66] cpuhotplug: Remove CPU_STARTING and CPU_DYING notifier Anna-Maria Gleixner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160711122533.149447338@linutronix.de \
--to=anna-maria@linutronix.de \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=peterz@infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.