From: Al Viro <viro@ZenIV.linux.org.uk>
To: David Chen <david.chen@osnexus.com>
Cc: lkml <linux-kernel@vger.kernel.org>,
linux-fsdevel@vger.kernel.org, stable@vger.kernel.org
Subject: Re: [PATCH] vfs: check i_count under lock in evict_inodes
Date: Tue, 12 Jul 2016 06:26:24 +0100 [thread overview]
Message-ID: <20160712052624.GC14480@ZenIV.linux.org.uk> (raw)
In-Reply-To: <CAK1sfubpLBv3P5ttpuq1z+EyNGHFiiMEVLSCv5HoQ51f_pFHig@mail.gmail.com>
On Mon, Jul 11, 2016 at 06:31:57PM -0700, David Chen wrote:
> Hi Al,
>
> I'm not sure about the in-tree fs, but in zfsonlinux, it would offload
> iput to a thread, so this would happen there. And it would wait for
> the thread in put_super(), so that part is not a problem...
*shrug* I hadn't looked (and won't look) at zfs glue, but I'd suggest
trying something along the line of stopping that thread in the beginning
of your ->kill_sb() (having told the sucker to stop offloading, of course)
and only then calling generic_shutdown_super()...
prev parent reply other threads:[~2016-07-12 5:26 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 0:15 [PATCH] vfs: check i_count under lock in evict_inodes Chunwei Chen
2016-07-12 0:46 ` Al Viro
2016-07-12 1:31 ` David Chen
2016-07-12 1:40 ` Christoph Hellwig
2016-07-12 5:26 ` Al Viro [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712052624.GC14480@ZenIV.linux.org.uk \
--to=viro@zeniv.linux.org.uk \
--cc=david.chen@osnexus.com \
--cc=linux-fsdevel@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=stable@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.