From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [PATCH v2 16/17] x86/insn: remove pcommit Date: Tue, 12 Jul 2016 16:57:57 +0200 Message-ID: <20160712145757.GV30909@twins.programming.kicks-ass.net> References: <146812106839.32932.2870621200867047059.stgit@dwillia2-desk3.amr.corp.intel.com> <146812115425.32932.3314855641604340233.stgit@dwillia2-desk3.amr.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Content-Disposition: inline In-Reply-To: <146812115425.32932.3314855641604340233.stgit-p8uTFz9XbKj2zm6wflaqv1nYeNYlB/vhral2JQCrhuEAvxtiuMwx3w@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linux-nvdimm-bounces-hn68Rpc1hR1g9hUCZPvPmw@public.gmane.org Sender: "Linux-nvdimm" To: Dan Williams Cc: Xiao Guangrong , Alexander Shishkin , linux-nvdimm-y27Ovi1pjclAfugRpC6u6w@public.gmane.org, x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Arnaldo Carvalho de Melo , Adrian Hunter , linux-acpi-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Ingo Molnar , Andy Lutomirski , Josh Poimboeuf , linux-fsdevel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, Thomas Gleixner , Borislav Petkov , "H. Peter Anvin" , hch-jcswGhMUV9g@public.gmane.org List-Id: linux-acpi@vger.kernel.org On Sat, Jul 09, 2016 at 08:25:54PM -0700, Dan Williams wrote: > The pcommit instruction is being deprecated in favor of either ADR > (asynchronous DRAM refresh: flush-on-power-fail) at the platform level, or > posted-write-queue flush addresses as defined by the ACPI 6.x NFIT (NVDIMM > Firmware Interface Table). > arch/x86/include/asm/cpufeatures.h | 1 > arch/x86/include/asm/special_insns.h | 46 -------------------- > arch/x86/lib/x86-opcode-map.txt | 2 - > tools/objtool/arch/x86/insn/x86-opcode-map.txt | 2 - > tools/perf/arch/x86/tests/insn-x86-dat-32.c | 2 - > tools/perf/arch/x86/tests/insn-x86-dat-64.c | 2 - > tools/perf/arch/x86/tests/insn-x86-dat-src.c | 4 -- Just deprecated, or is it completely eradicated, removed from history, will never ever happen and we'll reissue the opcode for something else? Because if its only deprecated then removing it from the instruction decoders seems wrong, old binaries might still contain the opcode. From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Tue, 12 Jul 2016 16:57:57 +0200 From: Peter Zijlstra To: Dan Williams Cc: linux-nvdimm@ml01.01.org, Xiao Guangrong , Josh Poimboeuf , linux-acpi@vger.kernel.org, linux-kernel@vger.kernel.org, x86@kernel.org, Adrian Hunter , Arnaldo Carvalho de Melo , hch@lst.de, Alexander Shishkin , Ingo Molnar , Andy Lutomirski , "H. Peter Anvin" , linux-fsdevel@vger.kernel.org, Thomas Gleixner , Borislav Petkov , Ross Zwisler Subject: Re: [PATCH v2 16/17] x86/insn: remove pcommit Message-ID: <20160712145757.GV30909@twins.programming.kicks-ass.net> References: <146812106839.32932.2870621200867047059.stgit@dwillia2-desk3.amr.corp.intel.com> <146812115425.32932.3314855641604340233.stgit@dwillia2-desk3.amr.corp.intel.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <146812115425.32932.3314855641604340233.stgit@dwillia2-desk3.amr.corp.intel.com> Sender: linux-kernel-owner@vger.kernel.org List-ID: On Sat, Jul 09, 2016 at 08:25:54PM -0700, Dan Williams wrote: > The pcommit instruction is being deprecated in favor of either ADR > (asynchronous DRAM refresh: flush-on-power-fail) at the platform level, or > posted-write-queue flush addresses as defined by the ACPI 6.x NFIT (NVDIMM > Firmware Interface Table). > arch/x86/include/asm/cpufeatures.h | 1 > arch/x86/include/asm/special_insns.h | 46 -------------------- > arch/x86/lib/x86-opcode-map.txt | 2 - > tools/objtool/arch/x86/insn/x86-opcode-map.txt | 2 - > tools/perf/arch/x86/tests/insn-x86-dat-32.c | 2 - > tools/perf/arch/x86/tests/insn-x86-dat-64.c | 2 - > tools/perf/arch/x86/tests/insn-x86-dat-src.c | 4 -- Just deprecated, or is it completely eradicated, removed from history, will never ever happen and we'll reissue the opcode for something else? Because if its only deprecated then removing it from the instruction decoders seems wrong, old binaries might still contain the opcode.