From: Bjorn Andersson <bjorn.andersson@linaro.org>
To: John Stultz <john.stultz@linaro.org>
Cc: lkml <linux-kernel@vger.kernel.org>,
Rob Herring <robh+dt@kernel.org>,
Andy Gross <agross@codeaurora.org>,
Stephen Boyd <stephen.boyd@linaro.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] device-tree: nexus7: Set phy mode to otg instead of host
Date: Tue, 12 Jul 2016 11:36:28 -0700 [thread overview]
Message-ID: <20160712183628.GF23833@tuxbot> (raw)
In-Reply-To: <1467437605-11691-1-git-send-email-john.stultz@linaro.org>
On Fri 01 Jul 22:33 PDT 2016, John Stultz wrote:
> In order to have the usb phy work in gadget mode, override
> the default host mode with otg mode.
>
> This allows gadget mode to work w/o any hacks to the dtsi file.
>
> Cc: Rob Herring <robh+dt@kernel.org>
> Cc: Andy Gross <agross@codeaurora.org>
> Cc: Bjorn Andersson <bjorn.andersson@linaro.org>
> Cc: Stephen Boyd <stephen.boyd@linaro.org>
> Cc: linux-arm-msm@vger.kernel.org
> Cc: devicetree@vger.kernel.org
> Signed-off-by: John Stultz <john.stultz@linaro.org>
> ---
> arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> index 7b05f07..94e9cbb 100644
> --- a/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> +++ b/arch/arm/boot/dts/qcom-apq8064-asus-nexus7-flo.dts
> @@ -253,6 +253,7 @@
> vddcx-supply = <&pm8921_s3>;
> v3p3-supply = <&pm8921_l3>;
> v1p8-supply = <&pm8921_l4>;
> + dr_mode = "otg";
Wouldn't this be the standard case for the first/primary USB on most
8064s? Looks like both the ifc6410 and sd600eval has OTG support on the
micro-usb.
Andy, how about we just change the dtsi instead?
Regards,
Bjorn
prev parent reply other threads:[~2016-07-12 18:36 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-02 5:33 [PATCH] device-tree: nexus7: Set phy mode to otg instead of host John Stultz
2016-07-09 0:11 ` John Stultz
2016-07-12 18:36 ` Bjorn Andersson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160712183628.GF23833@tuxbot \
--to=bjorn.andersson@linaro.org \
--cc=agross@codeaurora.org \
--cc=devicetree@vger.kernel.org \
--cc=john.stultz@linaro.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=stephen.boyd@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.