All of lore.kernel.org
 help / color / mirror / Atom feed
From: Dan Carpenter <dan.carpenter@oracle.com>
To: kernel-janitors@vger.kernel.org
Subject: [bug report] cdrom: Add support for Sega Dreamcast GD-ROM.
Date: Tue, 12 Jul 2016 22:26:44 +0000	[thread overview]
Message-ID: <20160712222643.GA16176@mwanda> (raw)

Hello Adrian McMenamin,

The patch 74ee1a7590b7: "cdrom: Add support for Sega Dreamcast
GD-ROM." from Jan 21, 2008, leads to the following static checker
warning:

	drivers/cdrom/gdrom.c:457 gdrom_getsense()
	warn: was hexadecimal intended '40'

drivers/cdrom/gdrom.c
   456          insw(GDROM_DATA_REG, &sense, sense_command->buflen/2);
   457          if (sense[1] & 40) {

Yeah.  It looks like 0x40 was actually intended.

   458                  pr_info("Drive not ready - command aborted\n");
   459                  goto cleanup_sense;
   460          }
   461          sense_key = sense[1] & 0x0F;
   462          if (sense_key < ARRAY_SIZE(sense_texts))
   463                  pr_info("%s\n", sense_texts[sense_key].text);
   464          else
   465                  pr_err("Unknown sense key: %d\n", sense_key);
   466          if (bufstring) /* return addional sense data */
   467                  memcpy(bufstring, &sense[4], 2);
   468          if (sense_key < 2)
   469                  err = 0;

regards,
dan carpenter

                 reply	other threads:[~2016-07-12 22:26 UTC|newest]

Thread overview: [no followups] expand[flat|nested]  mbox.gz  Atom feed

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160712222643.GA16176@mwanda \
    --to=dan.carpenter@oracle.com \
    --cc=kernel-janitors@vger.kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.