From: Ingo Molnar <mingo@kernel.org>
To: Andy Shevchenko <andriy.shevchenko@linux.intel.com>,
Bjorn Helgaas <bhelgaas@google.com>
Cc: Ingo Molnar <mingo@redhat.com>, "H. Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
linux-kernel@vger.kernel.org, x86@kernel.org
Subject: Re: [PATCH v1 1/1] x86/pci: Use MRFLD abbreviation for Merrifield
Date: Wed, 13 Jul 2016 09:24:35 +0200 [thread overview]
Message-ID: <20160713072435.GE13006@gmail.com> (raw)
In-Reply-To: <1468321462-136016-1-git-send-email-andriy.shevchenko@linux.intel.com>
Bjorn, we already have a few incidental changes to arch/x86/pci/intel_mid_pci.c
pending in the tip:x86/platform tree:
e99a0745bdf8 x86/pci, x86/platform/intel_mid_pci: Remove duplicate power off code
5823d0893ec2 x86/platform/intel-mid: Add Power Management Unit driver
bb27570525a7 x86/platform/intel_mid_pci: Rework IRQ0 workaround
mind if I carry this patch too, or would you like to carry it in the PCI tree?
Thanks,
Ingo
* Andy Shevchenko <andriy.shevchenko@linux.intel.com> wrote:
> Everywhere in the kernel the MRFLD is used as abbreviation of Intel Merrifield.
> Do the same in intel_mid_pci.c module.
>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
> ---
> arch/x86/pci/intel_mid_pci.c | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/arch/x86/pci/intel_mid_pci.c b/arch/x86/pci/intel_mid_pci.c
> index 5413d6a..5a18aed 100644
> --- a/arch/x86/pci/intel_mid_pci.c
> +++ b/arch/x86/pci/intel_mid_pci.c
> @@ -36,8 +36,8 @@
> #define PCIE_CAP_OFFSET 0x100
>
> /* Quirks for the listed devices */
> -#define PCI_DEVICE_ID_INTEL_MRFL_MMC 0x1190
> -#define PCI_DEVICE_ID_INTEL_MRFL_HSU 0x1191
> +#define PCI_DEVICE_ID_INTEL_MRFLD_MMC 0x1190
> +#define PCI_DEVICE_ID_INTEL_MRFLD_HSU 0x1191
>
> /* Fixed BAR fields */
> #define PCIE_VNDR_CAP_ID_FIXED_BAR 0x00 /* Fixed BAR (TBD) */
> @@ -229,7 +229,7 @@ static int intel_mid_pci_irq_enable(struct pci_dev *dev)
> * Skip HS UART common registers device since it has
> * IRQ0 assigned and not used by the kernel.
> */
> - if (dev->device == PCI_DEVICE_ID_INTEL_MRFL_HSU)
> + if (dev->device == PCI_DEVICE_ID_INTEL_MRFLD_HSU)
> return -EBUSY;
> /*
> * TNG has IRQ0 assigned to eMMC controller. But there
> @@ -238,7 +238,7 @@ static int intel_mid_pci_irq_enable(struct pci_dev *dev)
> * eMMC gets it. The rest of devices still could be
> * enabled without interrupt line being allocated.
> */
> - if (dev->device != PCI_DEVICE_ID_INTEL_MRFL_MMC)
> + if (dev->device != PCI_DEVICE_ID_INTEL_MRFLD_MMC)
> return 0;
> }
> break;
> --
> 2.8.1
>
next prev parent reply other threads:[~2016-07-13 7:25 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 11:04 [PATCH v1 1/1] x86/pci: Use MRFLD abbreviation for Merrifield Andy Shevchenko
2016-07-13 7:24 ` Ingo Molnar [this message]
2016-07-18 16:40 ` Bjorn Helgaas
2016-07-18 17:29 ` Ingo Molnar
2016-07-13 8:01 ` [tip:x86/platform] " tip-bot for Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713072435.GE13006@gmail.com \
--to=mingo@kernel.org \
--cc=andriy.shevchenko@linux.intel.com \
--cc=bhelgaas@google.com \
--cc=hpa@zytor.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.