From: Wei Liu <wei.liu2@citrix.com>
To: Paulina Szubarczyk <paulinaszubarczyk@gmail.com>
Cc: sstabellini@kernel.org, wei.liu2@citrix.com,
ian.jackson@eu.citrix.com, david.vrabel@citrix.com,
anthony.perard@citrix.com, xen-devel@lists.xenproject.org,
roger.pau@citrix.com
Subject: Re: [PATCH v3 1/2] Interface for grant copy operation in libs.
Date: Wed, 13 Jul 2016 10:12:52 +0100 [thread overview]
Message-ID: <20160713091251.GB31770@citrix.com> (raw)
In-Reply-To: <20160708131846.GV416@citrix.com>
On Fri, Jul 08, 2016 at 02:18:46PM +0100, Wei Liu wrote:
> To unblock Paulina on her series, I would be ok with the cast provided
> there is compile-time check to ensure the user-space structure is
> identical to the ioctl structure.
>
> That would involve:
> 1. Introducing BUILD_BUG_ON, offsetof, alignof to libs/ if they are not
> already available.
I just checked all these.
BUILD_BUG_ON is not there. A patch for it is trivial. I will do that
soon.
offsetof can be found in stddef.h.
alignof is C11 (we require C99), but there is __alignof__ gcc extension,
which clang also supports. We've been using that for quite a long time,
so I don't think we need to do anything about it.
Wei.
_______________________________________________
Xen-devel mailing list
Xen-devel@lists.xen.org
https://lists.xen.org/xen-devel
next prev parent reply other threads:[~2016-07-13 9:12 UTC|newest]
Thread overview: 27+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-06-22 8:38 [PATCH v3 0/2] qemu-qdisk: Implementation of grant copy operation Paulina Szubarczyk
2016-06-22 8:38 ` [PATCH v3 1/2] Interface for grant copy operation in libs Paulina Szubarczyk
2016-06-22 9:37 ` David Vrabel
2016-06-22 9:53 ` Paulina Szubarczyk
2016-06-22 11:24 ` Wei Liu
2016-06-22 14:19 ` Paulina Szubarczyk
2016-06-22 11:21 ` Wei Liu
2016-06-22 12:37 ` David Vrabel
2016-06-22 13:29 ` Wei Liu
2016-06-22 13:52 ` David Vrabel
2016-06-22 14:52 ` Wei Liu
2016-06-22 16:49 ` Wei Liu
2016-07-06 15:49 ` Roger Pau Monné
2016-07-05 16:27 ` George Dunlap
2016-07-08 13:18 ` Wei Liu
2016-07-13 9:12 ` Wei Liu [this message]
2016-06-22 8:38 ` [PATCH v3 2/2] qdisk - hw/block/xen_disk: grant copy implementation Paulina Szubarczyk
2016-07-13 12:34 ` Paulina Szubarczyk
2016-07-14 10:37 ` Wei Liu
2016-07-15 10:28 ` Paulina Szubarczyk
2016-07-15 11:15 ` Wei Liu
2016-07-15 17:11 ` Anthony PERARD
2016-07-19 10:16 ` Paulina Szubarczyk
2016-07-15 16:55 ` Anthony PERARD
2016-07-19 10:51 ` Paulina Szubarczyk
2016-07-19 9:12 ` Roger Pau Monné
2016-07-19 10:12 ` Paulina Szubarczyk
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713091251.GB31770@citrix.com \
--to=wei.liu2@citrix.com \
--cc=anthony.perard@citrix.com \
--cc=david.vrabel@citrix.com \
--cc=ian.jackson@eu.citrix.com \
--cc=paulinaszubarczyk@gmail.com \
--cc=roger.pau@citrix.com \
--cc=sstabellini@kernel.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.