From: Dan Carpenter <dan.carpenter@oracle.com>
To: clombard@linux.vnet.ibm.com
Cc: linuxppc-dev@lists.ozlabs.org
Subject: [bug report] cxl: sysfs support for guests
Date: Wed, 13 Jul 2016 13:13:39 +0300 [thread overview]
Message-ID: <20160713101339.GH29468@mwanda> (raw)
Hello Christophe Lombard,
The patch 4752876c7170: "cxl: sysfs support for guests" from Mar 4,
2016, leads to the following static checker warning:
drivers/misc/cxl/sysfs.c:681 cxl_sysfs_afu_add()
warn: if statement not indented
drivers/misc/cxl/sysfs.c
672 err1:
673 cxl_sysfs_afu_remove(afu);
674 return rc;
675 err:
676 /* reset the eb_len as we havent created the bin attr */
677 afu->eb_len = 0;
678
679 for (i--; i >= 0; i--) {
680 dev_attr = &afu_attrs[i];
681 if (cxl_ops->support_attributes(dev_attr->attr.name,
682 CXL_AFU_ATTRS))
683 device_remove_file(&afu->dev, &afu_attrs[i]);
It's tempting to add a tab but I *think* actually there is a line
missing here? I'm not sure.
684 }
685 return rc;
686 }
regards,
dan carpenter
reply other threads:[~2016-07-13 10:18 UTC|newest]
Thread overview: [no followups] expand[flat|nested] mbox.gz Atom feed
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713101339.GH29468@mwanda \
--to=dan.carpenter@oracle.com \
--cc=clombard@linux.vnet.ibm.com \
--cc=linuxppc-dev@lists.ozlabs.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.