From mboxrd@z Thu Jan 1 00:00:00 1970 From: Marius Vlad Subject: Re: [PATCH] drm/i915: Acquire intel_runtime_pm for HD-Audio registers Date: Wed, 13 Jul 2016 17:01:02 +0300 Message-ID: <20160713140102.GA29187@mcvlad-wk.rb.intel.com> References: <1468058747-31160-1-git-send-email-chris@chris-wilson.co.uk> <87zipnroht.fsf@intel.com> <20160712131650.GU6157@nuc-i3427.alporthouse.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1692600643==" Return-path: Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by gabe.freedesktop.org (Postfix) with ESMTP id 34FD56E70A for ; Wed, 13 Jul 2016 13:56:58 +0000 (UTC) In-Reply-To: <20160712131650.GU6157@nuc-i3427.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , Mika Kuoppala , intel-gfx@lists.freedesktop.org, Takashi Iwai List-Id: intel-gfx@lists.freedesktop.org --===============1692600643== Content-Type: multipart/signed; micalg=pgp-sha1; protocol="application/pgp-signature"; boundary="9jxsPFA5p3P2qPhR" Content-Disposition: inline --9jxsPFA5p3P2qPhR Content-Type: text/plain; charset=us-ascii Content-Disposition: inline Content-Transfer-Encoding: quoted-printable Did try when you submitted the patch...but can't seem to replicate with latest nightly on other SKLs, and currently do not have access on the machine that caused it. On Tue, Jul 12, 2016 at 02:16:50PM +0100, Chris Wilson wrote: > On Tue, Jul 12, 2016 at 04:10:22PM +0300, Mika Kuoppala wrote: > > Chris Wilson writes: > >=20 > > > On Haswell/Broadwell, the HD-Audio block is inside the HDMI/display > > > power well and so the sna-hda audio codec acquires the display power > > > well while it is operational. However, Skylake separates the powerwel= ls > > > again, and so we must remember to acquire the rpm wakeref for ourselv= es > > > whilst tweaking the registers. > > > > > > Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=3D96214 > > > Fixes: 03b135cebc47 "ALSA: hda - remove dependency on i915 power well= for SKL") > > > Signed-off-by: Chris Wilson > >=20 > > Reviewed-by: Mika Kuoppala > >=20 > > > Cc: Libin Yang > > > Cc: Takashi Iwai > > > Cc: Marius Vlad >=20 > Marius, could you provide a tested by? > -Chris >=20 > --=20 > Chris Wilson, Intel Open Source Technology Centre --9jxsPFA5p3P2qPhR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: Digital signature -----BEGIN PGP SIGNATURE----- Version: GnuPG v1 iQEcBAEBAgAGBQJXhkmeAAoJELmLWIAQzyE+wxgH/1/v9tY8otIc/FxbkQxNlxrU 024IDaEFEuf4kSBAyDmVEgGwg00fXNL12wEqy1fbl0bFNHLTdAY01kv+UT5jj+Jh hr6g1ZJonN2kB67sntBYKD14upW0j1vJwimqJ/e02mUVgNA4KaT/34mzGZWPg0S5 57fTtQ1ZlJ887j1mPVcByTe8Weedl4QcWLsG1HrGtiUlBNewhjJKvGaFSlDbY61D l97Gy+LUob1CV+Qzh/tp2oPjV56CR+6oN15xGKGm0ADjZnI4ywS+Mhv/y1VOblWJ /hOFlzxufdY0IJ9GDl88Vfc/WnzJKT5GMlNBCDlUxurOfAGifx1aXr6apMZ2bKY= =mm0O -----END PGP SIGNATURE----- --9jxsPFA5p3P2qPhR-- --===============1692600643== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg== --===============1692600643==--