From: David Weinehall <david.weinehall@linux.intel.com>
To: ville.syrjala@linux.intel.com
Cc: intel-gfx@lists.freedesktop.org
Subject: Re: [PATCH 2/9] drm/i915: Name the "iboost bit"
Date: Wed, 13 Jul 2016 18:31:15 +0300 [thread overview]
Message-ID: <20160713153115.GC3839@boom> (raw)
In-Reply-To: <1468328376-6380-3-git-send-email-ville.syrjala@linux.intel.com>
On Tue, Jul 12, 2016 at 03:59:29PM +0300, ville.syrjala@linux.intel.com wrote:
> From: Ville Syrjälä <ville.syrjala@linux.intel.com>
>
> Give a proper name for the SKL DDI_BUF_TRANS iboost bit.
>
> Cc: David Weinehall <david.weinehall@linux.intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala@linux.intel.com>
Reviewed-by: David Weinehall <david.weinehall@linux.intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 1 +
> drivers/gpu/drm/i915/intel_ddi.c | 2 +-
> 2 files changed, 2 insertions(+), 1 deletion(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index e6f9f05b3a4a..ede4cd3531f8 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -7483,6 +7483,7 @@ enum {
> #define _DDI_BUF_TRANS_A 0x64E00
> #define _DDI_BUF_TRANS_B 0x64E60
> #define DDI_BUF_TRANS_LO(port, i) _MMIO(_PORT(port, _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8)
> +#define DDI_BUF_BALANCE_LEG_ENABLE (1 << 31)
> #define DDI_BUF_TRANS_HI(port, i) _MMIO(_PORT(port, _DDI_BUF_TRANS_A, _DDI_BUF_TRANS_B) + (i) * 8 + 4)
>
> /* Sideband Interface (SBI) is programmed indirectly, via
> diff --git a/drivers/gpu/drm/i915/intel_ddi.c b/drivers/gpu/drm/i915/intel_ddi.c
> index 75354cd9bbab..78e1fdaec86d 100644
> --- a/drivers/gpu/drm/i915/intel_ddi.c
> +++ b/drivers/gpu/drm/i915/intel_ddi.c
> @@ -434,7 +434,7 @@ void intel_prepare_ddi_buffer(struct intel_encoder *encoder)
> /* If we're boosting the current, set bit 31 of trans1 */
> if (dev_priv->vbt.ddi_port_info[port].hdmi_boost_level ||
> dev_priv->vbt.ddi_port_info[port].dp_boost_level)
> - iboost_bit = 1<<31;
> + iboost_bit = DDI_BUF_BALANCE_LEG_ENABLE;
>
> if (WARN_ON(encoder->type == INTEL_OUTPUT_EDP &&
> port != PORT_A && port != PORT_E &&
> --
> 2.7.4
>
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx
next prev parent reply other threads:[~2016-07-13 15:31 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 12:59 [PATCH 0/9] drm/i915: SKL iboost fixes ville.syrjala
2016-07-12 12:59 ` [PATCH 1/9] drm/i915: Fix iboost setting for DDI with 4 lanes on SKL ville.syrjala
2016-07-13 15:31 ` David Weinehall
2016-07-12 12:59 ` [PATCH 2/9] drm/i915: Name the "iboost bit" ville.syrjala
2016-07-13 15:31 ` David Weinehall [this message]
2016-07-12 12:59 ` [PATCH 3/9] drm/i915: Program iboost settings for HDMI/DVI on SKL ville.syrjala
2016-07-13 15:30 ` David Weinehall
2016-07-12 12:59 ` [PATCH 4/9] drm/i915: Move bxt_ddi_vswing_sequence() call into intel_ddi_pre_enable() for HDMI ville.syrjala
2016-08-01 13:43 ` Imre Deak
2016-07-12 12:59 ` [PATCH 5/9] drm/i915: Explicitly use ddi buf trans entry 9 for hdmi ville.syrjala
2016-07-12 12:59 ` [PATCH 6/9] drm/i915: Split DP/eDP/FDI and HDMI/DVI DDI buffer programming apart ville.syrjala
2016-07-12 12:59 ` [PATCH 7/9] drm/i915: Get the iboost setting based on the port type ville.syrjala
2016-07-12 12:59 ` [PATCH 8/9] drm/i915: Simplify intel_ddi_get_encoder_port() ville.syrjala
2016-07-12 12:59 ` [PATCH 9/9] drm/i915: Extract bdw_get_buf_trans_edp() ville.syrjala
2016-08-01 13:49 ` Imre Deak
2016-07-12 16:41 ` ✓ Ro.CI.BAT: success for drm/i915: SKL iboost fixes Patchwork
2016-08-02 12:13 ` [PATCH 0/9] " Ville Syrjälä
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160713153115.GC3839@boom \
--to=david.weinehall@linux.intel.com \
--cc=intel-gfx@lists.freedesktop.org \
--cc=ville.syrjala@linux.intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.