From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Flabiano Smorigo Subject: Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS Date: Wed, 13 Jul 2016 13:02:09 -0300 Message-ID: <20160713160209.GB20432@dublin> References: <1468264060-22769-1-git-send-email-pfsmorigo@linux.vnet.ibm.com> <20160712093705.6f0fde7a@canb.auug.org.au> <8737nep7a8.fsf@linux.vnet.ibm.com> <20160713133427.GA20432@dublin> <20160714011158.46c386f4@canb.auug.org.au> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: Stewart Smith , "Leonidas S. Barbosa" , Herbert Xu , linux-kernel@vger.kernel.org, Paul Mackerras , "open list:IBM Power VMX Cryptographic instructions" , "open list:LINUX FOR POWERPC 32-BIT AND 64-BIT" , "David S. Miller" To: Stephen Rothwell Return-path: Content-Disposition: inline In-Reply-To: <20160714011158.46c386f4@canb.auug.org.au> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: linux-crypto.vger.kernel.org VGh1LCBKdWwgMTQsIDIwMTYgYXQgMDE6MTE6NThBTSArMTAwMCwgU3RlcGhlbiBSb3Rod2VsbCB3 cm90ZToKPiBIaSBQYXVsbywKPiAKPiBPbiBXZWQsIDEzIEp1bCAyMDE2IDEwOjM0OjI3IC0wMzAw IFBhdWxvIEZsYWJpYW5vIFNtb3JpZ28gPHBmc21vcmlnb0BsaW51eC52bmV0LmlibS5jb20+IHdy b3RlOgo+ID4KPiA+IFdlZCwgSnVsIDEzLCAyMDE2IGF0IDAxOjA1OjAzUE0gKzEwMDAsIFN0ZXdh cnQgU21pdGggd3JvdGU6Cj4gPiA+IFN0ZXBoZW4gUm90aHdlbGwgPHNmckBjYW5iLmF1dWcub3Jn LmF1PiB3cml0ZXM6ICAKPiA+ID4gPiBPbiBNb24sIDExIEp1bCAyMDE2IDE2OjA3OjM5IC0wMzAw IFBhdWxvIEZsYWJpYW5vIFNtb3JpZ28gPHBmc21vcmlnb0BsaW51eC52bmV0LmlibS5jb20+IHdy b3RlOiAgCj4gPiA+ID4+Cj4gPiA+ID4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2NyeXB0by92bXgv YWVzcDgtcHBjLnBsIGIvZHJpdmVycy9jcnlwdG8vdm14L2Flc3A4LXBwYy5wbAo+ID4gPiA+PiBp bmRleCAyMjgwNTM5Li44MTNmZmNjIDEwMDY0NAo+ID4gPiA+PiAtLS0gYS9kcml2ZXJzL2NyeXB0 by92bXgvYWVzcDgtcHBjLnBsCj4gPiA+ID4+ICsrKyBiL2RyaXZlcnMvY3J5cHRvL3ZteC9hZXNw OC1wcGMucGwKPiA+ID4gPj4gQEAgLTEsNCArMSwxMSBAQAo+ID4gPiA+PiAtIyEvdXNyL2Jpbi9l bnYgcGVybAo+ID4gPiA+PiArIyEgL3Vzci9iaW4vZW52IHBlcmwKPiA+ID4gPj4gKyMgQ29weXJp Z2h0IDIwMTQtMjAxNiBUaGUgT3BlblNTTCBQcm9qZWN0IEF1dGhvcnMuIEFsbCBSaWdodHMgUmVz ZXJ2ZWQuCj4gPiA+ID4+ICsjCj4gPiA+ID4+ICsjIExpY2Vuc2VkIHVuZGVyIHRoZSBPcGVuU1NM IGxpY2Vuc2UgKHRoZSAiTGljZW5zZSIpLiAgWW91IG1heSBub3QgdXNlCj4gPiA+ID4+ICsjIHRo aXMgZmlsZSBleGNlcHQgaW4gY29tcGxpYW5jZSB3aXRoIHRoZSBMaWNlbnNlLiAgWW91IGNhbiBv YnRhaW4gYSBjb3B5Cj4gPiA+ID4+ICsjIGluIHRoZSBmaWxlIExJQ0VOU0UgaW4gdGhlIHNvdXJj ZSBkaXN0cmlidXRpb24gb3IgYXQKPiA+ID4gPj4gKyMgaHR0cHM6Ly93d3cub3BlbnNzbC5vcmcv c291cmNlL2xpY2Vuc2UuaHRtbCAgCj4gPiA+ID4KPiA+ID4gPiBTbywgSSBhc3N1bWUgdGhhdCB0 aGlzIGxpY2Vuc2UgaXMgY29tcGF0aWJsZSB3aXRoIHRoZSBHUEx2Mj8gIAo+ID4gCj4gPiBBbmR5 IHJlbGVhc2VkIHRoaXMgY29kZSB1bmRlciB0aGUgY3J5cHRvZ2FtcyBsaWNlbnNlOgo+ID4gCj4g PiAjID09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09Cj4gPiAjIFdyaXR0ZW4gYnkgQW5keSBQb2x5YWtvdiA8YXBwcm9Ab3Bl bnNzbC5vcmc+IGZvciB0aGUgT3BlblNTTAo+ID4gIyBwcm9qZWN0LiBUaGUgbW9kdWxlIGlzLCBo b3dldmVyLCBkdWFsIGxpY2Vuc2VkIHVuZGVyIE9wZW5TU0wgYW5kCj4gPiAjIENSWVBUT0dBTVMg bGljZW5zZXMgZGVwZW5kaW5nIG9uIHdoZXJlIHlvdSBvYnRhaW4gaXQuIEZvciBmdXJ0aGVyCj4g PiAjIGRldGFpbHMgc2VlIGh0dHA6Ly93d3cub3BlbnNzbC5vcmcvfmFwcHJvL2NyeXB0b2dhbXMv Lgo+ID4gIyA9PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09PT09 PT09PT09PT09PT09PT09PT09PQo+IAo+IFllYWgsIHRoaXMgbGljZW5zZSBzdGF0ZW1lbnQgaXMg YWxyZWFkeSBpbiB0aGUgZmlsZSBiZWluZyBwYXRjaGVkLCBzbwo+IHdoeSBpcyB0aGUgYWJvdmUg bGljZW5zZSAoYW5kIENvcHlyaWdodCBub3RpY2UpIGJlaW5nIGFkZGVkIGFib3ZlIHRoZQo+IGV4 aXN0aW5nIG9uZT8KCmFlc3A4LXBwYy5wbCBmcm9tIExpbnV4IGlzIGFsbW9zdCB0aGUgc2FtZSBh cyB0aGUgb25lIGZyb20gT3BlblNTTCBhbmQgd2UgZG8KdGhhdCBzbyB3ZSBjYW4ga2VlcCBpdCB1 cGRhdGVkIG9uIGJvdGggcHJvamVjdHMuClRoZSBhYm92ZSBsaWNlbnNlIGxpbmVzIHdlcmUgYWRk ZWQgdG8gYWxsIHBsIGZpbGVzIGluIE9wZW5TU0wgc28gaXQgZW5kZWQgdXAKaGVyZSBidXQgc2lu Y2UgdGhlIGF1dGhvciBwdWJsaXNoZWQgaXQgYXMgY3J5cHRvZ2FtcyB0b28gd2UgYXJlIG9rLgoK PiAKPiA+IFRoZSBsaWNlbnNlIGlzIEdQTCBjb21wYXRpYmxlOgo+IAo+IEdvb2QsIHRoYW5rcy4K PiAKPiA+IEFMVEVSTkFUSVZFTFksIHByb3ZpZGVkIHRoYXQgdGhpcyBub3RpY2UgaXMgcmV0YWlu ZWQgaW4gZnVsbCwgdGhpcwo+ID4gcHJvZHVjdCBtYXkgYmUgZGlzdHJpYnV0ZWQgdW5kZXIgdGhl IHRlcm1zIG9mIHRoZSBHTlUgR2VuZXJhbCBQdWJsaWMKPiA+IExpY2Vuc2UgKEdQTCksIGluIHdo aWNoIGNhc2UgdGhlIHByb3Zpc2lvbnMgb2YgdGhlIEdQTCBhcHBseSBJTlNURUFEIE9GCj4gPiB0 aG9zZSBnaXZlbiBhYm92ZS4KPiAKPiBXaGljaCBpcyBub3QgaW4gdGhpcyBmaWxlIG9yIHRoZSBw YXRjaCwgYnV0IHByZXN1bWFibHkgaW4gdGhlIHJlZmVycmVkCj4gdG8gd2ViIHBhZ2UuCgpZZXMs IHRoYXQgY29tbWVudCBpcyBmcm9tIHRoZSB1cmwgcG9pbnRlZCBpbiB0aGUgY29kZS4KCj4gCj4g T2YgY291cnNlLCBJIGFtIG5vdCBhIGxhd3llciA6LSkKPiAtLSAKPiBDaGVlcnMsCj4gU3RlcGhl biBSb3Rod2VsbAo+IAoKLS0gClBhdWxvIEZsYWJpYW5vIFNtb3JpZ28KSUJNIExpbnV4IFRlY2hu b2xvZ3kgQ2VudGVyCgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fXwpMaW51eHBwYy1kZXYgbWFpbGluZyBsaXN0CkxpbnV4cHBjLWRldkBsaXN0cy5vemxhYnMu b3JnCmh0dHBzOi8vbGlzdHMub3psYWJzLm9yZy9saXN0aW5mby9saW51eHBwYy1kZXY= From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rqNrl0MJ6zDqFn for ; Thu, 14 Jul 2016 02:02:30 +1000 (AEST) Received: from pps.filterd (m0098396.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.11/8.16.0.11) with SMTP id u6DFxCtQ092539 for ; Wed, 13 Jul 2016 12:02:28 -0400 Received: from e24smtp02.br.ibm.com (e24smtp02.br.ibm.com [32.104.18.86]) by mx0a-001b2d01.pphosted.com with ESMTP id 245py7523x-1 (version=TLSv1.2 cipher=AES256-SHA bits=256 verify=NOT) for ; Wed, 13 Jul 2016 12:02:28 -0400 Received: from localhost by e24smtp02.br.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Wed, 13 Jul 2016 13:02:26 -0300 Received: from d24relay02.br.ibm.com (d24relay02.br.ibm.com [9.13.184.26]) by d24dlp02.br.ibm.com (Postfix) with ESMTP id 117971DC0051 for ; Wed, 13 Jul 2016 12:02:11 -0400 (EDT) Received: from d24av05.br.ibm.com (d24av05.br.ibm.com [9.18.232.44]) by d24relay02.br.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id u6DG2Iwi65994880 for ; Wed, 13 Jul 2016 13:02:19 -0300 Received: from d24av05.br.ibm.com (localhost [127.0.0.1]) by d24av05.br.ibm.com (8.14.4/8.14.4/NCO v10.0 AVout) with ESMTP id u6DG2Icc014736 for ; Wed, 13 Jul 2016 13:02:18 -0300 Date: Wed, 13 Jul 2016 13:02:09 -0300 From: Paulo Flabiano Smorigo To: Stephen Rothwell Cc: Stewart Smith , "Leonidas S. Barbosa" , Herbert Xu , linux-kernel@vger.kernel.org, Paul Mackerras , "open list:IBM Power VMX Cryptographic instructions" , "open list:LINUX FOR POWERPC 32-BIT AND 64-BIT" , "David S. Miller" Subject: Re: [PATCH 1/2] crypto: vmx - Adding asm subroutines for XTS References: <1468264060-22769-1-git-send-email-pfsmorigo@linux.vnet.ibm.com> <20160712093705.6f0fde7a@canb.auug.org.au> <8737nep7a8.fsf@linux.vnet.ibm.com> <20160713133427.GA20432@dublin> <20160714011158.46c386f4@canb.auug.org.au> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <20160714011158.46c386f4@canb.auug.org.au> Message-Id: <20160713160209.GB20432@dublin> List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Thu, Jul 14, 2016 at 01:11:58AM +1000, Stephen Rothwell wrote: > Hi Paulo, > > On Wed, 13 Jul 2016 10:34:27 -0300 Paulo Flabiano Smorigo wrote: > > > > Wed, Jul 13, 2016 at 01:05:03PM +1000, Stewart Smith wrote: > > > Stephen Rothwell writes: > > > > On Mon, 11 Jul 2016 16:07:39 -0300 Paulo Flabiano Smorigo wrote: > > > >> > > > >> diff --git a/drivers/crypto/vmx/aesp8-ppc.pl b/drivers/crypto/vmx/aesp8-ppc.pl > > > >> index 2280539..813ffcc 100644 > > > >> --- a/drivers/crypto/vmx/aesp8-ppc.pl > > > >> +++ b/drivers/crypto/vmx/aesp8-ppc.pl > > > >> @@ -1,4 +1,11 @@ > > > >> -#!/usr/bin/env perl > > > >> +#! /usr/bin/env perl > > > >> +# Copyright 2014-2016 The OpenSSL Project Authors. All Rights Reserved. > > > >> +# > > > >> +# Licensed under the OpenSSL license (the "License"). You may not use > > > >> +# this file except in compliance with the License. You can obtain a copy > > > >> +# in the file LICENSE in the source distribution or at > > > >> +# https://www.openssl.org/source/license.html > > > > > > > > So, I assume that this license is compatible with the GPLv2? > > > > Andy released this code under the cryptogams license: > > > > # ==================================================================== > > # Written by Andy Polyakov for the OpenSSL > > # project. The module is, however, dual licensed under OpenSSL and > > # CRYPTOGAMS licenses depending on where you obtain it. For further > > # details see http://www.openssl.org/~appro/cryptogams/. > > # ==================================================================== > > Yeah, this license statement is already in the file being patched, so > why is the above license (and Copyright notice) being added above the > existing one? aesp8-ppc.pl from Linux is almost the same as the one from OpenSSL and we do that so we can keep it updated on both projects. The above license lines were added to all pl files in OpenSSL so it ended up here but since the author published it as cryptogams too we are ok. > > > The license is GPL compatible: > > Good, thanks. > > > ALTERNATIVELY, provided that this notice is retained in full, this > > product may be distributed under the terms of the GNU General Public > > License (GPL), in which case the provisions of the GPL apply INSTEAD OF > > those given above. > > Which is not in this file or the patch, but presumably in the referred > to web page. Yes, that comment is from the url pointed in the code. > > Of course, I am not a lawyer :-) > -- > Cheers, > Stephen Rothwell > -- Paulo Flabiano Smorigo IBM Linux Technology Center