All of lore.kernel.org
 help / color / mirror / Atom feed
From: Leon Romanovsky <leon@kernel.org>
To: Lijun Ou <oulijun@huawei.com>
Cc: dledford@redhat.com, sean.hefty@intel.com,
	hal.rosenstock@gmail.com, davem@davemloft.net,
	jeffrey.t.kirsher@intel.com, jiri@mellanox.com,
	ogerlitz@mellanox.com, linux-rdma@vger.kernel.org,
	linux-kernel@vger.kernel.org, netdev@vger.kernel.org,
	gongyangming@huawei.com, xiaokun@huawei.com,
	tangchaofei@huawei.com, haifeng.wei@huawei.com,
	yisen.zhuang@huawei.com, yankejian@huawei.com,
	charles.chenxin@huawei.com, linuxarm@huawei.com
Subject: Re: [PATCH v11 21/22] IB/hns: Kconfig and Makefile for RoCE module
Date: Thu, 14 Jul 2016 08:35:31 +0300	[thread overview]
Message-ID: <20160714053530.GJ10079@leon.nu> (raw)
In-Reply-To: <1467452364-66522-22-git-send-email-oulijun@huawei.com>

[-- Attachment #1: Type: text/plain, Size: 2771 bytes --]

On Sat, Jul 02, 2016 at 05:39:23PM +0800, Lijun Ou wrote:
> This patch added Kconfig and Makefile for building RoCE module.
> 
> Signed-off-by: Wei Hu <xavier.huwei@huawei.com>
> Signed-off-by: Nenglong Zhao <zhaonenglong@hisilicon.com>
> Signed-off-by: Lijun Ou <oulijun@huawei.com>
> ---
> PATCH v11:
> hns_roce_icm.o -> hns_roce_hem.o
> 
> PATCH v10/v9/v8/v7/v6/v5:
> - No change over the PATCH v4
> 
> PATCH v4:
> This fixes the comments given by Christoph Hellwig over the PATCH v3:
>   Link: https://lkml.org/lkml/2016/3/22/609
> 
> PATCH V3:
> This fixes the comments given by Leon Romanovsky over the PATCH v2:
>   Link: https://lkml.org/lkml/2016/3/20/5
> 
> PATCH v2:
> This fixes the comments given by Leon Romanovsky over the PATCH v1:
>   Link: https://lkml.org/lkml/2016/3/6/94
> Fixes the error tested by kbuild test robot over the PATCH v1:
>   Link: https://lkml.org/lkml/2016/3/4/343
> 
> PATCH v1:
> - The initial patch
> ---
> ---
>  drivers/infiniband/Kconfig         |  1 +
>  drivers/infiniband/hw/Makefile     |  1 +
>  drivers/infiniband/hw/hns/Kconfig  | 10 ++++++++++
>  drivers/infiniband/hw/hns/Makefile |  8 ++++++++
>  4 files changed, 20 insertions(+)
>  create mode 100644 drivers/infiniband/hw/hns/Kconfig
>  create mode 100644 drivers/infiniband/hw/hns/Makefile
> 
> diff --git a/drivers/infiniband/Kconfig b/drivers/infiniband/Kconfig
> index 2137adf..767f92b 100644
> --- a/drivers/infiniband/Kconfig
> +++ b/drivers/infiniband/Kconfig
> @@ -74,6 +74,7 @@ source "drivers/infiniband/hw/mlx5/Kconfig"
>  source "drivers/infiniband/hw/nes/Kconfig"
>  source "drivers/infiniband/hw/ocrdma/Kconfig"
>  source "drivers/infiniband/hw/usnic/Kconfig"
> +source "drivers/infiniband/hw/hns/Kconfig"
>  
>  source "drivers/infiniband/ulp/ipoib/Kconfig"
>  
> diff --git a/drivers/infiniband/hw/Makefile b/drivers/infiniband/hw/Makefile
> index c0c7cf8..2ad851d 100644
> --- a/drivers/infiniband/hw/Makefile
> +++ b/drivers/infiniband/hw/Makefile
> @@ -9,3 +9,4 @@ obj-$(CONFIG_INFINIBAND_NES)		+= nes/
>  obj-$(CONFIG_INFINIBAND_OCRDMA)		+= ocrdma/
>  obj-$(CONFIG_INFINIBAND_USNIC)		+= usnic/
>  obj-$(CONFIG_INFINIBAND_HFI1)		+= hfi1/
> +obj-$(CONFIG_INFINIBAND_HISILICON_HNS) 	+= hns/

--------------------------^^^^^^^--
There is no need in HISILICON word here.

> diff --git a/drivers/infiniband/hw/hns/Kconfig b/drivers/infiniband/hw/hns/Kconfig
> new file mode 100644
> index 0000000..c47c168
> --- /dev/null
> +++ b/drivers/infiniband/hw/hns/Kconfig
> @@ -0,0 +1,10 @@
> +config INFINIBAND_HISILICON_HNS
> +	tristate "Hisilicon Hns ROCE Driver"

And you are still inconsistent with the names
Hisilicon/HiSilicon/hisilicon/HISILICON/e.t.c., ROCE/roce/RoCE/e.t.c.

[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 819 bytes --]

  reply	other threads:[~2016-07-14  5:35 UTC|newest]

Thread overview: 72+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2016-07-02  9:39 [PATCH v11 00/22] Add HiSilicon RoCE driver Lijun Ou
2016-07-02  9:39 ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 02/22] devicetree: bindings: IB: Add binding document for HiSilicon RoCE Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 04/22] IB/hns: Add RoCE engine reset function Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 05/22] IB/hns: Add initial profile resource Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 06/22] IB/hns: Add initial cmd operation Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 07/22] IB/hns: Add event queue support Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 08/22] IB/hns: Add hem support Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 09/22] IB/hns: Add hca support Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 10/22] IB/hns: Add process flow to init RoCE engine Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 11/22] IB/hns: Add IB device registration Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 12/22] IB/hns: Set mtu and gid support Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 13/22] IB/hns: Add interface of the protocol stack registration Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 14/22] IB/hns: Add operations support for IB device and port Lijun Ou
2016-07-02  9:39   ` Lijun Ou
     [not found] ` <1467452364-66522-1-git-send-email-oulijun-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-07-02  9:39   ` [PATCH v11 01/22] net: hns: Add reset function support for RoCE driver Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39   ` [PATCH v11 03/22] IB/hns: Add initial main frame driver and get cfg info Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39   ` [PATCH v11 15/22] IB/hns: Add PD operations support Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39   ` [PATCH v11 18/22] IB/hns: Add CQ " Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39   ` [PATCH v11 19/22] IB/hns: Add memory region " Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39   ` [PATCH v11 21/22] IB/hns: Kconfig and Makefile for RoCE module Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-02  9:39     ` Lijun Ou
2016-07-14  5:35     ` Leon Romanovsky [this message]
2016-07-02 12:58   ` [PATCH v11 00/22] Add HiSilicon RoCE driver Leon Romanovsky
2016-07-02 12:58     ` Leon Romanovsky
     [not found]     ` <20160702125816.GG4750-2ukJVAZIZ/Y@public.gmane.org>
2016-07-04  6:24       ` Wei Hu (Xavier)
2016-07-04  6:24         ` Wei Hu (Xavier)
2016-07-04  6:24         ` Wei Hu (Xavier)
2016-07-04  8:16       ` oulijun
2016-07-04  8:16         ` oulijun
2016-07-04  8:16         ` oulijun
2016-07-08  2:58   ` oulijun
2016-07-08  2:58     ` oulijun
2016-07-08  2:58     ` oulijun
     [not found]     ` <577F16C1.8090705-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-07-11  9:38       ` Wei Hu (Xavier)
2016-07-11  9:38         ` Wei Hu (Xavier)
2016-07-11  9:38         ` Wei Hu (Xavier)
2016-07-14  3:43   ` oulijun
2016-07-14  3:43     ` oulijun
2016-07-14  3:43     ` oulijun
     [not found]     ` <57870A7F.6080901-hv44wF8Li93QT0dZR+AlfA@public.gmane.org>
2016-07-14  5:25       ` Leon Romanovsky
2016-07-14  5:25         ` Leon Romanovsky
2016-07-02  9:39 ` [PATCH v11 16/22] IB/hns: Add ah operations support Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 17/22] IB/hns: Add QP " Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 20/22] IB/hns: Add operation for getting immutable port Lijun Ou
2016-07-02  9:39   ` Lijun Ou
2016-07-02  9:39 ` [PATCH v11 22/22] MAINTAINERS: Add maintainers for HiSilicon RoCE driver Lijun Ou
2016-07-02  9:39   ` Lijun Ou

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20160714053530.GJ10079@leon.nu \
    --to=leon@kernel.org \
    --cc=charles.chenxin@huawei.com \
    --cc=davem@davemloft.net \
    --cc=dledford@redhat.com \
    --cc=gongyangming@huawei.com \
    --cc=haifeng.wei@huawei.com \
    --cc=hal.rosenstock@gmail.com \
    --cc=jeffrey.t.kirsher@intel.com \
    --cc=jiri@mellanox.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-rdma@vger.kernel.org \
    --cc=linuxarm@huawei.com \
    --cc=netdev@vger.kernel.org \
    --cc=ogerlitz@mellanox.com \
    --cc=oulijun@huawei.com \
    --cc=sean.hefty@intel.com \
    --cc=tangchaofei@huawei.com \
    --cc=xiaokun@huawei.com \
    --cc=yankejian@huawei.com \
    --cc=yisen.zhuang@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.