From mboxrd@z Thu Jan 1 00:00:00 1970 From: Peter Zijlstra Subject: Re: [patch V2 43/67] leds/trigger/cpu: Convert to hotplug state machine Date: Thu, 14 Jul 2016 11:41:54 +0200 Message-ID: <20160714094154.GY30154@twins.programming.kicks-ass.net> References: <20160713153219.128052238@linutronix.de> <20160713153336.465496902@linutronix.de> <57873CFF.1010803@samsung.com> <20160714074713.GA17287@gmail.com> <5787490F.5000105@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <5787490F.5000105@samsung.com> Sender: linux-kernel-owner@vger.kernel.org To: Jacek Anaszewski Cc: Ingo Molnar , Anna-Maria Gleixner , LKML , Thomas Gleixner , rt@linutronix.de, Richard Cochran , Sebastian Andrzej Siewior , Linus Torvalds , Linus Walleij , Paul Gortmaker , Richard Purdie , linux-leds@vger.kernel.org List-Id: linux-leds@vger.kernel.org On Thu, Jul 14, 2016 at 10:10:55AM +0200, Jacek Anaszewski wrote: > On 07/14/2016 09:47 AM, Ingo Molnar wrote: > > > >* Jacek Anaszewski wrote: > > > >>>@@ -133,7 +125,13 @@ static int __init ledtrig_cpu_init(void) > >>> } > >>> > >>> register_syscore_ops(&ledtrig_cpu_syscore_ops); > >>>- register_cpu_notifier(&ledtrig_cpu_nb); > >>>+ > >>>+ /* > >>>+ * FIXME: Why needs this to happen in the interrupt disabled > >>>+ * low level bringup phase of a cpu? > >>>+ */ > Thanks for the explanation. I'm OK with that approach. Since we have your attention, could you perhaps attempt to answer the question so we can fix the fixme?