From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Date: Thu, 14 Jul 2016 10:15:46 +0000 Subject: [patch] KVM: PPC: fix a sanity check Message-Id: <20160714101545.GB18175@mwanda> List-Id: MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Alexander Graf , Bharat Bhushan Cc: kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , kernel-janitors@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org We use logical negate where bitwise negate was intended. It means that we never return -EINVAL here. Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support') Signed-off-by: Dan Carpenter diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 02b4672..df3f270 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -2038,7 +2038,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu, if (type = KVMPPC_DEBUG_NONE) continue; - if (type & !(KVMPPC_DEBUG_WATCH_READ | + if (type & ~(KVMPPC_DEBUG_WATCH_READ | KVMPPC_DEBUG_WATCH_WRITE | KVMPPC_DEBUG_BREAKPOINT)) return -EINVAL; From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from aserp1040.oracle.com (aserp1040.oracle.com [141.146.126.69]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 3rqs6f3nFtzDqxj for ; Thu, 14 Jul 2016 20:16:10 +1000 (AEST) Date: Thu, 14 Jul 2016 13:15:46 +0300 From: Dan Carpenter To: Alexander Graf , Bharat Bhushan Cc: Paolo Bonzini , Radim =?utf-8?B?S3LEjW3DocWZ?= , Benjamin Herrenschmidt , Paul Mackerras , Michael Ellerman , kvm-ppc@vger.kernel.org, kvm@vger.kernel.org, linuxppc-dev@lists.ozlabs.org, kernel-janitors@vger.kernel.org Subject: [patch] KVM: PPC: fix a sanity check Message-ID: <20160714101545.GB18175@mwanda> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , We use logical negate where bitwise negate was intended. It means that we never return -EINVAL here. Fixes: ce11e48b7fdd ('KVM: PPC: E500: Add userspace debug stub support') Signed-off-by: Dan Carpenter diff --git a/arch/powerpc/kvm/booke.c b/arch/powerpc/kvm/booke.c index 02b4672..df3f270 100644 --- a/arch/powerpc/kvm/booke.c +++ b/arch/powerpc/kvm/booke.c @@ -2038,7 +2038,7 @@ int kvm_arch_vcpu_ioctl_set_guest_debug(struct kvm_vcpu *vcpu, if (type == KVMPPC_DEBUG_NONE) continue; - if (type & !(KVMPPC_DEBUG_WATCH_READ | + if (type & ~(KVMPPC_DEBUG_WATCH_READ | KVMPPC_DEBUG_WATCH_WRITE | KVMPPC_DEBUG_BREAKPOINT)) return -EINVAL; From mboxrd@z Thu Jan 1 00:00:00 1970 From: Dan Carpenter Subject: [patch] KVM: PPC: fix a sanity check Date: Thu, 14 Jul 2016 13:15:46 +0300 Message-ID: <20160714101545.GB18175@mwanda> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Cc: kvm@vger.kernel.org, Radim =?utf-8?B?S3LEjW3DocWZ?= , kernel-janitors@vger.kernel.org, kvm-ppc@vger.kernel.org, Paul Mackerras , Paolo Bonzini , linuxppc-dev@lists.ozlabs.org To: Alexander Graf , Bharat Bhushan Return-path: Content-Disposition: inline List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: linuxppc-dev-bounces+glppe-linuxppc-embedded-2=m.gmane.org@lists.ozlabs.org Sender: "Linuxppc-dev" List-Id: kvm.vger.kernel.org V2UgdXNlIGxvZ2ljYWwgbmVnYXRlIHdoZXJlIGJpdHdpc2UgbmVnYXRlIHdhcyBpbnRlbmRlZC4g IEl0IG1lYW5zIHRoYXQKd2UgbmV2ZXIgcmV0dXJuIC1FSU5WQUwgaGVyZS4KCkZpeGVzOiBjZTEx ZTQ4YjdmZGQgKCdLVk06IFBQQzogRTUwMDogQWRkIHVzZXJzcGFjZSBkZWJ1ZyBzdHViIHN1cHBv cnQnKQpTaWduZWQtb2ZmLWJ5OiBEYW4gQ2FycGVudGVyIDxkYW4uY2FycGVudGVyQG9yYWNsZS5j b20+CgpkaWZmIC0tZ2l0IGEvYXJjaC9wb3dlcnBjL2t2bS9ib29rZS5jIGIvYXJjaC9wb3dlcnBj L2t2bS9ib29rZS5jCmluZGV4IDAyYjQ2NzIuLmRmM2YyNzAgMTAwNjQ0Ci0tLSBhL2FyY2gvcG93 ZXJwYy9rdm0vYm9va2UuYworKysgYi9hcmNoL3Bvd2VycGMva3ZtL2Jvb2tlLmMKQEAgLTIwMzgs NyArMjAzOCw3IEBAIGludCBrdm1fYXJjaF92Y3B1X2lvY3RsX3NldF9ndWVzdF9kZWJ1ZyhzdHJ1 Y3Qga3ZtX3ZjcHUgKnZjcHUsCiAJCWlmICh0eXBlID09IEtWTVBQQ19ERUJVR19OT05FKQogCQkJ Y29udGludWU7CiAKLQkJaWYgKHR5cGUgJiAhKEtWTVBQQ19ERUJVR19XQVRDSF9SRUFEIHwKKwkJ aWYgKHR5cGUgJiB+KEtWTVBQQ19ERUJVR19XQVRDSF9SRUFEIHwKIAkJCSAgICAgS1ZNUFBDX0RF QlVHX1dBVENIX1dSSVRFIHwKIAkJCSAgICAgS1ZNUFBDX0RFQlVHX0JSRUFLUE9JTlQpKQogCQkJ cmV0dXJuIC1FSU5WQUw7Cl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fCkxpbnV4cHBjLWRldiBtYWlsaW5nIGxpc3QKTGludXhwcGMtZGV2QGxpc3RzLm96bGFi cy5vcmcKaHR0cHM6Ly9saXN0cy5vemxhYnMub3JnL2xpc3RpbmZvL2xpbnV4cHBjLWRldg==