From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751153AbcGNL05 (ORCPT ); Thu, 14 Jul 2016 07:26:57 -0400 Received: from merlin.infradead.org ([205.233.59.134]:45977 "EHLO merlin.infradead.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751101AbcGNL0z (ORCPT ); Thu, 14 Jul 2016 07:26:55 -0400 Date: Thu, 14 Jul 2016 13:26:48 +0200 From: Peter Zijlstra To: Wanpeng Li Cc: linux-kernel@vger.kernel.org, Wanpeng Li , Ingo Molnar , Waiman Long , Davidlohr Bueso Subject: Re: [PATCH v2] locking/pvqspinlock: restore/set vcpu_hashed state after failing adaptive locking spinning Message-ID: <20160714112648.GG30909@twins.programming.kicks-ass.net> References: <1468484156-4521-1-git-send-email-wanpeng.li@hotmail.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <1468484156-4521-1-git-send-email-wanpeng.li@hotmail.com> User-Agent: Mutt/1.5.23.1 (2014-03-12) Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 14, 2016 at 04:15:56PM +0800, Wanpeng Li wrote: > In this case, lock holder inserts the pv_node of queue head into the > hash table and set _Q_SLOW_VAL unnecessary. This patch avoids it by > restoring/setting vcpu_halted state after failing adaptive locking ^^^^^^ > spinning. > > - WRITE_ONCE(pn->state, vcpu_halted); > + WRITE_ONCE(pn->state, vcpu_hashed); ^^^^^^ The Changelog meant so say vcpu_hashed, surely?