From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Aaron Conole <aconole@bytheb.org>
Cc: netdev@vger.kernel.org, netfilter-devel@vger.kernel.org,
Florian Westphal <fw@strlen.de>
Subject: Re: [PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh
Date: Thu, 14 Jul 2016 19:17:27 +0200 [thread overview]
Message-ID: <20160714171727.GA1244@salvia> (raw)
In-Reply-To: <1468337541-23930-2-git-send-email-aconole@bytheb.org>
On Tue, Jul 12, 2016 at 11:32:19AM -0400, Aaron Conole wrote:
> +/* recursively invokes nf_hook_slow (again), skipping already-called
> + * hooks (< NF_BR_PRI_BRNF).
> + *
> + * Called with rcu read lock held.
> + */
> +int br_nf_hook_thresh(unsigned int hook, struct net *net,
> + struct sock *sk, struct sk_buff *skb,
> + struct net_device *indev,
> + struct net_device *outdev,
> + int (*okfn)(struct net *, struct sock *,
> + struct sk_buf *))
^^^^^^
This doesn't compile. Please, make sure patches compile independently
so we make sure git bisectability doesn't break. Thanks.
next prev parent reply other threads:[~2016-07-14 17:17 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-12 15:32 [PATCH nf-next v2 0/3] Compact netfilter hooks list Aaron Conole
2016-07-12 15:32 ` [PATCH nf-next v2 1/3] netfilter: bridge: add and use br_nf_hook_thresh Aaron Conole
2016-07-14 17:17 ` Pablo Neira Ayuso [this message]
2016-07-14 18:01 ` Aaron Conole
2016-07-12 15:32 ` [PATCH nf-next v2 2/3] netfilter: call nf_hook_state_init with rcu_read_lock held Aaron Conole
2016-07-14 17:19 ` Pablo Neira Ayuso
2016-07-14 17:42 ` Florian Westphal
2016-07-12 15:32 ` [PATCH v2 3/3] netfilter: replace list_head with single linked list Aaron Conole
2016-07-14 17:58 ` Pablo Neira Ayuso
2016-07-14 19:19 ` Florian Westphal
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714171727.GA1244@salvia \
--to=pablo@netfilter.org \
--cc=aconole@bytheb.org \
--cc=fw@strlen.de \
--cc=netdev@vger.kernel.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.