From: Brian Norris <computersforpeace@gmail.com>
To: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
Cc: "David Woodhouse" <dwmw2@infradead.org>,
"Javier Martinez Canillas" <javier@osg.samsung.com>,
"Boris Brezillon" <boris.brezillon@free-electrons.com>,
"Stephen Warren" <swarren@nvidia.com>,
"Jagan Teki" <jteki@openedev.com>, "Vignesh R" <vigneshr@ti.com>,
"Marek Vasut" <marex@denx.de>,
"Ezequiel García" <ezequiel@vanguardiasur.com.ar>,
"Rafał Miłecki" <zajec5@gmail.com>,
"Furquan Shaikh" <furquan@google.com>,
"Cyrille Pitchen" <cyrille.pitchen@atmel.com>,
linux-mtd@lists.infradead.org, linux-kernel@vger.kernel.org
Subject: Re: [RESEND PATCH v3] mtd: spi-nor: Add support for S3AN spi-nor devices
Date: Thu, 14 Jul 2016 11:07:11 -0700 [thread overview]
Message-ID: <20160714180711.GH54628@google.com> (raw)
In-Reply-To: <1463002402-7996-1-git-send-email-ricardo.ribalda@gmail.com>
On Tue, Jun 28, 2016 at 11:25:11AM +0200, Ricardo Ribalda Delgado wrote:
> Xilinx Spartan-3AN FPGAs contain an In-System Flash where they keep
> their configuration data and (optionally) some user data.
>
> The protocol of this flash follows most of the spi-nor standard. With
> the following differences:
>
> - Page size might not be a power of two.
> - The address calculation (default addressing mode).
> - The spi nor commands used.
>
> Protocol is described on Xilinx User Guide UG333
>
> Signed-off-by: Ricardo Ribalda Delgado <ricardo.ribalda@gmail.com>
> ---
>
> v3:
> -Rebase on top of mtd-next
> -Rename ADDR_NATIVE to ADDR_DEFAULT to follow UG333 naming
> -Fix bug on probe
>
> v2: Suggested by Brian Norris <computersforpeace@gmail.com>
>
> -Remove inline qualifier
> -Improve documentation of Default Addressing Mode
> -Convert function callbacks into SNOR_F_
> -Fix missmatch braces
> -Improve documentation of SPI_S3AN flag
>
> drivers/mtd/devices/m25p80.c | 3 ++
> drivers/mtd/spi-nor/spi-nor.c | 110 ++++++++++++++++++++++++++++++++++++++++--
> include/linux/mtd/spi-nor.h | 26 ++++++++++
> 3 files changed, 136 insertions(+), 3 deletions(-)
This still doesn't apply to l2-mtd.git / linux-next.git. If I get time,
I'll see how easily I can fix that up myself.
next prev parent reply other threads:[~2016-07-14 18:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-11 21:33 [PATCH v3] mtd: spi-nor: Add support for S3AN spi-nor devices Ricardo Ribalda Delgado
2016-07-14 18:07 ` Brian Norris [this message]
2016-07-14 20:20 ` [RESEND PATCH " Ricardo Ribalda Delgado
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714180711.GH54628@google.com \
--to=computersforpeace@gmail.com \
--cc=boris.brezillon@free-electrons.com \
--cc=cyrille.pitchen@atmel.com \
--cc=dwmw2@infradead.org \
--cc=ezequiel@vanguardiasur.com.ar \
--cc=furquan@google.com \
--cc=javier@osg.samsung.com \
--cc=jteki@openedev.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=marex@denx.de \
--cc=ricardo.ribalda@gmail.com \
--cc=swarren@nvidia.com \
--cc=vigneshr@ti.com \
--cc=zajec5@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.