From: viktorin@rehivetech.com
To: Thomas Monjalon <thomas.monjalon@6wind.com>
Cc: dev@dpdk.org
Subject: Re: [dpdk-dev, 1/2] app/test: rework command registration
Date: Thu, 14 Jul 2016 19:25:23 +0200 [thread overview]
Message-ID: <20160714192523.150d8918@jvn> (raw)
In-Reply-To: <1468445050-1081-1-git-send-email-thomas.monjalon@6wind.com>
On Wed, 13 Jul 2016 23:24:09 +0200
Thomas Monjalon <thomas.monjalon@6wind.com> wrote:
> The tests are registered with their command name by adding a structure
> to a list. The structure of each test was declared in each test file
> and passed to the register macro.
> This rework generate the structure inside the register macro.
There is just this little issue:
WARNING:LONG_LINE: line over 80 characters
#335: FILE: app/test/test_cryptodev_perf.c:2924:
+REGISTER_TEST_COMMAND(cryptodev_sw_snow3g_perftest, perftest_sw_snow3g_cryptodev);
WARNING:LONG_LINE: line over 80 characters
#336: FILE: app/test/test_cryptodev_perf.c:2925:
+REGISTER_TEST_COMMAND(cryptodev_qat_snow3g_perftest, perftest_qat_snow3g_cryptodev);
total: 0 errors, 2 warnings, 758 lines checked
Otherwise
Reviewed-by: Jan Viktorin <viktorin@rehivetech.com>
>
> Signed-off-by: Thomas Monjalon <thomas.monjalon@6wind.com>
>
> ---
> app/test/test.h | 17 +++++++++------
> app/test/test_acl.c | 6 +-----
> app/test/test_alarm.c | 6 +-----
> app/test/test_atomic.c | 6 +-----
> app/test/test_byteorder.c | 6 +-----
> app/test/test_cmdline.c | 6 +-----
> app/test/test_common.c | 6 +-----
> app/test/test_cpuflags.c | 6 +-----
> app/test/test_cryptodev.c | 41 ++++++------------------------------
> app/test/test_cryptodev_perf.c | 28 ++++--------------------
> app/test/test_cycles.c | 6 +-----
> app/test/test_debug.c | 6 +-----
> app/test/test_devargs.c | 6 +-----
> app/test/test_distributor.c | 6 +-----
> app/test/test_distributor_perf.c | 6 +-----
> app/test/test_eal_flags.c | 6 +-----
> app/test/test_eal_fs.c | 6 +-----
> app/test/test_errno.c | 6 +-----
> app/test/test_func_reentrancy.c | 6 +-----
> app/test/test_hash.c | 6 +-----
> app/test/test_hash_functions.c | 6 +-----
> app/test/test_hash_multiwriter.c | 8 +------
> app/test/test_hash_perf.c | 6 +-----
> app/test/test_hash_scaling.c | 7 +-----
> app/test/test_interrupts.c | 6 +-----
> app/test/test_ivshmem.c | 6 +-----
> app/test/test_kni.c | 6 +-----
> app/test/test_kvargs.c | 6 +-----
> app/test/test_link_bonding.c | 6 +-----
> app/test/test_link_bonding_mode4.c | 7 +-----
> app/test/test_link_bonding_rssconf.c | 7 +-----
> app/test/test_logs.c | 6 +-----
> app/test/test_lpm.c | 6 +-----
> app/test/test_lpm6.c | 6 +-----
> app/test/test_lpm6_perf.c | 6 +-----
> app/test/test_lpm_perf.c | 6 +-----
> app/test/test_malloc.c | 6 +-----
> app/test/test_mbuf.c | 6 +-----
> app/test/test_memcpy.c | 6 +-----
> app/test/test_memcpy_perf.c | 6 +-----
> app/test/test_memory.c | 6 +-----
> app/test/test_mempool.c | 6 +-----
> app/test/test_mempool_perf.c | 6 +-----
> app/test/test_memzone.c | 6 +-----
> app/test/test_meter.c | 6 +-----
> app/test/test_mp_secondary.c | 6 +-----
> app/test/test_pci.c | 6 +-----
> app/test/test_per_lcore.c | 6 +-----
> app/test/test_pmd_perf.c | 6 +-----
> app/test/test_pmd_ring.c | 6 +-----
> app/test/test_pmd_ring_perf.c | 6 +-----
> app/test/test_power.c | 6 +-----
> app/test/test_power_acpi_cpufreq.c | 6 +-----
> app/test/test_power_kvm_vm.c | 6 +-----
> app/test/test_prefetch.c | 6 +-----
> app/test/test_red.c | 20 +++---------------
> app/test/test_reorder.c | 6 +-----
> app/test/test_resource.c | 6 +-----
> app/test/test_ring.c | 6 +-----
> app/test/test_ring_perf.c | 6 +-----
> app/test/test_rwlock.c | 6 +-----
> app/test/test_sched.c | 6 +-----
> app/test/test_spinlock.c | 6 +-----
> app/test/test_string_fns.c | 6 +-----
> app/test/test_table.c | 6 +-----
> app/test/test_tailq.c | 6 +-----
> app/test/test_thash.c | 6 +-----
> app/test/test_timer.c | 6 +-----
> app/test/test_timer_perf.c | 6 +-----
> app/test/test_timer_racecond.c | 6 +-----
> app/test/test_version.c | 6 +-----
> 71 files changed, 91 insertions(+), 422 deletions(-)
>
[...]
prev parent reply other threads:[~2016-07-14 17:25 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-13 21:24 [PATCH 1/2] app/test: rework command registration Thomas Monjalon
2016-07-13 21:24 ` [PATCH 2/2] app/test: filter out unavailable tests Thomas Monjalon
2016-07-15 14:23 ` David Marchand
2016-07-15 14:30 ` Thomas Monjalon
2016-07-15 15:25 ` Thomas Monjalon
2016-07-14 17:25 ` viktorin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160714192523.150d8918@jvn \
--to=viktorin@rehivetech.com \
--cc=dev@dpdk.org \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.