From: Theodore Ts'o <tytso@mit.edu>
To: Vegard Nossum <vegard.nossum@oracle.com>
Cc: linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>
Subject: Re: [PATCH] ext4: short-cut orphan cleanup on error
Date: Thu, 14 Jul 2016 23:49:04 -0400 [thread overview]
Message-ID: <20160715034904.GC26465@thunk.org> (raw)
In-Reply-To: <1468104604-18997-1-git-send-email-vegard.nossum@oracle.com>
On Sun, Jul 10, 2016 at 12:50:04AM +0200, Vegard Nossum wrote:
> If we encounter a filesystem error during orphan cleanup, we should stop.
> Otherwise, we may end up in an infinite loop where the same inode is
> processed again and again.
>
> EXT4-fs (loop0): warning: checktime reached, running e2fsck is recommended
> EXT4-fs error (device loop0): ext4_mb_generate_buddy:758: group 2, block bitmap and bg descriptor inconsistent: 6117 vs 0 free clusters
> Aborting journal on device loop0-8.
> EXT4-fs (loop0): Remounting filesystem read-only
> EXT4-fs error (device loop0) in ext4_free_blocks:4895: Journal has aborted
> EXT4-fs error (device loop0) in ext4_do_update_inode:4893: Journal has aborted
> EXT4-fs error (device loop0) in ext4_do_update_inode:4893: Journal has aborted
> EXT4-fs error (device loop0) in ext4_ext_remove_space:3068: IO failure
> EXT4-fs error (device loop0) in ext4_ext_truncate:4667: Journal has aborted
> EXT4-fs error (device loop0) in ext4_orphan_del:2927: Journal has aborted
> EXT4-fs error (device loop0) in ext4_do_update_inode:4893: Journal has aborted
> EXT4-fs (loop0): Inode 16 (00000000618192a0): orphan list check failed!
> [...]
> EXT4-fs (loop0): Inode 16 (0000000061819748): orphan list check failed!
> [...]
> EXT4-fs (loop0): Inode 16 (0000000061819bf0): orphan list check failed!
> [...]
>
> See-also: c9eb13a9105 ("ext4: fix hang when processing corrupted orphaned inode list")
> Cc: Jan Kara <jack@suse.cz>
> Signed-off-by: Vegard Nossum <vegard.nossum@oracle.com>
Applied, thanks.
- Ted
prev parent reply other threads:[~2016-07-15 3:49 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-09 22:50 [PATCH] ext4: short-cut orphan cleanup on error Vegard Nossum
2016-07-15 3:49 ` Theodore Ts'o [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715034904.GC26465@thunk.org \
--to=tytso@mit.edu \
--cc=jack@suse.cz \
--cc=linux-ext4@vger.kernel.org \
--cc=vegard.nossum@oracle.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.