From: Stephen Hemminger <stephen@networkplumber.org>
To: Tom Herbert <tom@herbertland.com>
Cc: <davem@davemloft.net>, <netdev@vger.kernel.org>,
<shemming@brocade.com>, <kernel-team@fb.com>, <haoxuany@fb.com>
Subject: Re: [PATCH iproute 0/5] iproute: ila and fou additions
Date: Fri, 15 Jul 2016 11:23:26 -0700 [thread overview]
Message-ID: <20160715112326.1520599e@xeon-e3> (raw)
In-Reply-To: <1468524136-3389846-1-git-send-email-tom@herbertland.com>
On Thu, 14 Jul 2016 12:22:11 -0700
Tom Herbert <tom@herbertland.com> wrote:
> Patch set includes:
>
> - Allow configuring checksum mode for ila LWT (e.g. configure
> checksum neutral
> - Configuration for performing ila translations using netfilter hook
> - fou encapsulation for ip6tnl and gre6
> - fou listener for IPv6
>
> *** SUBJECT HERE ***
>
> *** BLURB HERE ***
>
> Tom Herbert (5):
> ila: Support for checksum neutral translation
> ila: Support for configuring ila to use netfilter hook
> ip6tnl: Support for fou encapsulation
> gre6: Support for fou encapsulation
> fou: Allowing configuring IPv6 listener
>
> ip/Makefile | 2 +-
> ip/ip.c | 3 +-
> ip/ip_common.h | 1 +
> ip/ipfou.c | 8 +-
> ip/ipila.c | 259 ++++++++++++++++++++++++++++++++++++++++++++++++++
> ip/iproute_lwtunnel.c | 57 ++++++++++-
> ip/link_gre6.c | 101 ++++++++++++++++++++
> ip/link_ip6tnl.c | 92 +++++++++++++++++-
> 8 files changed, 516 insertions(+), 7 deletions(-)
> create mode 100644 ip/ipila.c
>
I am okay with the content of these patches, but they have have lots of style issues.
1. Bad indentation in several spots
2. Lines are too long
3. Use rta_getattr_u64, look for places that access RTA_DATA() directly
5. Run checkpatch
prev parent reply other threads:[~2016-07-15 18:23 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-07-14 19:22 [PATCH iproute 0/5] iproute: ila and fou additions Tom Herbert
2016-07-14 19:22 ` [PATCH iproute 1/5] ila: Support for checksum neutral translation Tom Herbert
2016-07-14 19:22 ` [PATCH iproute 2/5] ila: Support for configuring ila to use netfilter hook Tom Herbert
2016-07-14 19:22 ` [PATCH iproute 3/5] ip6tnl: Support for fou encapsulation Tom Herbert
2016-07-14 19:22 ` [PATCH iproute 4/5] gre6: " Tom Herbert
2016-07-14 19:22 ` [PATCH iproute 5/5] fou: Allowing configuring IPv6 listener Tom Herbert
2016-07-15 18:23 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20160715112326.1520599e@xeon-e3 \
--to=stephen@networkplumber.org \
--cc=davem@davemloft.net \
--cc=haoxuany@fb.com \
--cc=kernel-team@fb.com \
--cc=netdev@vger.kernel.org \
--cc=shemming@brocade.com \
--cc=tom@herbertland.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.